From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter: merge loudnorm filter functionality into f_ebur128.c
Date: Fri, 1 Dec 2023 22:27:15 +0100
Message-ID: <CAPYw7P4tZ6Y4W-s1jRp5JRgJ-Vwv3L_-T+BkwFB+_xQPS+Ld3w@mail.gmail.com> (raw)
In-Reply-To: <CALbjRO+-M=h53Fxz0=BM22HmaDT_ABMtwv+WC7j3sjoz7r8b0g@mail.gmail.com>
On Fri, Dec 1, 2023 at 10:13 PM Kyle Swanson <k@ylo.ph> wrote:
> Hi,
>
> On Fri, Dec 1, 2023 at 2:37 AM Paul B Mahol <onemda@gmail.com> wrote:
> > Keeping old code will not make patch any prettier.
>
> It's not really about pretty, it's about splitting up the patch so we
> can do things one at a time. I think the change to use f_ebur128.c
> loudness computation might have some advantages, but I can't test them
> in isolation. The changes to the loudnorm algorithm I have more
> questions about, but I can't test those in isolation either.
>
Define what isolation means for you?
You all are just allowing poor code state and quality stay.
>
> Thanks,
> Kyle
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-12-01 21:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 21:46 Paul B Mahol
2023-11-15 20:46 ` Paul B Mahol
2023-11-17 6:38 ` Kyle Swanson
2023-11-19 11:56 ` Paul B Mahol
2023-11-19 21:55 ` Marton Balint
2023-11-19 23:37 ` Paul B Mahol
2023-11-21 18:53 ` Kyle Swanson
2023-11-28 16:51 ` Paul B Mahol
2023-11-30 11:43 ` Anton Khirnov
2023-11-30 12:48 ` Paul B Mahol
2023-11-30 13:47 ` Anton Khirnov
2023-11-30 14:01 ` Paul B Mahol
2023-11-30 13:57 ` Anton Khirnov
2023-11-30 14:20 ` Paul B Mahol
2023-11-30 18:34 ` Kyle Swanson
2023-11-30 21:44 ` Paul B Mahol
2023-11-30 22:19 ` Kyle Swanson
2023-11-30 22:51 ` Paul B Mahol
2023-11-30 23:29 ` Kyle Swanson
2023-12-01 10:45 ` Paul B Mahol
2023-12-01 21:12 ` Kyle Swanson
2023-12-01 21:27 ` Paul B Mahol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPYw7P4tZ6Y4W-s1jRp5JRgJ-Vwv3L_-T+BkwFB+_xQPS+Ld3w@mail.gmail.com \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git