From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/dnxhdenc: fix possible out of bound writes for big w/h
Date: Sat, 5 Mar 2022 11:16:27 +0100
Message-ID: <CAPYw7P4sJ_zdoBMDC02=MTw+xLPGYTeuDDF6-OgiL2w5MK70Kw@mail.gmail.com> (raw)
In-Reply-To: <cdcfbef7-7120-74a5-ad33-3640fad2f1ad@martin.st>
On 3/5/22, Martin Storsjö <martin@martin.st> wrote:
> On Fri, 4 Mar 2022, Paul B Mahol wrote:
>
>> ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Fri Mar 4
>> 23:25:48 2022 +0100| [37480b1b85b0405563962b581dc2899b1b4bec59] |
>> committer: Paul B Mahol
>>
>> avcodec/dnxhdenc: fix possible out of bound writes for big w/h
>>
>> It was caused by integer overflows.
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=37480b1b85b0405563962b581dc2899b1b4bec59
>> ---
>
> This caused changes to the hashes in the fate-lavf-mxf_opatom test - can
> you have a look?
>
It caused yet another integer overflow, and max_bits was still bigger
than allowed by few bits.
I changed code to keep increasing qscale until max_bits is lowered.
max_bits is just worst case scenario for bit allocations.
> // Martin
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-03-05 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220304224331.2E33D4104B6@natalya.videolan.org>
2022-03-05 7:55 ` Martin Storsjö
2022-03-05 10:16 ` Paul B Mahol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P4sJ_zdoBMDC02=MTw+xLPGYTeuDDF6-OgiL2w5MK70Kw@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git