From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D757F402A5 for ; Fri, 18 Feb 2022 16:06:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6ED3768B0B8; Fri, 18 Feb 2022 18:06:41 +0200 (EET) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8AB4D68AF87 for ; Fri, 18 Feb 2022 18:06:35 +0200 (EET) Received: by mail-yb1-f176.google.com with SMTP id c6so20499223ybk.3 for ; Fri, 18 Feb 2022 08:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=KGDYQpKoOyaHxR3tAJv6sffURZOCRHr/sGlSuiTXYyw=; b=Dme+GfMAbjFO5gKgU3iVaOcMLXUX/wDX+Tm6lESzEiQhIEBuuzIZT1NsMQkJ0TLwPs TC6NA4aM+Z+C/0FJo6BEea6c98l6eCT/OsyWUwvP7CyBpukywV/GCPtqzBaGGpRmfxOj k4X1CtG1Mr8Dp1i4/chGO4sZ9X85n1QGZUgkuXUoojVJklPqZcgpckPFJENRF4avDUlT Mw04Pp6YLQoFDCiq4h4EeWe6fKtQdF1LX6LSvpRbKO+LUfw/5EFg6QM4Fe6kpiT4GuiF bv3JxS1MI7HueyXnYeK2G7Gibzgy3eB49clUcIxY94huYSXq0QqRJ5AeSglUOxDqT0yW A//A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=KGDYQpKoOyaHxR3tAJv6sffURZOCRHr/sGlSuiTXYyw=; b=7zuwOI7l5dWtX/SbQhepApqmftw9Hh1VmP19XpZedjbpXr8Ng9jcU0bF9P5LRxavNc 9kkLOBgV8YBBGe+XmirtkejJhIGxJlxJDg7A/6VgodVZJNmbsNekalmU72uuMX/UAg1s 59k2ZSaunZyOmorRRf562WElsAQWNIcQshluwE7kQJLIX2ikMmqfCaQb92uea6N/Sjuj t2hSnNupYcIlA8rAWQDIkD6Q/a5rCHsWDkhZfqO6lMBdaDNqo/jFpvHWwrUDjq+NzoFH 4KAW3TOAwBi5RdhZVK3XCpSlWtc/V4BoPmlkqeQf/XE9bjYb2jZJtuHhynU1RYAnvhg3 Dw0A== X-Gm-Message-State: AOAM533iCqDpnwqTSiWbi7CuSRH1WFypPS51093yTSreSxrQcjUlulcn aT7iHE0vzpWOF3lLsUQ/lOHdx/iF9Xgjtda/kphKjrkgN7Q= X-Google-Smtp-Source: ABdhPJw0YGt9zu+A331Wz1pc/1SGH+B7Nfpm02j2OF65yYa+UhzLmyUMFxv2/fj0qNgrDFzxQwAtOOC0Q9t9TC0O/ao= X-Received: by 2002:a25:94a:0:b0:615:7cf4:e2cd with SMTP id u10-20020a25094a000000b006157cf4e2cdmr8087978ybm.227.1645200394115; Fri, 18 Feb 2022 08:06:34 -0800 (PST) MIME-Version: 1.0 References: <20210115045832.76405-1-borbarak@fb.com> <3fa8e9b2-6824-eb3a-2390-22fd024efa9f@mail.de> <164363001951.23111.4989616914372511566@lain.red.khirnov.net> In-Reply-To: From: Paul B Mahol Date: Fri, 18 Feb 2022 17:08:02 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avfilter: Added siti filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Feb 12, 2022 at 11:55 AM Thilo Borgmann wrote: > Am 31.01.22 um 12:55 schrieb James Almer: > > > > > > On 1/31/2022 8:53 AM, Anton Khirnov wrote: > >> Quoting Thilo Borgmann (2022-01-18 14:58:07) > >>>>> Violations of code style. > >>> > >>> Enhanced. > >> > >> Not enough. There are still many remaining, e.g. > >> * opening brace of a function definition should be on its own line > >> * the context should generally be the first argument > >> * unsigned char* should be uint8_t* > >> * mixed declarations and code (the compiler should warn about that) > > > > I think someone said that clang (or some versions) is apparently not > warning about this, hence why so many of these end up being missed in > reviews or even by the patch author. > > This and all of Anton's comments in v3. Also removed some more obviously > useless doubles. > Why it uses doubles in so many places? Is there any real benefit in that, except extra slowdown? > > Thanks, > Thilo_______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".