From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AE61847808 for ; Fri, 22 Sep 2023 22:01:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 19AC668C8F7; Sat, 23 Sep 2023 01:01:26 +0300 (EEST) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4456168C848 for ; Sat, 23 Sep 2023 01:01:19 +0300 (EEST) Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-4526b9404b0so2996456137.0 for ; Fri, 22 Sep 2023 15:01:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695420077; x=1696024877; darn=ffmpeg.org; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Ffk+eyk6JRLLJ/JDpa/Tt0cnQz6A+WCgEpLSV/xQkIk=; b=b6ghJ2/mLORVKTMoW8MuhJfdHFoz/TPGj4fAgFr3zQoy5yNGYa0z2i4Kd1ioHoSkIL mqoxXA+bVDkyS2+IaFoOLMJVOr7ImgWhB0WhvHZChpdHXzGan3LcxlBt5w5dCByHygN1 3TcJ0l6MNe/eXyxSFb1zi5+fKx45DXtVXMM1gPMyTJII8c5tLhjJBe8/H7YHDp44cYn7 3rdJcjU8RovxuN3++dZUw3+xGowETDJUCICC8JnIeQV5+4FhrgnENa8wg+A83aEwIMK0 FGPjIIsp/vjXMjn9Z0mmBFcKu/w2T8jT4nr8MC8I6B0hNtgLTWK2Mo1x1lrrWmY0RGa8 xjzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695420077; x=1696024877; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ffk+eyk6JRLLJ/JDpa/Tt0cnQz6A+WCgEpLSV/xQkIk=; b=vJHcooIVE/Uz8eX4IdDeaPofxCrGiu2IObeE1sfz/OG70OYDFahE8tH9dc1liFkGMz ZCDDB2McdUfr0nD/iVytxF5GTENY7Ey9IwKJOs3CEq96QDbfByZJhKc0RN68pACbb4WT gFOv9sxjhwIbZPMHwlYEtTfhdzfW4w7cztjyrmwn6HG2DENba5LN82jFkEW2DxfO6UJn riLE+8E9TBln6VwaEqu/xr21XMt4TK6H2Jk/kUnzj33m+vMostpTmw4gK39QCbikhObB 331+MKWfu1KMlxPQFS++UQwXqvCTnp48BStfxMrTUI5A8Led0a9ByuWq2sg0MGjOalzS dMCw== X-Gm-Message-State: AOJu0Yzce0FZXUEjrO5IKjFyKadbyAw5jo9/qaTZl1PW9nEFhQ4QpUbR j0btbpBOZZ6UbBZdrzBlB7sXJVLgMqYXTcYMkEFusyaRyXE= X-Google-Smtp-Source: AGHT+IGTwXCs9IZXFCfmjqDr4UD/xMLhrw6TNmQpFCo72MxlBc2VIHPGxdya7nXxiWft7ze88rHj4pJli/+bdMpn678= X-Received: by 2002:a67:f249:0:b0:452:75be:26a4 with SMTP id y9-20020a67f249000000b0045275be26a4mr742900vsm.6.1695420077740; Fri, 22 Sep 2023 15:01:17 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a59:9f50:0:b0:3eb:b4c:bd4f with HTTP; Fri, 22 Sep 2023 15:01:17 -0700 (PDT) In-Reply-To: <20230922215215.GA3543730@pb2> References: <20230726235916.30058-1-michael@niedermayer.cc> <20230922192204.GC8640@pb2> <20230922212616.GH8640@pb2> <20230922215215.GA3543730@pb2> From: Paul B Mahol Date: Sat, 23 Sep 2023 00:01:17 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/4] avcodec/rtv1: Check if the minimal size is available in decode_rtv1() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/22/23, Michael Niedermayer wrote: > On Fri, Sep 22, 2023 at 11:30:37PM +0200, Paul B Mahol wrote: >> On 9/22/23, Michael Niedermayer wrote: >> > On Fri, Sep 22, 2023 at 09:32:47PM +0200, Paul B Mahol wrote: >> >> On 9/22/23, Michael Niedermayer wrote: >> >> > On Thu, Jul 27, 2023 at 01:59:13AM +0200, Michael Niedermayer wrote: >> >> >> Signed-off-by: Michael Niedermayer >> >> >> --- >> >> >> libavcodec/rtv1.c | 6 +++++- >> >> >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> > >> >> > will apply 1-3 of this patchset >> >> >> >> Are you sure this does not break decoding? >> > >> > Well, its a loop over 4x4 blocks, a 16bit "skip" run so the minimum >> > check looks correct. >> > There are 2 end of bitstream checks for early exit but they look like >> > error handling not some normal exit as they leave the frame >> > uninitialized >> > >> >> FFmpeg default initialization code for AVFrame's buffers does it >> twice, so they are always zeroed or previous values of previous >> buffers in pool. > > its rare that correct frame decoding depends on internal AVFrame buffer > ordering > Users are supposed to use error checking. And I think decoder returns error on missing frame data. When we lost interest in preserving all decoded frame pixels as much as possible? > >> >> > Do you have some files so i can double check this is not breaking >> > anything >> >> Search trac tickets. > > thanks, found a zip with 2 video files > ill check it > > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > "I am not trying to be anyone's saviour, I'm trying to think about the > future and not be sad" - Elon Musk > > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".