From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 680EB44232 for ; Fri, 2 Dec 2022 16:10:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 66CCA68B86B; Fri, 2 Dec 2022 18:10:27 +0200 (EET) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5EB3068B3EA for ; Fri, 2 Dec 2022 18:10:20 +0200 (EET) Received: by mail-vs1-f41.google.com with SMTP id 3so4203721vsq.7 for ; Fri, 02 Dec 2022 08:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=PCO6Anm8TmOavy4dzNzs+8Lf6x1tXjVWngfrJ9JUbtI=; b=IG5I0xj1kKBWWOeeXCBst0MAXK0Le75sFyvyoOjT0DqlTN21TmEnh9c7DpkNnh2a8a 9fiogF+H+x7pnvjQCjFHWQa5+2+iR5PFZKB1LXxLbEswAIDepk1Nz4jAfbn+Za7/2Z66 7yMyFVW68fcJkWPYPJ2z5Iy2yRw9kx0Tb13GUQbOMugoGZNAhivcHwYkh0wBzBuCHIYY KhC6JcFvKqr96nYS7iYpg9h79VeWKCAGImZhUpgPU10uI6fGGANRzhbgjt9I1h/YP2lk D+foQss5OkivVxJKLqht16gGlqbrvNipRast5G1R1r2zdkbFpqZPW63/XLUV8TmVPvwQ PrUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PCO6Anm8TmOavy4dzNzs+8Lf6x1tXjVWngfrJ9JUbtI=; b=v2YxRqJi/pFMJ0pCoh4WOhUIZb81Hv76KO2VanCGXsVEUDyU2QmC7OiWSQ6iMm4m4z I0//B2pHCTNBGO3XZGlpdKZnLMM5KsdlR+YiBrlgJ592/aZZ3xv9G3/Yl+7lu9eeWJXt P6l+Wsu/qJwVaQTtq55SIQ9Xexx7sqACXJM4zM2O++YvT0OZ5HUmKI2R0J7PSSwqvsRK Dx3il1GnJlPHx3l7Dd9sZEOPc4IsyjcdUTZsGJ1vWHDV0zdl3YfW3RPdgq7u+CZM+OzO Tm/y6FrjbU/8qj2d2T5WeLVpyg5gcDJNCmTfpmX29oQUpMOtsp/+8syU++3ZpUw1xCwA Baug== X-Gm-Message-State: ANoB5plHZAHp1BAssYXP5MoLWYpjIIGJDSF63gMtLDLGWu5/YHqTu4vv e80nh3OpT7Yckk4Pm0YMl8FJyaDZ4AnpYs4x6Bs/3wjY X-Google-Smtp-Source: AA0mqf7FmSRjC7Wj/IqmkODeYpJnI2EOF5m+nySObcxOeMmGuFfVgngfjPlsxEXsZs6EBK2jzDsvrZV61GGzNritwXY= X-Received: by 2002:a67:ea04:0:b0:3a7:d7bc:c2e9 with SMTP id g4-20020a67ea04000000b003a7d7bcc2e9mr31506228vso.61.1669997418526; Fri, 02 Dec 2022 08:10:18 -0800 (PST) MIME-Version: 1.0 References: <20220911142721.30812-1-michael@niedermayer.cc> <20220911142721.30812-2-michael@niedermayer.cc> <20221201195600.GS3806951@pb2> In-Reply-To: <20221201195600.GS3806951@pb2> From: Paul B Mahol Date: Fri, 2 Dec 2022 17:14:58 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Fix overflow in k=31 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Dec 1, 2022 at 8:56 PM Michael Niedermayer wrote: > On Wed, Nov 30, 2022 at 09:39:44PM +0100, Paul B Mahol wrote: > > On 9/11/22, Michael Niedermayer wrote: > > > Untested with "non fuzzed" samples as i have no such file > > > > > > > Then create it. > > the official WavPack-5.6.0 decoder has 2 alternative optimized codepathes > #ifdef USE_BITMASK_TABLES > extras = bitset [bitcount] - maxcode - 1; > #else > extras = (1 << bitcount) - maxcode - 1; > #endif > > The 2nd path would result in the same 1<<32 which is undefined but luckily > the first seems hardcoded to be used it uses this table: > > const uint32_t bitset [] = { > 1L << 0, 1L << 1, 1L << 2, 1L << 3, > 1L << 4, 1L << 5, 1L << 6, 1L << 7, > 1L << 8, 1L << 9, 1L << 10, 1L << 11, > 1L << 12, 1L << 13, 1L << 14, 1L << 15, > 1L << 16, 1L << 17, 1L << 18, 1L << 19, > 1L << 20, 1L << 21, 1L << 22, 1L << 23, > 1L << 24, 1L << 25, 1L << 26, 1L << 27, > 1L << 28, 1L << 29, 1L << 30, 1L << 31 > }; > > here bitset[32] is out of array > > Given above i suspect no valid file should use this. Otherwise something > seriously odd is going on. > > also the subject has a typo its p=31 not k=31 > > thx > OK > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > The real ebay dictionary, page 2 > "100% positive feedback" - "All either got their money back or didnt > complain" > "Best seller ever, very honest" - "Seller refunded buyer after failed scam" > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".