From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Fix overflow in k=31
Date: Fri, 2 Dec 2022 17:14:58 +0100
Message-ID: <CAPYw7P4fa6iMUT6UaCHxtXrMW+KwaXjsBnKW5a+5xY_JX+T-PA@mail.gmail.com> (raw)
In-Reply-To: <20221201195600.GS3806951@pb2>
On Thu, Dec 1, 2022 at 8:56 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> On Wed, Nov 30, 2022 at 09:39:44PM +0100, Paul B Mahol wrote:
> > On 9/11/22, Michael Niedermayer <michael@niedermayer.cc> wrote:
> > > Untested with "non fuzzed" samples as i have no such file
> > >
> >
> > Then create it.
>
> the official WavPack-5.6.0 decoder has 2 alternative optimized codepathes
> #ifdef USE_BITMASK_TABLES
> extras = bitset [bitcount] - maxcode - 1;
> #else
> extras = (1 << bitcount) - maxcode - 1;
> #endif
>
> The 2nd path would result in the same 1<<32 which is undefined but luckily
> the first seems hardcoded to be used it uses this table:
>
> const uint32_t bitset [] = {
> 1L << 0, 1L << 1, 1L << 2, 1L << 3,
> 1L << 4, 1L << 5, 1L << 6, 1L << 7,
> 1L << 8, 1L << 9, 1L << 10, 1L << 11,
> 1L << 12, 1L << 13, 1L << 14, 1L << 15,
> 1L << 16, 1L << 17, 1L << 18, 1L << 19,
> 1L << 20, 1L << 21, 1L << 22, 1L << 23,
> 1L << 24, 1L << 25, 1L << 26, 1L << 27,
> 1L << 28, 1L << 29, 1L << 30, 1L << 31
> };
>
> here bitset[32] is out of array
>
> Given above i suspect no valid file should use this. Otherwise something
> seriously odd is going on.
>
> also the subject has a typo its p=31 not k=31
>
> thx
>
OK
>
> [...]
>
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The real ebay dictionary, page 2
> "100% positive feedback" - "All either got their money back or didnt
> complain"
> "Best seller ever, very honest" - "Seller refunded buyer after failed scam"
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-12-02 16:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 14:27 [FFmpeg-devel] [PATCH 1/5] avformat/mxfdec: Avoid some redundant writing to tables in mxf_compute_ptses_fake_index() Michael Niedermayer
2022-09-11 14:27 ` [FFmpeg-devel] [PATCH 2/5] avcodec/wavpack: Fix overflow in k=31 Michael Niedermayer
2022-11-30 20:25 ` Michael Niedermayer
2022-11-30 20:39 ` Paul B Mahol
2022-12-01 19:56 ` Michael Niedermayer
2022-12-02 16:14 ` Paul B Mahol [this message]
2022-12-02 23:11 ` Michael Niedermayer
2022-09-11 14:27 ` [FFmpeg-devel] [PATCH 3/5] avcodec/wavpack: Check for end of input in wv_unpack_dsd_high() Michael Niedermayer
2022-11-30 20:27 ` Michael Niedermayer
2022-09-11 14:27 ` [FFmpeg-devel] [PATCH 4/5] avcodec/hdrdec: Update w in inner loop of decompress() Michael Niedermayer
2022-09-16 18:37 ` Michael Niedermayer
2022-09-11 14:27 ` [FFmpeg-devel] [PATCH 5/5] tools/target_dec_fuzzer: Adjust threshold for Jpeg2000 Michael Niedermayer
2022-09-16 18:51 ` Michael Niedermayer
2022-09-20 11:12 ` [FFmpeg-devel] [PATCH 1/5] avformat/mxfdec: Avoid some redundant writing to tables in mxf_compute_ptses_fake_index() Tomas Härdin
2022-09-22 15:02 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPYw7P4fa6iMUT6UaCHxtXrMW+KwaXjsBnKW5a+5xY_JX+T-PA@mail.gmail.com \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git