From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BDAD342A3C for ; Tue, 7 Feb 2023 17:04:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 88C7B68BD6B; Tue, 7 Feb 2023 19:04:26 +0200 (EET) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8221D68BD33 for ; Tue, 7 Feb 2023 19:04:20 +0200 (EET) Received: by mail-vs1-f41.google.com with SMTP id z22so3006385vsq.11 for ; Tue, 07 Feb 2023 09:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=C9omzg3gTK54IdYJZNHAGJKEBMDD2VWR93gBfba28fo=; b=niH3zOOzY9nB7zKXIcMxeeND/APU5SyPKsQRWj7mHboXeDe9hwOoWjOmnklknkvZu2 iLwnsFGyl9C1aUnEstOKyjW+PyWN1OS1FCGg9ZLJo3cnIB9iMcNujGbBmMi7gwEyGz0S k4AObtdtVPE7/dROyyQZiYBZoawuo7lT1YoqSbpVUrIF7rBAI5jl9YXDx8Tlgjadi4fT LpoS5hI9mfcHUyT407sf5RsiQe/NnjpzoaOkYM33wMFG8T7JtnCJoheWyNRG/nhjug3r 5dzMjj9uBkzsOzzYi/twdWSLjtHEwooBQ0ZsqUjg9Ycnn40XuJ8CgiJHLl/R51+rz3nW E8YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C9omzg3gTK54IdYJZNHAGJKEBMDD2VWR93gBfba28fo=; b=SXWeiXBzPaf4gs4azGxOY/YtWk0WGJw8LiHD/e5kzjlQN0UX5s0MJVHhMZC2Dy53wP oviYGMw2U6JIEypXHVAkjyePISORjx+a4Dx+eJAEU4JxPrfyD1ifK5r7goLZ/6N7KM44 pLpdhOA/gRsSHpRESL8pMhas7ubYic6UPp8g2jF+QZqjxlOMDciMnKBT85SodtgjJARU XFEUU6XHSgq4jNjz/gEEZ2cbjO6RKiXVW7hwaj0lT1HL1NvK9N8iWOODkgWWpfoQiSgU 2nSKXhtyFcN6L/spjl9OX8OEsypUJMBDBosR8sf/2Rr8z0s145i0JwdnsmqK0qq9v6iq +efw== X-Gm-Message-State: AO0yUKWrPXWle2KuJ8w0mljQElmMcULYLTY4JjLjmUNEgLsqkdoSC7Bc oZNYyLrntoI+/O8MnNTSYUQLPG2vDnz0AxpNygo+CWcm X-Google-Smtp-Source: AK7set9o9Ki0hAF7eR7fBFa7g0ZPICd/Q7I7LlSHBkdXbtYnvJnc0bXGKZSUAKSX0S10c1D4YveUhM0Rv+Vg3G99QAg= X-Received: by 2002:a67:c29c:0:b0:3f1:7158:eebd with SMTP id k28-20020a67c29c000000b003f17158eebdmr854714vsj.15.1675789459096; Tue, 07 Feb 2023 09:04:19 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Tue, 7 Feb 2023 09:04:17 -0800 (PST) In-Reply-To: References: <20230205195814.GO1949656@pb2> From: Paul B Mahol Date: Tue, 7 Feb 2023 18:04:17 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter: fix af_pan regression X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/5/23, Paul B Mahol wrote: > On 2/5/23, Michael Niedermayer wrote: >> On Sat, Feb 04, 2023 at 09:48:38PM +0100, Paul B Mahol wrote: >>> Patch attached. >> >>> af_pan.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> bf878b3bd193e6462d1babf5e6e45a056a3a0f65 >>> 0001-avfilter-af_pan-fix-regression-introduced-with-switc.patch >>> From b53fa290876af0f540a99f733193f270103bf8ad Mon Sep 17 00:00:00 2001 >>> From: Paul B Mahol >>> Date: Sat, 4 Feb 2023 21:46:15 +0100 >>> Subject: [PATCH] avfilter/af_pan: fix regression introduced with switch >>> to >>> new >>> channel layout API >>> >>> Fixes #10168 >>> >>> Signed-off-by: Paul B Mahol >>> --- >>> libavfilter/af_pan.c | 3 +++ >>> 1 file changed, 3 insertions(+) >> >> This seems to change fate output > > Oh, fixed, new patch attached. > >> >> @@ -3,23 +3,23 @@ >> #codec_id 0: pcm_s16le >> #sample_rate 0: 44100 >> #channel_layout_name 0: mono >> -0, 0, 0, 1024, 2048, 0x750f0a66 >> -0, 1024, 1024, 1024, 2048, 0x155cf063 >> -0, 2048, 2048, 1024, 2048, 0x1e43fc32 >> -0, 3072, 3072, 1024, 2048, 0x282ffc28 >> -0, 4096, 4096, 1024, 2048, 0x6d7bf000 >> -0, 5120, 5120, 1024, 2048, 0xc0b2f411 >> -0, 6144, 6144, 1024, 2048, 0xd711fb03 >> -0, 7168, 7168, 1024, 2048, 0x3164189c >> -0, 8192, 8192, 1024, 2048, 0x8c69e827 >> -0, 9216, 9216, 1024, 2048, 0x562d0518 >> -0, 10240, 10240, 1024, 2048, 0x380aee27 >> -0, 11264, 11264, 1024, 2048, 0x990a03e4 >> -0, 12288, 12288, 1024, 2048, 0x68d7ef60 >> -0, 13312, 13312, 1024, 2048, 0xd13fef9e >> -0, 14336, 14336, 1024, 2048, 0x009306e4 >> -0, 15360, 15360, 1024, 2048, 0x51850390 >> -0, 16384, 16384, 1024, 2048, 0xcd3ceeae >> -0, 17408, 17408, 1024, 2048, 0x189ff277 >> -0, 18432, 18432, 1024, 2048, 0x4b98f68c >> -0, 19456, 19456, 1024, 2048, 0x34eaf544 >> +0, 0, 0, 1024, 2048, 0xd883fc1d >> +0, 1024, 1024, 1024, 2048, 0xbfd0f2a0 >> +0, 2048, 2048, 1024, 2048, 0x88b90294 >> +0, 3072, 3072, 1024, 2048, 0x60dcf6f4 >> +0, 4096, 4096, 1024, 2048, 0x2cde0191 >> +0, 5120, 5120, 1024, 2048, 0x4543e9ea >> +0, 6144, 6144, 1024, 2048, 0x4f73f86b >> +0, 7168, 7168, 1024, 2048, 0x1a600893 >> +0, 8192, 8192, 1024, 2048, 0x02f3fe62 >> +0, 9216, 9216, 1024, 2048, 0xdbf200ac >> +0, 10240, 10240, 1024, 2048, 0xd806ebf7 >> +0, 11264, 11264, 1024, 2048, 0xb2d9f805 >> +0, 12288, 12288, 1024, 2048, 0x47bb087b >> +0, 13312, 13312, 1024, 2048, 0x96520fb5 >> +0, 14336, 14336, 1024, 2048, 0xfb8efbd5 >> +0, 15360, 15360, 1024, 2048, 0xbf2f03ed >> +0, 16384, 16384, 1024, 2048, 0xde80fd74 >> +0, 17408, 17408, 1024, 2048, 0xf204e97d >> +0, 18432, 18432, 1024, 2048, 0x260cf5d2 >> +0, 19456, 19456, 1024, 2048, 0x0d02ff6c >> Test filter-pan-mono1 failed. Look at >> tests/data/fate/filter-pan-mono1.err >> for details. >> tests/Makefile:306: recipe for target 'fate-filter-pan-mono1' failed >> >> [...] >> >> -- >> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB >> >> Old school: Use the lowest level language in which you can solve the >> problem >> conveniently. >> New school: Use the highest level language in which the latest >> supercomputer >> can solve the problem without the user falling asleep >> waiting. >> > This is very big regression, so will apply ASAP! _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".