From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5B79C44B5F for ; Sun, 5 Feb 2023 20:37:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9566968BD9B; Sun, 5 Feb 2023 22:37:19 +0200 (EET) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A16B768A5F8 for ; Sun, 5 Feb 2023 22:37:12 +0200 (EET) Received: by mail-ua1-f50.google.com with SMTP id b11so1835076uae.4 for ; Sun, 05 Feb 2023 12:37:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=g7FzjpSdeaPHha0i6h5LVcGI4wXBR6HCMo0D6qGOHJA=; b=FuqXOUyoxz61SdrGp3OKNc0B/dKHqadWsiLtVcTH+zL2dJHCeFvvSUtyrvT12oTqSb g/q/NXuf2Rp65RKy+fjcSBasR4GllLTkcKzW+pPSNuqFjVtFKi7UX0k0UXVDvDu4v6KY KPtvT4rQJBOQeoPhdo12CkbdcgfGi0QqrOvQ35s4xPuCTWEzijC2+MXuEPIXfzeqaBlv FeaxfcS376MG74Jm5iS//rxpT9tkdXOKG78tRblKjMaXGabYNsKm52IhydKHxy0HAdwt zQnVryA3xitAEXuZeni5lfJb6sMIk2LysXjMFPAlnITpIRqxHOd09uyerxaeb5OJ6SoR kAtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g7FzjpSdeaPHha0i6h5LVcGI4wXBR6HCMo0D6qGOHJA=; b=RQnzbGnaOyB/h5ln+uZPNvtiGdDjD0giv8Ur1r1UbwAj53IMRUtsSFhoUSnfwU0D/X bWtrcmD5NeU9+OUtPB7+vdGO3v/eX8N5n+Y4BmREbuQYNftOmUUWSPtUY1wI5xUE156B qyogRahSxAnaoia1UmODFiDC4GLtJ+SGtlOZJgvzqWHdtd6aCfOdBVIKJ3XDNlSbx2wr suC6I1rWP90+9TIy3TyZYrQQzp7HvYZz/Uaf/1/xmxtJEQ/Jp0l+/KaaOLGTsMHfO0eX ewTOZIarqpRfQ0Z8hIoFwefBeDLli7JeGEKveujZIkNJGLOC4WYE1dbSTbbbaCN/oTJf MNYA== X-Gm-Message-State: AO0yUKVlSKa13IGf6hJ6ezNYQZxP3YL4LOiqdHF2/0bicbsIudTZyZAX URdI1nWRCW22XtDnUDjt70andmJ+euZjMn+tyzWiWiJ0 X-Google-Smtp-Source: AK7set+IzoChbbP6eaEuP173NxVVA8bvw5LPkA/jJH39u4cCPOVsP6Q17XiKSkAEmQ6KFLKQLlLpqq2cW66hLYsDHCw= X-Received: by 2002:ab0:5a08:0:b0:65d:15a9:7862 with SMTP id l8-20020ab05a08000000b0065d15a97862mr2675573uad.69.1675629431023; Sun, 05 Feb 2023 12:37:11 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Sun, 5 Feb 2023 12:37:09 -0800 (PST) In-Reply-To: <20230205195814.GO1949656@pb2> References: <20230205195814.GO1949656@pb2> From: Paul B Mahol Date: Sun, 5 Feb 2023 21:37:09 +0100 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="00000000000003035d05f3f9e11d" Subject: Re: [FFmpeg-devel] [PATCH] avfilter: fix af_pan regression X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --00000000000003035d05f3f9e11d Content-Type: text/plain; charset="UTF-8" On 2/5/23, Michael Niedermayer wrote: > On Sat, Feb 04, 2023 at 09:48:38PM +0100, Paul B Mahol wrote: >> Patch attached. > >> af_pan.c | 3 +++ >> 1 file changed, 3 insertions(+) >> bf878b3bd193e6462d1babf5e6e45a056a3a0f65 >> 0001-avfilter-af_pan-fix-regression-introduced-with-switc.patch >> From b53fa290876af0f540a99f733193f270103bf8ad Mon Sep 17 00:00:00 2001 >> From: Paul B Mahol >> Date: Sat, 4 Feb 2023 21:46:15 +0100 >> Subject: [PATCH] avfilter/af_pan: fix regression introduced with switch to >> new >> channel layout API >> >> Fixes #10168 >> >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/af_pan.c | 3 +++ >> 1 file changed, 3 insertions(+) > > This seems to change fate output Oh, fixed, new patch attached. > > @@ -3,23 +3,23 @@ > #codec_id 0: pcm_s16le > #sample_rate 0: 44100 > #channel_layout_name 0: mono > -0, 0, 0, 1024, 2048, 0x750f0a66 > -0, 1024, 1024, 1024, 2048, 0x155cf063 > -0, 2048, 2048, 1024, 2048, 0x1e43fc32 > -0, 3072, 3072, 1024, 2048, 0x282ffc28 > -0, 4096, 4096, 1024, 2048, 0x6d7bf000 > -0, 5120, 5120, 1024, 2048, 0xc0b2f411 > -0, 6144, 6144, 1024, 2048, 0xd711fb03 > -0, 7168, 7168, 1024, 2048, 0x3164189c > -0, 8192, 8192, 1024, 2048, 0x8c69e827 > -0, 9216, 9216, 1024, 2048, 0x562d0518 > -0, 10240, 10240, 1024, 2048, 0x380aee27 > -0, 11264, 11264, 1024, 2048, 0x990a03e4 > -0, 12288, 12288, 1024, 2048, 0x68d7ef60 > -0, 13312, 13312, 1024, 2048, 0xd13fef9e > -0, 14336, 14336, 1024, 2048, 0x009306e4 > -0, 15360, 15360, 1024, 2048, 0x51850390 > -0, 16384, 16384, 1024, 2048, 0xcd3ceeae > -0, 17408, 17408, 1024, 2048, 0x189ff277 > -0, 18432, 18432, 1024, 2048, 0x4b98f68c > -0, 19456, 19456, 1024, 2048, 0x34eaf544 > +0, 0, 0, 1024, 2048, 0xd883fc1d > +0, 1024, 1024, 1024, 2048, 0xbfd0f2a0 > +0, 2048, 2048, 1024, 2048, 0x88b90294 > +0, 3072, 3072, 1024, 2048, 0x60dcf6f4 > +0, 4096, 4096, 1024, 2048, 0x2cde0191 > +0, 5120, 5120, 1024, 2048, 0x4543e9ea > +0, 6144, 6144, 1024, 2048, 0x4f73f86b > +0, 7168, 7168, 1024, 2048, 0x1a600893 > +0, 8192, 8192, 1024, 2048, 0x02f3fe62 > +0, 9216, 9216, 1024, 2048, 0xdbf200ac > +0, 10240, 10240, 1024, 2048, 0xd806ebf7 > +0, 11264, 11264, 1024, 2048, 0xb2d9f805 > +0, 12288, 12288, 1024, 2048, 0x47bb087b > +0, 13312, 13312, 1024, 2048, 0x96520fb5 > +0, 14336, 14336, 1024, 2048, 0xfb8efbd5 > +0, 15360, 15360, 1024, 2048, 0xbf2f03ed > +0, 16384, 16384, 1024, 2048, 0xde80fd74 > +0, 17408, 17408, 1024, 2048, 0xf204e97d > +0, 18432, 18432, 1024, 2048, 0x260cf5d2 > +0, 19456, 19456, 1024, 2048, 0x0d02ff6c > Test filter-pan-mono1 failed. Look at tests/data/fate/filter-pan-mono1.err > for details. > tests/Makefile:306: recipe for target 'fate-filter-pan-mono1' failed > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Old school: Use the lowest level language in which you can solve the > problem > conveniently. > New school: Use the highest level language in which the latest > supercomputer > can solve the problem without the user falling asleep waiting. > --00000000000003035d05f3f9e11d Content-Type: text/x-patch; charset="US-ASCII"; name="0001-avfilter-af_pan-fix-regression-introduced-with-switc.patch" Content-Disposition: attachment; filename="0001-avfilter-af_pan-fix-regression-introduced-with-switc.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: file0 RnJvbSA4ZTk0ODg5OWQ3ZGI0ZTkyYzBiNzI4YzU5ZjRmMjUwMWE0YzcyYmI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEIgTWFob2wgPG9uZW1kYUBnbWFpbC5jb20+CkRhdGU6 IFNhdCwgNCBGZWIgMjAyMyAyMTo0NjoxNSArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMV0gYXZmaWx0 ZXIvYWZfcGFuOiBmaXggcmVncmVzc2lvbiBpbnRyb2R1Y2VkIHdpdGggc3dpdGNoIHRvCiBuZXcg Y2hhbm5lbCBsYXlvdXQgQVBJCgpGaXhlcyAjMTAxNjgKClNpZ25lZC1vZmYtYnk6IFBhdWwgQiBN YWhvbCA8b25lbWRhQGdtYWlsLmNvbT4KLS0tCiBsaWJhdmZpbHRlci9hZl9wYW4uYyB8IDYgKysr KystCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZm IC0tZ2l0IGEvbGliYXZmaWx0ZXIvYWZfcGFuLmMgYi9saWJhdmZpbHRlci9hZl9wYW4uYwppbmRl eCAwNjdmNjQ2ODA1Li44MGMxOTRiMDY2IDEwMDY0NAotLS0gYS9saWJhdmZpbHRlci9hZl9wYW4u YworKysgYi9saWJhdmZpbHRlci9hZl9wYW4uYwpAQCAtMzEzLDcgKzMxMyw5IEBAIHN0YXRpYyBp bnQgY29uZmlnX3Byb3BzKEFWRmlsdGVyTGluayAqbGluaykKICAgICAgICAgICAgIHBhbi0+Y2hh bm5lbF9tYXBbaV0gPSBjaF9pZDsKICAgICAgICAgfQogCi0gICAgICAgIGF2X29wdF9zZXRfaW50 KHBhbi0+c3dyLCAidWNoIiwgcGFuLT5uYl9vdXRwdXRfY2hhbm5lbHMsIDApOworICAgICAgICBh dl9vcHRfc2V0X2NobGF5b3V0KHBhbi0+c3dyLCAiaWNobCIsICZsaW5rLT5jaF9sYXlvdXQsIDAp OworICAgICAgICBhdl9vcHRfc2V0X2NobGF5b3V0KHBhbi0+c3dyLCAib2NobCIsICZwYW4tPm91 dF9jaGFubmVsX2xheW91dCwgMCk7CisgICAgICAgIGF2X29wdF9zZXRfaW50KHBhbi0+c3dyLCAi dWNoIiwgbGluay0+Y2hfbGF5b3V0Lm5iX2NoYW5uZWxzLCAwKTsKICAgICAgICAgc3dyX3NldF9j aGFubmVsX21hcHBpbmcocGFuLT5zd3IsIHBhbi0+Y2hhbm5lbF9tYXApOwogICAgIH0gZWxzZSB7 CiAgICAgICAgIC8vIHJlbm9ybWFsaXplCkBAIC0zMzMsNiArMzM1LDggQEAgc3RhdGljIGludCBj b25maWdfcHJvcHMoQVZGaWx0ZXJMaW5rICpsaW5rKQogICAgICAgICAgICAgZm9yIChqID0gMDsg aiA8IGxpbmstPmNoX2xheW91dC5uYl9jaGFubmVsczsgaisrKQogICAgICAgICAgICAgICAgIHBh bi0+Z2FpbltpXVtqXSAvPSB0OwogICAgICAgICB9CisgICAgICAgIGF2X29wdF9zZXRfY2hsYXlv dXQocGFuLT5zd3IsICJpY2hsIiwgJmxpbmstPmNoX2xheW91dCwgMCk7CisgICAgICAgIGF2X29w dF9zZXRfY2hsYXlvdXQocGFuLT5zd3IsICJvY2hsIiwgJnBhbi0+b3V0X2NoYW5uZWxfbGF5b3V0 LCAwKTsKICAgICAgICAgc3dyX3NldF9tYXRyaXgocGFuLT5zd3IsIHBhbi0+Z2FpblswXSwgcGFu LT5nYWluWzFdIC0gcGFuLT5nYWluWzBdKTsKICAgICB9CiAKLS0gCjIuMzkuMQoK --00000000000003035d05f3f9e11d Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000003035d05f3f9e11d--