From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 00DC944526 for ; Wed, 14 Sep 2022 15:48:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4B2A068BB36; Wed, 14 Sep 2022 18:48:20 +0300 (EEST) Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5A39968BADF for ; Wed, 14 Sep 2022 18:48:14 +0300 (EEST) Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-333a4a5d495so185626217b3.10 for ; Wed, 14 Sep 2022 08:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date; bh=D0PsPq0K69x01qpNyKMz9tpoyNZn8GAZvNRkBRJ1/s8=; b=aPtgkiTU0WjbaAi4wre92bEwL0weEvwzhB0hL2lWN9xbIeIGoPpfa2GNRL1Nx5P0YV vmdDugjEnn5Xmuw+Rydaf81Ou+pGIXf20OCvuTtt754+lxvKhpiBcg1LTGFwE1MvS7dV i1Rno/YRHdJBAQsC1QAgsZtdqyW7dIYU6beMqEjNafWfbUC3fO//ZYmWLoa1JdIBRvJM vBCe4JTCIphuUi6fZ9wTdkDLEHihXaE1fcK4Mcc8w9JWgGEd13StOMDKD9VRUZT6gLzF wuVnLxdRg03cW2sHGqXiVp2P/IXNSRuTG4xbo0k2C2tzEQpigZyszKOkPdRMCEPoDnON FFXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=D0PsPq0K69x01qpNyKMz9tpoyNZn8GAZvNRkBRJ1/s8=; b=R6AbMdYK6Wcffj7h4C/oscH1wIg1OcrQsK7olwccGP4wHjmjeUJTrHggOpN09Hx6Ie PLgLBGHC/GTvFF4pqxwiAKgsHb+hWzXZ6TS5vRHl7TuKD6EnwvDdCZxDijQinJTmV0HY UfnVCCZ5fUyqu7jIoaLh7dpdTfsLWoPnHpN5DA46UeRVr420rghOAD5Vj5lFEva92ECh /nE//3n0N3Ix4fhaJTfoIeNfWlLPKwLSNp1BamyNcckK0bQhuTG4M0T1JR9fd7ZYIq8d VT9otzOO4FYpdxgvn51a0FBgrTXR9btabiOZlL0OVka6TkD+AhdT9xkINzekOwz+cF28 5aFg== X-Gm-Message-State: ACgBeo0+tYQ7XuMYNmY8CDpvMEJO1On72JPDEAhMejBj7tm1JdtbZ400 4A8nRrQR/eSq5GQny1YmBNvyVGlEKhM+ksIJfIPXvQ+V X-Google-Smtp-Source: AA6agR4rOVqpIiWJlPAM7DxzShx8Qgpc/IIbj2++re43oZnZ8VMliR85MsaYoxy/ItMEa1EzjqGHqamEZ2Xm/h+KlRw= X-Received: by 2002:a81:4e4e:0:b0:348:8a78:9905 with SMTP id c75-20020a814e4e000000b003488a789905mr26145906ywb.40.1663170492825; Wed, 14 Sep 2022 08:48:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a81:7402:0:0:0:0:0 with HTTP; Wed, 14 Sep 2022 08:48:12 -0700 (PDT) In-Reply-To: References: <20220903092144.569716-1-mvanb1@gmail.com> <20220903092144.569716-2-mvanb1@gmail.com> From: Paul B Mahol Date: Wed, 14 Sep 2022 17:48:12 +0200 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/14/22, Martijn van Beurden wrote: > Op wo 14 sep. 2022 om 15:03 schreef Andreas Rheinhardt < > andreas.rheinhardt@outlook.com>: > >> > --- a/libavcodec/flacdec.c >> > +++ b/libavcodec/flacdec.c >> > @@ -64,6 +64,9 @@ typedef struct FLACContext { >> > int32_t *decoded[FLAC_MAX_CHANNELS]; ///< decoded samples >> > uint8_t *decoded_buffer; >> > unsigned int decoded_buffer_size; >> > + int64_t *decoded_33bps; ///< decoded samples for >> > a >> 33 bps subframe >> > + uint8_t *decoded_buffer_33bps; >> >> Why do you need a new buffer here instead of just reusing decoded_buffer? >> >> > I don't follow, do you mean I could have decoded_33bps use decoded_buffer > too? Wouldn't that kind of aliasing lead to problems? What kind of aliasing? > > >> > + av_fast_malloc(&s->decoded_buffer_33bps, >> &s->decoded_buffer_size_33bps, buf_size); >> > + if (!s->decoded_buffer) >> >> You are checking the wrong variable. >> >> > I'll fix that, thanks! > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".