Re: [FFmpeg-devel] [PATCH] avcodec: add Radiance HDR image format support

[Paul B Mahol <onemda@gmail.com>]

On Wed, Jul 6, 2022 at 8:50 PM James Almer <jamrial@gmail.com> wrote:

> On 7/6/2022 3:47 PM, Paul B Mahol wrote:
> > Added parser.
> > The test will be added after this is merged.
>
> [...]
>
> > diff --git a/libavformat/img2.c b/libavformat/img2.c
> > index 870d2ebbc5..b03075f3b0 100644
> > --- a/libavformat/img2.c
> > +++ b/libavformat/img2.c
> > @@ -91,6 +91,7 @@ const IdStrMap ff_img_tags[] = {
> >      { AV_CODEC_ID_VBN,        "vbn"      },
> >      { AV_CODEC_ID_JPEGXL,     "jxl"      },
> >      { AV_CODEC_ID_QOI,        "qoi"      },
> > +    { AV_CODEC_ID_HDR,        "hdr"      },
>
> This could end up confusing people, so preferably use RHDR or some other
> combination for the codec id.
>

Take it or leave it.

IT is HDR, not going to change.

Confusing can not happen at all it is codec.

>
> >      { AV_CODEC_ID_NONE,       NULL       }
> >  };
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".