From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C52F640691 for ; Sun, 27 Feb 2022 11:54:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 426BD68B097; Sun, 27 Feb 2022 13:54:08 +0200 (EET) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8C1D968B00F for ; Sun, 27 Feb 2022 13:54:01 +0200 (EET) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-2d66f95f1d1so79776657b3.0 for ; Sun, 27 Feb 2022 03:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=2eQEPo+UXal9Pat3zZBjpmbcv+EcdSgZzQA/VEZeVnw=; b=UJNLE7W4YcGEr/Wi+kbMRxYw8RsuPvA+dNWsfxlBUom9dmU9qjHJS6b6AQpOdpU8iL vzqsBblChI07SXzp6dF27o3GZ3o9/w1w3eavlny9OQbA1GGrS3f6j3+1cACYxD9XUsk0 PrO7WwR8rBQORkJdmmF+0MeMVJKUs/OkamVwtz4j3Vz8NiyU/d7gPnSqhK3PnRujI9Uo iT9dpm1BTjcP8Joztp+uYl7s87/WKItrN+RfWyIxvlMk6GViQXvbstzyfONj6w+nUhNI +Dk0Rve/WsoRTuL4WcWkq7BkzwNIjBCrL23Z22zBUW22ADvhltrkMmXdhVQdN/CLDHKx Mnnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=2eQEPo+UXal9Pat3zZBjpmbcv+EcdSgZzQA/VEZeVnw=; b=Ax2oRgGbvc+i8ETIeFforlHsf3c51XiR2/W6bWDH+V4HpYdRE6f8mldwIHdAoFCA54 RIrk0AaX8eEWCBSdssPFx/C5fswL8t5SObzihPKIJDAG7HJozSi/a201lzMq6v0aKtN6 tZA2HtPdSv4z3e0bjrLySfMJRQtOs6VwKTfU5kyJMU4WEsU4N4NhblV1QSyCZsFrkY5d EGKDkCPqVQNGFLjFKKWUwNKqFUfB+L3yIQX3eHNmK24DpxP1zCXKWO98rJqWQxPa0GaD yF6ldoQ/xRoGgFCSWcanNcuceh+gyQmmaJaLphoncC0Nc+NSLGmZXROZyeGMiOAkf+M0 jgfQ== X-Gm-Message-State: AOAM5325I3yxo8XboIYGFE/5VSLpxecizhl6RzhZKo3UAmvFoKL4M1vP XVVvnhmpakIm3I+CoXckVINBE3ZsOaOy0KNRvAb5NbzcOYc= X-Google-Smtp-Source: ABdhPJwJuhpPDC2HWLKAWtW4Dz4niXYN7CpeNHfuAePOf6L3lI7dnBLnRBu9yc1VAhMTlvvu5vsT2xACW2Hz8zdC5uM= X-Received: by 2002:a0d:ddd6:0:b0:2d6:8c55:7ba0 with SMTP id g205-20020a0dddd6000000b002d68c557ba0mr15436616ywe.177.1645962840246; Sun, 27 Feb 2022 03:54:00 -0800 (PST) MIME-Version: 1.0 References: <20220224203039.CD4BB41059B@natalya.videolan.org> In-Reply-To: From: Paul B Mahol Date: Sun, 27 Feb 2022 12:55:29 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, Feb 25, 2022 at 10:08 PM Thierry Foucu wrote: > On Thu, Feb 24, 2022 at 11:50 PM Paul B Mahol wrote: > > > On Thu, Feb 24, 2022 at 11:21 PM Thierry Foucu wrote: > > > > > On Thu, Feb 24, 2022 at 2:19 PM Thierry Foucu > wrote: > > > > > > > > > > > > > > > On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol > wrote: > > > > > > > >> On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu > > > wrote: > > > >> > > > >> > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol > > > wrote: > > > >> > > > > >> > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu < > tfoucu@gmail.com> > > > >> wrote: > > > >> > > > > > >> > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol < > git@videolan.org > > > > > > >> > wrote: > > > >> > > > > > > >> > > > > ffmpeg | branch: master | Paul B Mahol | > > Thu > > > >> Feb > > > >> > 24 > > > >> > > > > 20:32:41 2022 +0100| > > [3715f2f8643695940582ce040b7a052cccfb9db2] > > > | > > > >> > > > > committer: Paul B Mahol > > > >> > > > > > > > >> > > > > avfilter/vf_tpad: if there is no frame to clone return early > > > >> > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3715f2f8643695940582ce040b7a052cccfb9db2 > > > >> > > > > --- > > > >> > > > > > > > >> > > > > libavfilter/vf_tpad.c | 5 +++++ > > > >> > > > > 1 file changed, 5 insertions(+) > > > >> > > > > > > > >> > > > > diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > > >> > > > > index e5acece1e4..120dbcb4d3 100644 > > > >> > > > > --- a/libavfilter/vf_tpad.c > > > >> > > > > +++ b/libavfilter/vf_tpad.c > > > >> > > > > @@ -148,6 +148,11 @@ static int activate(AVFilterContext > *ctx) > > > >> > > > > frame->data, frame->linesize, > > > >> > > > > 0, 0, frame->width, > > > frame->height); > > > >> > > > > } else if (s->stop_mode == 1) { > > > >> > > > > + if (!s->cache_stop) { > > > >> > > > > + s->pad_stop = 0; > > > >> > > > > + ff_outlink_set_status(outlink, AVERROR_EOF, > > > >> s->pts); > > > >> > > > > + return 0; > > > >> > > > > + } > > > >> > > > > frame = av_frame_clone(s->cache_stop); > > > >> > > > > if (!frame) > > > >> > > > > return AVERROR(ENOMEM); > > > >> > > > > > > > >> > > > > > > > >> > > > The problem with this solution is that the tpad will then not > do > > > >> what > > > >> > we > > > >> > > > are expecting, which is padding video track, and the output > file > > > >> will > > > >> > not > > > >> > > > have the desired duration. > > > >> > > > Will it not be better to just output black frame (aka > stop_mode > > == > > > >> 0) , > > > >> > > > something like that? > > > >> > > > > > > >> > > > > > >> > > I doubt that, clone is clone, there is no point in padding > stream > > > that > > > >> > have > > > >> > > no frames at all. > > > >> > > > > > >> > > > > > >> > > > > > >> > The sample I forwarded to JB has video frames. The problem was > that > > > >> there > > > >> > was a re-init of the filter chain after a resolution change and > > after > > > >> the > > > >> > re-init, there were no frames but got frames before the re-init. > > > >> > I will understand for a media file which has NEVER received a > video > > > >> frame > > > >> > and in this case, this is the correct solution. > > > >> > > > > >> > > > >> Hmm, so you encode output with resolution change, why not use scale > > > filter > > > >> as first filter and then no resolution ever change for rest of > graph? > > > >> Adding support for resolution changes to all filters is very time > > > >> consuming > > > >> task and I see no real benefit in doing that now. > > > >> > > > > > > > > We do have the scale filter in front of the tpad filter. Here is the > > > > filter chain we are using > > > > > > > > > > > > > > idet=1.04:1.5,yadif=0:-1:1,scale=+528:+864:flags=bicubic,setsar=1,fps=fps=16.601,tpad=stop_mode=clone:stop_duration=2808ms > > > > > > > > > > > Is this just increasing size instead of setting constant one? > > > > Nope. It will just scale the video to 528x864 > Then why filter is still reinited then? Looks like serious bug to me. > > > > > > > > > > And it does crash. > > > > > > > > Even just fps=fps=16.601,tpad=stop_mode=clone:stop_duration=2808ms > > > > reproduce the problem. > > > > > > > > > > Maybe an option to the tpad filter to decide what should be the output > > when > > > the stop_mode == 1 and cache_stop is NULL? > > > So, in some cases, people may want a color frame, and some other will > > just > > > want to exit right away? > > > > > > > That is too much for a special option. > > > > I understand. > I'm just worried that due to some re-init of the filter chain and the fact > there are filters which may or may not output a frame after the re-init, > the tpad filter will then have no cache frame to clone. And in this case, > the file does not have the length expected. > > I guess if it is documented or av_log, people will be aware of the > potential issue. > > Anyway, thanks a lot for the quick fix. > > > > > > > > > > > > > > > > > > > >> > > > >> > > > >> > > > > >> > > > > >> > > > > > > >> > > > iff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > > > >> > > > index e5acece1e4..5e4062e9f2 100644 > > > >> > > > --- a/libavfilter/vf_tpad.c > > > >> > > > +++ b/libavfilter/vf_tpad.c > > > >> > > > @@ -140,7 +140,7 @@ static int activate(AVFilterContext *ctx) > > > >> > > > ff_outlink_set_status(outlink, AVERROR_EOF, > > s->pts); > > > >> > > > return 0; > > > >> > > > } > > > >> > > > - if (s->stop_mode == 0) { > > > >> > > > + if (s->stop_mode == 0 || !s->cache_stop) { > > > >> > > > frame = ff_get_video_buffer(outlink, outlink->w, > > > >> > > outlink->h); > > > >> > > > if (!frame) > > > >> > > > return AVERROR(ENOMEM); > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> > > > > _______________________________________________ > > > >> > > > > ffmpeg-cvslog mailing list > > > >> > > > > ffmpeg-cvslog@ffmpeg.org > > > >> > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog > > > >> > > > > > > > >> > > > > To unsubscribe, visit link above, or email > > > >> > > > > ffmpeg-cvslog-request@ffmpeg.org with subject > "unsubscribe". > > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > -- > > > >> > > > > > > >> > > > Thierry Foucu > > > >> > > > _______________________________________________ > > > >> > > > ffmpeg-devel mailing list > > > >> > > > ffmpeg-devel@ffmpeg.org > > > >> > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > >> > > > > > > >> > > > To unsubscribe, visit link above, or email > > > >> > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > >> > > > > > > >> > > _______________________________________________ > > > >> > > ffmpeg-devel mailing list > > > >> > > ffmpeg-devel@ffmpeg.org > > > >> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > >> > > > > > >> > > To unsubscribe, visit link above, or email > > > >> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > >> > > > > > >> > > > > >> > > > > >> > -- > > > >> > > > > >> > Thierry Foucu > > > >> > _______________________________________________ > > > >> > ffmpeg-devel mailing list > > > >> > ffmpeg-devel@ffmpeg.org > > > >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > >> > > > > >> > To unsubscribe, visit link above, or email > > > >> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > >> > > > > >> _______________________________________________ > > > >> ffmpeg-devel mailing list > > > >> ffmpeg-devel@ffmpeg.org > > > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > >> > > > >> To unsubscribe, visit link above, or email > > > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > >> > > > > > > > > > > > > -- > > > > > > > > Thierry Foucu > > > > > > > > > > > > > -- > > > > > > Thierry Foucu > > > _______________________________________________ > > > ffmpeg-devel mailing list > > > ffmpeg-devel@ffmpeg.org > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > > > > > -- > > Thierry Foucu > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".