Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/framepool: fix alignment requirements for audio and video filters

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/framepool: fix alignment requirements for audio and video filters

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1062 bytes --]

On Tue, Feb 22, 2022 at 08:22:55AM +0000, Paul B Mahol wrote:
> ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Sun Feb 20 19:06:52 2022 +0100| [17a59a634c39b00a680c6ebbaea58db95594d13d] | committer: Paul B Mahol
> 
> avfilter/framepool: fix alignment requirements for audio and video filters
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=17a59a634c39b00a680c6ebbaea58db95594d13d
> ---
> 
>  libavfilter/audio.c     | 11 +++++------
>  libavfilter/framepool.c | 18 ++++++++----------
>  libavfilter/video.c     | 11 +++++------
>  3 files changed, 18 insertions(+), 22 deletions(-)

This change broke:
./ffmpeg -i matrixbench_mpeg2.mpg -an -vframes 5  -vf "frei0r=perspective:0.2/0.2|0.8/0.2" -qscale 1 perspective.avi

The resulting file looks like it has a messed up linesize

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/framepool: fix alignment requirements for audio and video filters

[Paul B Mahol]

On Sun, Apr 10, 2022 at 11:41 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Tue, Feb 22, 2022 at 08:22:55AM +0000, Paul B Mahol wrote:
> > ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Sun Feb 20
> 19:06:52 2022 +0100| [17a59a634c39b00a680c6ebbaea58db95594d13d] |
> committer: Paul B Mahol
> >
> > avfilter/framepool: fix alignment requirements for audio and video
> filters
> >
> > >
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=17a59a634c39b00a680c6ebbaea58db95594d13d
> > ---
> >
> >  libavfilter/audio.c     | 11 +++++------
> >  libavfilter/framepool.c | 18 ++++++++----------
> >  libavfilter/video.c     | 11 +++++------
> >  3 files changed, 18 insertions(+), 22 deletions(-)
>
> This change broke:
> ./ffmpeg -i matrixbench_mpeg2.mpg -an -vframes 5  -vf
> "frei0r=perspective:0.2/0.2|0.8/0.2" -qscale 1 perspective.avi
>
> The resulting file looks like it has a messed up linesize
>

Are you sure this is not encoder bug?

I'm not willing to invest debugging horrible code of mpeg encoders.


>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Does the universe only have a finite lifespan? No, its going to go on
> forever, its just that you wont like living in it. -- Hiranya Peiri
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/framepool: fix alignment requirements for audio and video filters

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1520 bytes --]

On Sun, Apr 10, 2022 at 11:53:16PM +0200, Paul B Mahol wrote:
> On Sun, Apr 10, 2022 at 11:41 PM Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > On Tue, Feb 22, 2022 at 08:22:55AM +0000, Paul B Mahol wrote:
> > > ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Sun Feb 20
> > 19:06:52 2022 +0100| [17a59a634c39b00a680c6ebbaea58db95594d13d] |
> > committer: Paul B Mahol
> > >
> > > avfilter/framepool: fix alignment requirements for audio and video
> > filters
> > >
> > > >
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=17a59a634c39b00a680c6ebbaea58db95594d13d
> > > ---
> > >
> > >  libavfilter/audio.c     | 11 +++++------
> > >  libavfilter/framepool.c | 18 ++++++++----------
> > >  libavfilter/video.c     | 11 +++++------
> > >  3 files changed, 18 insertions(+), 22 deletions(-)
> >
> > This change broke:
> > ./ffmpeg -i matrixbench_mpeg2.mpg -an -vframes 5  -vf
> > "frei0r=perspective:0.2/0.2|0.8/0.2" -qscale 1 perspective.avi
> >
> > The resulting file looks like it has a messed up linesize
> >
> 
> Are you sure this is not encoder bug?
> 
> I'm not willing to invest debugging horrible code of mpeg encoders.

same issue happens with
./ffmpeg -i matrixbench_mpeg2.mpg -an -vframes 5  -vf "frei0r=perspective:0.2/0.2|0.8/0.2" -qscale 1 -vcodec huffyuv perspective.avi

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/framepool: fix alignment requirements for audio and video filters

[Paul B Mahol]

On Sun, Apr 10, 2022 at 11:53 PM Paul B Mahol <onemda@gmail.com> wrote:

>
>
> On Sun, Apr 10, 2022 at 11:41 PM Michael Niedermayer <
> michael@niedermayer.cc> wrote:
>
>> On Tue, Feb 22, 2022 at 08:22:55AM +0000, Paul B Mahol wrote:
>> > ffmpeg | branch: master | Paul B Mahol <onemda@gmail.com> | Sun Feb 20
>> 19:06:52 2022 +0100| [17a59a634c39b00a680c6ebbaea58db95594d13d] |
>> committer: Paul B Mahol
>> >
>> > avfilter/framepool: fix alignment requirements for audio and video
>> filters
>> >
>> > >
>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=17a59a634c39b00a680c6ebbaea58db95594d13d
>> > ---
>> >
>> >  libavfilter/audio.c     | 11 +++++------
>> >  libavfilter/framepool.c | 18 ++++++++----------
>> >  libavfilter/video.c     | 11 +++++------
>> >  3 files changed, 18 insertions(+), 22 deletions(-)
>>
>> This change broke:
>> ./ffmpeg -i matrixbench_mpeg2.mpg -an -vframes 5  -vf
>> "frei0r=perspective:0.2/0.2|0.8/0.2" -qscale 1 perspective.avi
>>
>> The resulting file looks like it has a messed up linesize
>>
>
> Are you sure this is not encoder bug?
>
> I'm not willing to invest debugging horrible code of mpeg encoders.
>

Actually, frei0r should be removed completely.

It does not handle linesize at all, and never have no support for it.


>
>
>>
>> thx
>>
>> [...]
>> --
>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> Does the universe only have a finite lifespan? No, its going to go on
>> forever, its just that you wont like living in it. -- Hiranya Peiri
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".