From: Paul B Mahol <onemda@gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH] avfilter: add aspace filter Date: Sat, 2 Dec 2023 16:01:29 +0100 Message-ID: <CAPYw7P4GJiDs9wwKniGxbSXj_ydSUFbHEpA_Wfa8gWSKfnoRNA@mail.gmail.com> (raw) In-Reply-To: <170152865723.8914.2241792357738711348@lain.khirnov.net> On Sat, Dec 2, 2023 at 3:51 PM Anton Khirnov <anton@khirnov.net> wrote: > Quoting Paul B Mahol (2023-12-02 15:57:59) > > On Sat, Dec 2, 2023 at 3:44 PM Anton Khirnov <anton@khirnov.net> wrote: > > > > > Quoting Paul B Mahol (2023-12-02 15:42:31) > > > > On Sat, Dec 2, 2023 at 2:47 PM Anton Khirnov <anton@khirnov.net> > wrote: > > > > > > > > > Missing tests. > > > > > > > > > > > > > Float/double cant have tests. > > > > > > They most definitely can. See e.g. amix. > > > > > > > > amix does simple things, I can not guarantee that more advanced > > calculations will work for this case. > > It can work better if float or double output is converted to s16 and s16 > > compared instead. > > If your filter cannot guarantee stable output then your filter is > garbage and should be removed. > > Your work are all garbage and all your mails and commits. > -- > Anton Khirnov > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-12-02 14:53 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-02 13:27 Paul B Mahol 2023-12-02 13:47 ` Anton Khirnov 2023-12-02 14:42 ` Paul B Mahol 2023-12-02 14:44 ` Anton Khirnov 2023-12-02 14:57 ` Paul B Mahol 2023-12-02 14:50 ` Anton Khirnov 2023-12-02 15:01 ` Paul B Mahol [this message] 2023-12-05 14:20 ` Paul B Mahol 2023-12-05 14:23 ` Anton Khirnov 2023-12-05 14:24 ` Paul B Mahol 2023-12-05 14:29 ` Nicolas George via ffmpeg-devel 2023-12-05 17:51 ` Paul B Mahol
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPYw7P4GJiDs9wwKniGxbSXj_ydSUFbHEpA_Wfa8gWSKfnoRNA@mail.gmail.com \ --to=onemda@gmail.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git