From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E7E5A44B7D for ; Sun, 6 Nov 2022 18:28:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B421568B965; Sun, 6 Nov 2022 20:28:57 +0200 (EET) Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0DFBE68B8BF for ; Sun, 6 Nov 2022 20:28:51 +0200 (EET) Received: by mail-vk1-f176.google.com with SMTP id i15so5354010vka.0 for ; Sun, 06 Nov 2022 10:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=cCYOgyfTFD2luxNXLyUCp5GwWO95m5A4GQIZitmcobQ=; b=lEAh/sZCmteLAdmECegQpHMsGgrxaV839QtpX72LnJw5KG6vXyv3SBCOO3Opt5BGan jZlTch60QUh/wybXSO8v6Y89uxUm5s7k8dzK/CSGlkEc4z+e9F4aX9kJGAcZ0x5DMhDM jQuMgLqtDvfcRtZngvqY1BwS1lY1oE4g9RhzLjyuV4dG1ONUD7e+uWQ8acy3HplbuCQQ zK2nWcwVRPiH2praHMVSX7XW7gi29/5t/e0kVK2dddyhIzzkBCv9w4EUIlVMD2Adpp5G 8li4Vokgp3xvuNQn/TUxIQ2gyNInga6fbfUycbE0C+5ZhZHGSt/5vHOwfTDiD/c4iXTp HQiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cCYOgyfTFD2luxNXLyUCp5GwWO95m5A4GQIZitmcobQ=; b=7ejOITeXjSOCpF2VPYFT7kba7mDGvw4aQ2btud9UvpkeH0CFsy7q9rA5ghA3Zf0kkD bhnaz4mSZ8B7n9GxCo6kaQRtohrozybhloaP3Y4lERup7RD9oDwzsdm+RUAkl8Kf6GiU 3OViMZiU+buzRVel57VxEcOi2fPcVShZJiH5QpztxT2lcZuPFGH+0EH+Z88z8vUrGPvo 2McVt6Un5eQdv7lHgEVCdKI0iQLuy701MMZKc9iplA5hJvDi842IwK/s1X28Rgz7Obt5 M8QnL156ABELiGQo1tdeDFiWukogfpFRp6LFoKtuTGEGMpgojuI61xNvJiIHNkaHTv9N RIpA== X-Gm-Message-State: ACrzQf0SPAoFZDyLuWmhM/nlrJkYbNa74YDqGARTew0+X5H2d8SLEygf jrGfRysKit3w9k+0y1sdlMFznARCMIL1YZqnKWeywRS6 X-Google-Smtp-Source: AMsMyM7JmJ5aW/LEaRpnzQoKiRVd/gQGNaRLszyWKLFGdTWX0Z7s924LfsUtJ606Y0A4gf5hKuJ17jj2Wlv18Ve2094= X-Received: by 2002:a1f:2393:0:b0:3b8:42bd:5807 with SMTP id j141-20020a1f2393000000b003b842bd5807mr7114871vkj.39.1667759329816; Sun, 06 Nov 2022 10:28:49 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:612:b0:314:ac6a:1eb7 with HTTP; Sun, 6 Nov 2022 10:28:48 -0800 (PST) In-Reply-To: <20221106123430.1668-3-michael@niedermayer.cc> References: <20221106123430.1668-1-michael@niedermayer.cc> <20221106123430.1668-3-michael@niedermayer.cc> From: Paul B Mahol Date: Sun, 6 Nov 2022 19:28:48 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 3/7] avcodec/bonk: Remove special 32bit case from read_uint_max() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/6/22, Michael Niedermayer wrote: > This case seems not to match the reference decoder and it also > seems not reachable > > Signed-off-by: Michael Niedermayer > --- > libavcodec/bonk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > index 04ea4def2f..fca8c246aa 100644 > --- a/libavcodec/bonk.c > +++ b/libavcodec/bonk.c > @@ -136,8 +136,7 @@ static unsigned read_uint_max(BonkContext *s, uint32_t > max) > if (max == 0) > return 0; > > - if (max >> 31) > - return 32; > + av_assert0(max >> 31 == 0); > > for (unsigned i = 1; i <= max - value; i+=i) > if (get_bits1(&s->gb)) > -- > 2.17.1 Not sure, at your risk. Test lossy mode too. > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".