From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 12A9F448FA for ; Thu, 1 Dec 2022 12:32:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 632AB68B883; Thu, 1 Dec 2022 14:32:07 +0200 (EET) Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id EFD8F68B01C for ; Thu, 1 Dec 2022 14:32:00 +0200 (EET) Received: by mail-ua1-f48.google.com with SMTP id c26so537566uak.5 for ; Thu, 01 Dec 2022 04:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eG99Bfq8D8J8AFgLAB48X3qAEfXGPItXaA1QbbB+viA=; b=DqVYutpMTihQE1wB9wWrRK2fEX48E7eaeFG14ZR5+rssv4vF82XridL6cly+fvWYB8 VTWknLVWy8Rru6L/jQV1llYOwx7BndZcsaXyeE6DJOR1zyeNQ56bnyI6sFYSpak41v+F zvKuIZeWk8R+jTeTqq3qgemjgK8lm3xJMZTK3/NGwNLZ325KH0qZdjvPA1cGLLMjlN6q HNi6gxYwHnKqW59kGndszQH22hVmfGTStSuocb5vCa8bRe5cZTE9eQbCpoqCFa5q3wZC a5Wm5WghXhCenjr+Iya5FzNtAN54xhU+aejwov3AwM86DfAgFBWGheo+OjJOd3TiR8CG Hgug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eG99Bfq8D8J8AFgLAB48X3qAEfXGPItXaA1QbbB+viA=; b=hQYNEA4QgIz8hPI/OyjBadlKZQuA8at/9VVioRE0DVQgJsIgJkI1EKdORNkAjA/vNu OqUVkDAggXDZtuSuLcYVdC3R/FCb5IRLkm/2Zq/Z3Z7J27tPNLLKbQBrcvQk/xF3OpfN POUx2ExFFwxaPQCWpPNSWpNMybG1u6wigexB4kpJCIOpjFjDnglXshusCFJhgS34OiIA 9fuwzhOu6oO8ODNIGdBhm0Ia/hf6ssDwXH8XMXb+jG9POgvlOtsfacl9wjGn5r+bL2D8 mLyD7fv4gu8OE04ygN9FlIAwOxBj7i8hlhpvJMEotoNpZeJ83Jx0SIuvvKIPP9jezEfu jOyA== X-Gm-Message-State: ANoB5pnfQ/9cWPEgwvTt9BtKJ37iPBTbv9FDC2w5TZrW2g1QhKhJd8gj eYJ3k9ze+WTGV6+DVAdvqI4y4ouflvdxASwsRdWOjxTr X-Google-Smtp-Source: AA0mqf7wWL9PFZKZ89zcQZJnsauyjr+oq1h/pp+0TRbvGLmzDWtGJahMwTp3Vyw+3chieDaKdRos1sAfmJumzMYQssA= X-Received: by 2002:ab0:3792:0:b0:418:ec96:c77c with SMTP id d18-20020ab03792000000b00418ec96c77cmr24791094uav.41.1669897919375; Thu, 01 Dec 2022 04:31:59 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Thu, 1 Dec 2022 04:31:58 -0800 (PST) In-Reply-To: References: <20221011172437.36211-1-mvanb1@gmail.com> From: Paul B Mahol Date: Thu, 1 Dec 2022 13:31:58 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v7 0/3] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Martijn van Beurden Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/25/22, Paul B Mahol wrote: > On 10/11/22, Martijn van Beurden wrote: >> Recently libFLAC gained the ability (first released in FLAC 1.4.0) >> to create FLAC files containing 32-bit int PCM samples. To >> keep complexity reasonable, the choice was made to limit residuals >> to 32-bit integers, which the encoder must make sure of. In case >> the encoder cannot find any predictor of which the residuals fit >> this limit, it must default to using a verbatim subframe. Tests have >> shown that this does not happen often (<0.1% of subframes on a >> music corpus of various styles). See also discussion here: >> https://github.com/ietf-wg-cellar/flac-specification/pull/148 >> >> These two patches implement decoding and encoding following this >> format. >> >> Changes since v1: >> fix copy-paste error in encoder, several invocations of >> lpc_encode_choose_datapath used wrong parameters, making FATE fail as >> compression was less than it should be >> >> Changes since v2: >> Rebased decoder part as it didn't apply anymore >> >> Changes since v3: >> Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) >> and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) >> >> Changes since v4: >> Fix check of decoded_buffer_33bps malloc. Fix reading of wasted bits >> for 33bps subframe. Add fate test >> >> Changes since v5: >> Slimmed down 32 bps fate flac test from 2 to 1 input file. Replaced >> -strict -2 with -strict experimental in fate and encoder warning. >> >> Changes since v6: >> Deduplicated function bodies with preprocessor macros in both >> encoder and decoder, declared variables in loop body where possible >> and changed ff_ctz to ff_ctzll where necessary >> >> Martijn van Beurden (3): >> libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM >> libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM >> fate/flac: Add test of 32 bps encoding/decoding >> >> libavcodec/flac.c | 4 +- >> libavcodec/flacdec.c | 218 ++++++++++++++++-- >> libavcodec/flacenc.c | 480 +++++++++++++++++++++++++++++++--------- >> libavcodec/get_bits.h | 12 + >> libavcodec/mathops.h | 9 + >> libavcodec/put_bits.h | 7 + >> libavcodec/put_golomb.h | 14 -- >> tests/fate/flac.mak | 4 + >> 8 files changed, 602 insertions(+), 146 deletions(-) >> >> -- >> 2.30.2 >> > > > > If this is OK, will apply soon. Last time to say no to this patchset. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".