From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_adynamicequalizer: simplify calculations
Date: Sun, 9 Jul 2023 17:36:17 +0200
Message-ID: <CAPYw7P4ANV27Hx8yas822-i+ev1MYH8apY=pmyXmkMsfCArapw@mail.gmail.com> (raw)
In-Reply-To: <3db95051-211a-16e1-8c5d-35a2dacd2d1f@gmail.com>
On Sun, Jul 9, 2023 at 5:24 PM James Almer <jamrial@gmail.com> wrote:
> > ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com <
> https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog>> | Thu Jul 6 16:47:02
> 2023 +0200| [889c2529cc6ef65bb4c4f10aa79ca7ca0070a1aa] | committer: Paul B
> Mahol
> >
> > avfilter/af_adynamicequalizer: simplify calculations
> >
> > >/
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=889c2529cc6ef65bb4c4f10aa79ca7ca0070a1aa
> > /---
> >
> > libavfilter/adynamicequalizer_template.c | 16 ++++++++++------
> > libavfilter/af_adynamicequalizer.c | 2 +-
> > 2 files changed, 11 insertions(+), 7 deletions(-)
> >
> > diff --git a/libavfilter/adynamicequalizer_template.c
> b/libavfilter/adynamicequalizer_template.c
> > index 4f7d58c939..ee9f4a1d5f 100644
> > --- a/libavfilter/adynamicequalizer_template.c
> > +++ b/libavfilter/adynamicequalizer_template.c
> > @@ -26,6 +26,7 @@
> > #undef FMIN
> > #undef CLIP
> > #undef SAMPLE_FORMAT
> > +#undef EPSILON
> > #undef FABS
> > #if DEPTH == 32
> > #define SAMPLE_FORMAT float
> > @@ -39,6 +40,7 @@
> > #define CLIP av_clipf
> > #define FABS fabsf
> > #define ftype float
> > +#define EPSILON (1.f / (1 << 22))
> > #else
> > #define SAMPLE_FORMAT double
> > #define SQRT sqrt
> > @@ -51,6 +53,7 @@
> > #define CLIP av_clipd
> > #define FABS fabs
> > #define ftype double
> > +#define EPSILON (1.0 / (1LL << 51))
> > #endif
>
> You have FLT_EPSILON and DBL_EPSILON for this.
>
>
Those are of different values.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-07-09 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230709095209.D8A5D410705@natalya.videolan.org>
2023-07-09 15:24 ` James Almer
2023-07-09 15:36 ` Paul B Mahol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYw7P4ANV27Hx8yas822-i+ev1MYH8apY=pmyXmkMsfCArapw@mail.gmail.com' \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git