From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EFF92450CF for ; Thu, 5 Jan 2023 22:03:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A1A7668BDB7; Fri, 6 Jan 2023 00:03:35 +0200 (EET) Received: from mail-vs1-f46.google.com (mail-vs1-f46.google.com [209.85.217.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8C08E68BB81 for ; Fri, 6 Jan 2023 00:03:28 +0200 (EET) Received: by mail-vs1-f46.google.com with SMTP id h27so25813792vsq.3 for ; Thu, 05 Jan 2023 14:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=urA/LaRe8/o7yRvuPBFPMRDJsckuMRkTaTWUXa7P3XA=; b=lJsMBJ84bf/PTOLWt+YegyR2l/L2dAT943ZrNlB7J70hNvSG64/kS2nHFWwUGXRM4S D41YD9qTMbpV5xqG1bI3wUlhKuGXBGy/n0YNeV17z4d7HJ+EYB/AD/c9YlDTYXN1zTwm RG9Sp2wKJjxD1S5jonnTR6M3TlEAtwV/4x8X/qVQwVpG42lnaeDK6Op2lW5uHjQqGSxg ov0GKNycZRvIApwmu6HkIPR60G5EPVYRgNRxdXTSA0gPs/WGEYJhNTfBAyhw+Cm3raKn ouMtxATgVPt8eia9EeEeYEUlsDThs6JDSlP7LQ09WsZ+ypHZL7wsuWPGjSZ1spajP9xa BJYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=urA/LaRe8/o7yRvuPBFPMRDJsckuMRkTaTWUXa7P3XA=; b=jKZTMAPzQ3vUOxnEkrg6Qgai1fFcd25Kc2lvdlDvjcJfV6T28pKywAfRvH1MSLJo70 Q4LeXkMXdsXWvn0coF3SdQq+u5s3mieSH7kP6OaJvnPo92k3FPLGGM2P4DCxzu82v9zj YfU0BIeDahqPxaeZaQuJkY7pzqDbQb/g1g83DqaZmXFtExEKYCOSRVfn0rJZmQ3v1FjY v6xzDzYKxM3AAhrkM+2ozClU3l7T/EJRplXT40DlWeeYY7kP1p02pdTV8W6YUtrfzDh7 mHyDd9bPumU0VxTnR4SwdrnFCQFcMO3Z2NuC/IBIs3HLvDA8oFfdRw1nBHb2hmFRbunl +P5A== X-Gm-Message-State: AFqh2kpBE7aUnrmG+7o8r/hljf2TMvdLClSH01ddPpvoyOHa1MrRF4o7 IdW6Nv2vhNJHfkpNSc+I9/KC8Y81AAG/1K0T8N8l6vNk X-Google-Smtp-Source: AMrXdXudNUpbBIMbdUgjAGVRQG4STDa2gDvPrROwBoN/OonG2qSZLHoPsjOj5K5W5ZF5K8z+H+17XKwRGn3cBkYOGOM= X-Received: by 2002:a67:ef1e:0:b0:3ce:967f:49ea with SMTP id j30-20020a67ef1e000000b003ce967f49eamr1656404vsr.36.1672956206708; Thu, 05 Jan 2023 14:03:26 -0800 (PST) MIME-Version: 1.0 References: <20230105205342.GE4028235@pb2> In-Reply-To: <20230105205342.GE4028235@pb2> From: Paul B Mahol Date: Thu, 5 Jan 2023 23:08:25 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Jan 5, 2023 at 9:53 PM Michael Niedermayer wrote: > On Thu, Jan 05, 2023 at 01:44:10PM +0100, Paul B Mahol wrote: > > Patch attached. > > > swresample.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > eee7a0685b44aa867562138a2e2437ecb8844612 > 0001-libswresample-swresample-avoid-s16p-internal-transfe.patch > > From 9c4cd60e2dd41cf98d693c8251f4cfade0807073 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Thu, 5 Jan 2023 13:40:12 +0100 > > Subject: [PATCH] libswresample/swresample: avoid s16p internal transfer > format > > > > Instead use float one by default for sample rate conversions. > > The s16p internal transfer format produces visible and hearable > > quantization artifacts. > > When does this occur and why? > It occurs always. Just compare output with 16bit and int32/float/double. Look at other people report on internet. Look at src.infinitewave.ca > This change should be limited to the case that benefits, this would force > this > even without resampling in some cases. > It is forced only if sample rates between input and output differs. > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > The day soldiers stop bringing you their problems is the day you have > stopped > leading them. They have either lost confidence that you can help or > concluded > you do not care. Either case is a failure of leadership. - Colin Powell > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".