Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format

From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] libswresample: avoid s16p internal processing format
Date: Thu, 5 Jan 2023 23:08:25 +0100
Message-ID: <CAPYw7P48cc7k=WnSxZwDtDcisTT-Kkx2kQNzvOOBtONBGKWvhA@mail.gmail.com> (raw)
In-Reply-To: <20230105205342.GE4028235@pb2>

On Thu, Jan 5, 2023 at 9:53 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Thu, Jan 05, 2023 at 01:44:10PM +0100, Paul B Mahol wrote:
> > Patch attached.
>
> >  swresample.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > eee7a0685b44aa867562138a2e2437ecb8844612
> 0001-libswresample-swresample-avoid-s16p-internal-transfe.patch
> > From 9c4cd60e2dd41cf98d693c8251f4cfade0807073 Mon Sep 17 00:00:00 2001
> > From: Paul B Mahol <onemda@gmail.com>
> > Date: Thu, 5 Jan 2023 13:40:12 +0100
> > Subject: [PATCH] libswresample/swresample: avoid s16p internal transfer
> format
> >
> > Instead use float one by default for sample rate conversions.
> > The s16p internal transfer format produces visible and hearable
> > quantization artifacts.
>
> When does this occur and why?
>

It occurs always. Just compare output with 16bit and int32/float/double.
Look at other people report on internet.
Look at src.infinitewave.ca

> This change should be limited to the case that benefits, this would force
> this
> even without resampling in some cases.
>

It is forced only if sample rates between input and output differs.

>
> thx
>
> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The day soldiers stop bringing you their problems is the day you have
> stopped
> leading them. They have either lost confidence that you can help or
> concluded
> you do not care. Either case is a failure of leadership. - Colin Powell
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".