From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3FD1040907 for ; Thu, 3 Mar 2022 16:46:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 546F368AF51; Thu, 3 Mar 2022 18:46:35 +0200 (EET) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 12E5868A7C8 for ; Thu, 3 Mar 2022 18:46:29 +0200 (EET) Received: by mail-yb1-f179.google.com with SMTP id u61so11383110ybi.11 for ; Thu, 03 Mar 2022 08:46:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=GSaUxcqCUZb1KcZtPqFIaidpFlA9f0c5uNAFvSF7q4M=; b=KFGjcOYIPv64aMojOtb/g5V9reXFgv68CMuj9Dp0FfPbHSEjt00+dpa2fSpOSrtpcn QaqLspJ4Xq92Jjb95Vhey5HKNzp7E9kfI3xqar6uYyByoKQhLRfRvp2lbG5XOEHLwLtC lW83bTbJ7fBCw2oSBcak7na76mZ9deTID6a96o6A17HKXMsm4eXagC7CcPb2ll+UwVqw GdO6C3+/esajzE+POS/YZz6qqGiA4xMt/x5qCE7ljyan/MIiTEB+rPP8hFBSHc9cyoAZ VlSpy4itXQ2F+Ij+Rg3/63a9oB5XDRxK58QQKqiTEqW7IZLfDTP2NjacR68C1/CvUw01 MzKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=GSaUxcqCUZb1KcZtPqFIaidpFlA9f0c5uNAFvSF7q4M=; b=pod9vXclUABuP1/RKa7U58Irn0QPYXze0cI82u5YE+bnEHppC79tgbjkLBoHOAssaZ xNHz+5gZuBfYyy7P9Kk8KY0nORAY58kGccl0PqNkp7Go+uq6rN8hVf/1CppHBi78EpEM 00O/7F6PM0BlY9nIcPRf6Zx+7+5YmQ1feUDv7xpDCfLppxoZnSRRI553MNoDu/eT0BCX gbPA85tZAf/Z0In43ygV8drYyhWhkzt6lQ9nkbWsXK4fF+4cAsLcMbCcxOIVYYCfJYel CzzwiGlipKonvRw6kh6cSY/q49DCD2/VLYguiy6kFCreMzvHsKP3chjMDugHl4zo2FvT TA4w== X-Gm-Message-State: AOAM532zQFdm5HJmReEkVii8zPPT5XTKgW2ZbInBXFpbbIdZ5m+BBxje qSSE/5MRp2h7/Dh5ZNEoMFJU1Qa3tlDAlH4UmvF9ofiySbQ= X-Google-Smtp-Source: ABdhPJwC3ujAC93gI7AMWI4eqC4oG0n/euZJeer3FS/nZAiMTPGK13pLzAI6z2NY13wz3ky6lDi0kJwDNTijZUsQ9Nk= X-Received: by 2002:a25:e308:0:b0:624:b514:513c with SMTP id z8-20020a25e308000000b00624b514513cmr34540085ybd.586.1646325987431; Thu, 03 Mar 2022 08:46:27 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a0d:d9cf:0:0:0:0:0 with HTTP; Thu, 3 Mar 2022 08:46:26 -0800 (PST) In-Reply-To: <1ab7f4c6-ee52-385d-4f81-c28dbb007943@gmail.com> References: <20220301142310.16367-1-jamrial@gmail.com> <1e6e3de9-b08f-6613-ae14-77914b8b8e39@gmail.com> <1ab7f4c6-ee52-385d-4f81-c28dbb007943@gmail.com> From: Paul B Mahol Date: Thu, 3 Mar 2022 17:46:26 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] avfilter/framepool: use av_image_fill_plane_sizes() to calculate pool sizes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/3/22, James Almer wrote: > > > On 3/3/2022 10:56 AM, Paul B Mahol wrote: >> On 3/3/22, James Almer wrote: >>> >>> >>> On 3/1/2022 11:23 AM, James Almer wrote: >>>> Signed-off-by: James Almer >>>> --- >>>> libavfilter/framepool.c | 20 ++++++++++++++------ >>>> 1 file changed, 14 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c >>>> index 5b510c9af9..cf6a1d0ea0 100644 >>>> --- a/libavfilter/framepool.c >>>> +++ b/libavfilter/framepool.c >>>> @@ -57,6 +57,8 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* >>>> (*alloc)(size_t size), >>>> int i, ret; >>>> FFFramePool *pool; >>>> const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(format); >>>> + ptrdiff_t linesizes[4]; >>>> + size_t sizes[4]; >>>> >>>> if (!desc) >>>> return NULL; >>>> @@ -89,13 +91,19 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* >>>> (*alloc)(size_t size), >>>> } >>>> } >>>> >>>> - for (i = 0; i < 4 && pool->linesize[i]; i++) { >>>> - int h = pool->height; >>>> - if (i == 1 || i == 2) >>>> - h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h); >>>> + for (i = 0; i < 4; i++) >>>> + linesizes[i] = pool->linesize[i]; >>>> >>>> - pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + >>>> align, >>>> - alloc); >>>> + if (av_image_fill_plane_sizes(sizes, pool->format, >>>> + FFALIGN(pool->height, align), >>>> + linesizes) < 0) { >>>> + goto fail; >>>> + } >>>> + >>>> + for (i = 0; i < 4 && sizes[i]; i++) { >>>> + if (sizes[i] > SIZE_MAX - align) >>>> + goto fail; >>>> + pool->pools[i] = av_buffer_pool_init(sizes[i] + align, alloc); >>>> if (!pool->pools[i]) >>>> goto fail; >>>> } >>> >>> Ping. I can also remove the height padding if preferred. >> >> It does not work. No? > > It doesn't fix the mpeg encoder issue with yuv422p streams and 64 stride > alignment, no, but it's not strictly about that either. It's a > simplification using existing helpers. Ok, if you need it. > >> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".