From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavc/binkaudio: reset input packet on errors
Date: Sat, 17 Jun 2023 09:49:02 +0200
Message-ID: <CAPYw7P45dsNWFHc1RjCZnL2VStMXjNRj2p4nzZvsiXHBa+pQNg@mail.gmail.com> (raw)
In-Reply-To: <168698801181.21886.12975388745396029037@lain.khirnov.net>
On Sat, Jun 17, 2023 at 9:47 AM Anton Khirnov <anton@khirnov.net> wrote:
> Quoting Paul B Mahol (2023-06-17 09:39:24)
> > On Sat, Jun 17, 2023 at 9:16 AM Anton Khirnov <anton@khirnov.net> wrote:
> >
> > > Quoting Paul B Mahol (2023-06-17 08:35:21)
> > > > On Sat, Jun 17, 2023 at 4:54 AM Anton Khirnov <anton@khirnov.net>
> wrote:
> > > >
> > > > > Make sure we don't repeatedly try to decode the same packet,
> making no
> > > > > progress and possibly causing an infinite loop.
> > > > >
> > > >
> > > > Doesn't all error paths, bellow goto label in function, needs this
> (reset
> > > > of ch_offset to 0 and unref of pkt) ?
> > >
> > > I see no other error paths in that function, beside handling the
> failure
> > > of ff_decode_get_packet().
> > >
> > >
> > get_buffer?
>
> I am adding goto fail for the get_buffer() call in this patch, so I
> don't understand what your concern is.
>
Yes, patch ok.
>
> --
> Anton Khirnov
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-06-17 7:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 2:54 Anton Khirnov
2023-06-17 6:35 ` Paul B Mahol
2023-06-17 7:16 ` Anton Khirnov
2023-06-17 7:39 ` Paul B Mahol
2023-06-17 7:46 ` Anton Khirnov
2023-06-17 7:49 ` Paul B Mahol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPYw7P45dsNWFHc1RjCZnL2VStMXjNRj2p4nzZvsiXHBa+pQNg@mail.gmail.com \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git