From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 386ED42AB5 for ; Sat, 10 Sep 2022 13:19:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 67C0068BB1A; Sat, 10 Sep 2022 16:19:35 +0300 (EEST) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E3E9968B9EC for ; Sat, 10 Sep 2022 16:19:28 +0300 (EEST) Received: by mail-yb1-f173.google.com with SMTP id c9so6478304ybf.5 for ; Sat, 10 Sep 2022 06:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date; bh=sjTUyiMC/k7UZfWJUHhgosSPpHwRMw2sbpM1xpZgdH8=; b=YkJsrUNdZBk8DcHSRau2XG+0PrdP5pnImFFCBeqt/bofu6TZ1avX2lacvXPFoXCmBb otH9ght5KxPzpnaY74/p9d2dMsv4dWBJ7171h0NEiVHQMEg1R0kQui53AmeQVRp7IUE3 zm4Ww7IUa9jOi5BEDXuHFgk/uNTXLDrvZSKPAr7KxoSsFth85YiewiCE+73P5zDmgru+ uhDq90qYX4i62qlVP1O3wwGmPS+pJKBAoksQSx5H5AaLx2MxCpWKarDKckwd1epcZ2BX 5UTvHcWtTK9QhuwpC+2sfZ3P3Z5nLuby5ks8BEraE+aDAb1LVolelw9BYL5G/ZkBuszU IjTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date; bh=sjTUyiMC/k7UZfWJUHhgosSPpHwRMw2sbpM1xpZgdH8=; b=xNV2u02Ja7SPxk+4KmBJ5btv5f8onM3YHqMWVtH6d7H/6rFZdNf+ub/DQyu7U2qEjN yIDzehSgToonkw58DwnaqCuUjPtpkk1L2EntS+mEtwRL9VOIUIDhuzd8WXRTcZGipJvY af7+oWKdMAtaQb3B9m1Mb0zGTGivdcJdG4scQOPb4+edMjGvnroTf7mnHiQhJAKcg/hG oql7b/pGYtA6pvI39Pjd8OCWGq+zPbcypnmHHCdlG4gsrhO8xYEKDAANOKutZcyjY7Cy F4K4k2nVfGH8Q0/c6VzKgWHliTy1mOC1gO3aDLiqX8yRYAdH14gO8b4Jkm6QGUUgZYd0 0stQ== X-Gm-Message-State: ACgBeo1JlRkJ0/Eo7ndsem1UzvEwi9T/aF1wdud6xLooOLPIF2DVPfA/ 2r0vlP+l/X9ZQX7ygr+Z0QWyP852m32891V2ue98Bdh1 X-Google-Smtp-Source: AA6agR7GKuCw+AZFOA1AAFCsbeKmYtYeX8D04NJldyzPA7Cy9iScSaoFwfQ/JeoRrSUFEYHe5dawoSYmkzJOWeAowXw= X-Received: by 2002:a25:5142:0:b0:691:e8f5:e582 with SMTP id f63-20020a255142000000b00691e8f5e582mr14645588ybb.586.1662815967170; Sat, 10 Sep 2022 06:19:27 -0700 (PDT) MIME-Version: 1.0 References: <20220903092144.569716-1-mvanb1@gmail.com> In-Reply-To: From: Paul B Mahol Date: Sat, 10 Sep 2022 15:22:54 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v4 0/2] 32bps FLAC patches X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Sep 10, 2022 at 12:33 PM Martijn van Beurden wrote: > Op za 3 sep. 2022 om 11:21 schreef Martijn van Beurden : > > > Recently libFLAC gained the ability (not in any released version yet > > though) to create FLAC files containing 32-bit int PCM samples. To > > keep complexity reasonable, the choice was made to limit residuals > > to 32-bit integers, which the encoder must make sure of. In case > > the encoder cannot find any predictor of which the residuals fit > > this limit, it must default to using a verbatim subframe. Tests have > > shown that this does not happen often (<0.1% of subframes on a > > music corpus of various styles). See also discussion here: > > https://github.com/ietf-wg-cellar/flac-specification/pull/148 > > > > These two patches implement decoding and encoding following this > > format. > > > > Changes since v1: > > fix copy-paste error in encoder, several invocations of > > lpc_encode_choose_datapath used wrong parameters, making FATE fail as > > compression was less than it should be > > > > Changes since v2: > > Rebased decoder part as it didn't apply anymore > > > > Changes since v3: > > Moved put_golomb part to flacenc.c (as it is now quite specific to FLAC) > > and renamed put_sbits64 to put_sbits63 (and changed assert accordingly) > > > > Martijn van Beurden (2): > > libavcodec/flacdec: Implement decoding of 32 bit-per-sample PCM > > libavcodec/flacenc: Implement encoding of 32 bit-per-sample PCM > > > > libavcodec/flac.c | 4 +- > > libavcodec/flacdec.c | 248 +++++++++++++++++-- > > libavcodec/flacenc.c | 519 ++++++++++++++++++++++++++++++++-------- > > libavcodec/get_bits.h | 12 + > > libavcodec/mathops.h | 9 + > > libavcodec/put_bits.h | 7 + > > libavcodec/put_golomb.h | 14 -- > > 7 files changed, 674 insertions(+), 139 deletions(-) > > > > -- > > 2.30.2 > > > > > Perhaps a little early for a reminder, sorry about that. I'd just like to > add to the above email that the FLAC reference implementation, libFLAC, has > had a release yesterday including the functionality of these patches > (encoding/decoder of 32 bps audio). > Great, it will be merged if there are no more objections. Could add fate test so that it does not get broken. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".