From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9198044A80 for ; Thu, 5 Jan 2023 20:39:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 038C968BD86; Thu, 5 Jan 2023 22:39:56 +0200 (EET) Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1284768B930 for ; Thu, 5 Jan 2023 22:39:50 +0200 (EET) Received: by mail-ua1-f42.google.com with SMTP id f25so8552314uaa.3 for ; Thu, 05 Jan 2023 12:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=n4bsQG6BPSpXUCnhuj2eOh7Cg9sXpS0K1D3YsNVkzK8=; b=encdb8agynKnEyqqcTQy8B8bTUDUSmxadjtXcZYADkiCsfhW7j+wkncwSYeRfPp+oY 3JserzApdpJSaDs1taPDbcBmYd2SX4lncAFtF3zzmbSKyeBypvbjIVdP23uFPw9fSw0N vYRjsvcwOSN2CMCT+uEdONqPJL8Owqaa/8B8u0rKKXXGUfbMAi3/WJfi/BlFIKIc1hUr 3KWnosvZCAoLtee3QH/dx+OSjCBKg25MQsGUskQETYzHhyBardsaLdF1VCbu07ecQeQZ ccPlXDaPhY3UweNJum20yAMrZDV1rCvQGVuvgrtm8Pq8neLHplCmyRYgKFNZeiQQtdAL kSMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n4bsQG6BPSpXUCnhuj2eOh7Cg9sXpS0K1D3YsNVkzK8=; b=k9CubLPa773qz5+LtqDMC4nSt8x/DPWDOfjW+zbX+1bQpPRWkGAanAAngyhkxmtjjH 6Q8Pk5zWvZpy0pVu3lDCd+H+aFiHJQuqeRN1jnyO5OPXxQK8PJ1QIdtmwoHaECWkCOwi RJB5+B4BLE0qadhoD8GMK/twxvKNELZ1an7Pq3jYvK8FZlARkz1BXAPpqVKRmN2KPQ46 Dpr6+IV1z1JCclxCUYK9MiEmrec80PWqdIOQZawlXkp7pqlBWV9nsejOch/1zljM2VwB FFVkHDtPhQBV5EhPO1kG14cgVpK2QI7pGAbdvERPQd8Du9nc4ke3ZmsPnJ17DNT2aEYi w01w== X-Gm-Message-State: AFqh2kr3JjuUaiwlaJNveNcr6DDnTC1Uho9P3x6LP+Ad/BSvSBef6F/e 5KdVvrfn5YSp0swkhm7nV1f8wXGihyjtwrGNGchX6oDl X-Google-Smtp-Source: AMrXdXv6BVlSGwhJWYf+X0SJAEqShg3OZ6CCcOwK1fAE/buL2hgd/laIxnTQzHX/LIYF6nC457v2B9CVx1D1NwlIZjM= X-Received: by 2002:ab0:1d8c:0:b0:447:8177:b614 with SMTP id l12-20020ab01d8c000000b004478177b614mr4998635uak.41.1672951188295; Thu, 05 Jan 2023 12:39:48 -0800 (PST) MIME-Version: 1.0 References: <20230105203433.GD4028235@pb2> In-Reply-To: <20230105203433.GD4028235@pb2> From: Paul B Mahol Date: Thu, 5 Jan 2023 21:44:46 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] swresample fixes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Jan 5, 2023 at 9:34 PM Michael Niedermayer wrote: > On Wed, Jan 04, 2023 at 05:59:14PM +0100, Paul B Mahol wrote: > > Patches attached. > > > af_aresample.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > 94dacb46103e2bb9fbb6e1ca40675243d15069cd > 0003-avfilter-af_aresample-if-frame-parameters-change-upd.patch > > From 3959bcb707f52339bac41acc9aec856cad3aced1 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Wed, 4 Jan 2023 17:55:10 +0100 > > Subject: [PATCH 3/3] avfilter/af_aresample: if frame parameters change > update > > swr context > > > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/af_aresample.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c > > index 7923377c8c..2744388f75 100644 > > --- a/libavfilter/af_aresample.c > > +++ b/libavfilter/af_aresample.c > > @@ -209,8 +209,14 @@ FF_ENABLE_DEPRECATION_WARNINGS > > } else { > > outsamplesref->pts = AV_NOPTS_VALUE; > > } > > +again: > > ret = swr_convert_frame(aresample->swr, outsamplesref, > > (void *)insamplesref); > > + if (ret & (AVERROR_INPUT_CHANGED | AVERROR_OUTPUT_CHANGED)) { > > + swr_close(aresample->swr); > > + goto again; > > + } > > + > > if (ret < 0) { > > av_frame_free(&outsamplesref); > > av_frame_free(&insamplesref); > > Are you sure this is not missing some flushing of internal samples ? > Nope, point is not to flush all internal samples at all, just enough so clicks do not happen. Clicks happen anyway so need to check why. > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > No snowflake in an avalanche ever feels responsible. -- Voltaire > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".