From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 68BF640570 for ; Fri, 25 Feb 2022 07:50:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF95C68B2E1; Fri, 25 Feb 2022 09:50:36 +0200 (EET) Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B528868B2B1; Fri, 25 Feb 2022 09:50:25 +0200 (EET) Received: by mail-yb1-f180.google.com with SMTP id j12so4265234ybh.8; Thu, 24 Feb 2022 23:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Ey4Bzh5wiPf2V/eqV48lJrozdKVYbIGrHHBw+GjQ6A=; b=lRWQNnMtowpRAJvE8luI1V3bec5OQOOABhEzn5Vw5vcxT5zlOS6sGCqRO40WRgc4PK qBmSNdNrk43Okz/kNuK/ALcWwie/25vkrR5yrwYMJ36gk18MX6snMcW6EWcd/ID6BhEX bdx0N5IWEIf3ZHr6E1HKKCdczH5KF8l/i1qCzHSKDxIalFboD5NpZ+tqXy3z7lJPqMgV kfrcROqFlNwrXIp5IvP5PlyB3fC2qPxG3to7p39ZptGU5CJwI+YkfDurtjh6qFBli3eS 5BbF44hwsLmJusxf1tI+yIdjU9IdFVaQm064vIborZJH8RCuwgNpkvlcA72R8OqtS2LW /pmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Ey4Bzh5wiPf2V/eqV48lJrozdKVYbIGrHHBw+GjQ6A=; b=uFmhOshOe09rICJ2H+CrhhvP0XuRil3wj2arq+jmHXv2IrICaYNFqs519WVCOpOO5U 8Xm5VfQNKejkD4bh6eMEJDLbRMKebAvOdnzgLaFobog6c67iyeZUttLVd0o1wjJuYAbB Wlfhz1j1WQ/eic7uOCnrSg+whN79tr8feqiEvIV8rnJd3ngbpPNhoTcppt/ke42nkXIW OsY0m56816rL+LjQ6hSAX+xZ+urEyWxLABogFu2TTN5s/mygJjQQxaQQUzdnyWRUsHdT A42kD6CIbud2jnEDqiV6M7mlFdvcKpNg38jFXImR6DiJFSBin+/2B2TAPzDv+5StAosW Zxuw== X-Gm-Message-State: AOAM530bkaEWOj8qRDhXHdmpikRJ/HPIaem53OEt3uyjVVQ4AtGkGVQb SH9WEyn/L6BHdzgIcb2Ae/zOht8j3IH2En9gKTV4L4lPUX4= X-Google-Smtp-Source: ABdhPJz7kJUqgcQDViAyTcNmmEvazkGRbPfzCC27SNPmbq9ZqidghC/p9VwEiaufZherdQ169i4q8iePfeXvlhIUW3A= X-Received: by 2002:a25:e308:0:b0:624:b514:513c with SMTP id z8-20020a25e308000000b00624b514513cmr6093996ybd.586.1645775424146; Thu, 24 Feb 2022 23:50:24 -0800 (PST) MIME-Version: 1.0 References: <20220224203039.CD4BB41059B@natalya.videolan.org> In-Reply-To: From: Paul B Mahol Date: Fri, 25 Feb 2022 08:51:53 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vf_tpad: if there is no frame to clone return early X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg git commit log and discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Feb 24, 2022 at 11:21 PM Thierry Foucu wrote: > On Thu, Feb 24, 2022 at 2:19 PM Thierry Foucu wrote: > > > > > > > On Thu, Feb 24, 2022 at 1:50 PM Paul B Mahol wrote: > > > >> On Thu, Feb 24, 2022 at 10:36 PM Thierry Foucu > wrote: > >> > >> > On Thu, Feb 24, 2022 at 1:28 PM Paul B Mahol > wrote: > >> > > >> > > On Thu, Feb 24, 2022 at 10:12 PM Thierry Foucu > >> wrote: > >> > > > >> > > > On Thu, Feb 24, 2022 at 12:30 PM Paul B Mahol > >> > wrote: > >> > > > > >> > > > > ffmpeg | branch: master | Paul B Mahol | Thu > >> Feb > >> > 24 > >> > > > > 20:32:41 2022 +0100| [3715f2f8643695940582ce040b7a052cccfb9db2] > | > >> > > > > committer: Paul B Mahol > >> > > > > > >> > > > > avfilter/vf_tpad: if there is no frame to clone return early > >> > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3715f2f8643695940582ce040b7a052cccfb9db2 > >> > > > > --- > >> > > > > > >> > > > > libavfilter/vf_tpad.c | 5 +++++ > >> > > > > 1 file changed, 5 insertions(+) > >> > > > > > >> > > > > diff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > >> > > > > index e5acece1e4..120dbcb4d3 100644 > >> > > > > --- a/libavfilter/vf_tpad.c > >> > > > > +++ b/libavfilter/vf_tpad.c > >> > > > > @@ -148,6 +148,11 @@ static int activate(AVFilterContext *ctx) > >> > > > > frame->data, frame->linesize, > >> > > > > 0, 0, frame->width, > frame->height); > >> > > > > } else if (s->stop_mode == 1) { > >> > > > > + if (!s->cache_stop) { > >> > > > > + s->pad_stop = 0; > >> > > > > + ff_outlink_set_status(outlink, AVERROR_EOF, > >> s->pts); > >> > > > > + return 0; > >> > > > > + } > >> > > > > frame = av_frame_clone(s->cache_stop); > >> > > > > if (!frame) > >> > > > > return AVERROR(ENOMEM); > >> > > > > > >> > > > > > >> > > > The problem with this solution is that the tpad will then not do > >> what > >> > we > >> > > > are expecting, which is padding video track, and the output file > >> will > >> > not > >> > > > have the desired duration. > >> > > > Will it not be better to just output black frame (aka stop_mode == > >> 0) , > >> > > > something like that? > >> > > > > >> > > > >> > > I doubt that, clone is clone, there is no point in padding stream > that > >> > have > >> > > no frames at all. > >> > > > >> > > > >> > > > >> > The sample I forwarded to JB has video frames. The problem was that > >> there > >> > was a re-init of the filter chain after a resolution change and after > >> the > >> > re-init, there were no frames but got frames before the re-init. > >> > I will understand for a media file which has NEVER received a video > >> frame > >> > and in this case, this is the correct solution. > >> > > >> > >> Hmm, so you encode output with resolution change, why not use scale > filter > >> as first filter and then no resolution ever change for rest of graph? > >> Adding support for resolution changes to all filters is very time > >> consuming > >> task and I see no real benefit in doing that now. > >> > > > > We do have the scale filter in front of the tpad filter. Here is the > > filter chain we are using > > > > > idet=1.04:1.5,yadif=0:-1:1,scale=+528:+864:flags=bicubic,setsar=1,fps=fps=16.601,tpad=stop_mode=clone:stop_duration=2808ms > > > Is this just increasing size instead of setting constant one? > > And it does crash. > > > > Even just fps=fps=16.601,tpad=stop_mode=clone:stop_duration=2808ms > > reproduce the problem. > > > > Maybe an option to the tpad filter to decide what should be the output when > the stop_mode == 1 and cache_stop is NULL? > So, in some cases, people may want a color frame, and some other will just > want to exit right away? > That is too much for a special option. > > > > > > > >> > >> > >> > > >> > > >> > > > > >> > > > iff --git a/libavfilter/vf_tpad.c b/libavfilter/vf_tpad.c > >> > > > index e5acece1e4..5e4062e9f2 100644 > >> > > > --- a/libavfilter/vf_tpad.c > >> > > > +++ b/libavfilter/vf_tpad.c > >> > > > @@ -140,7 +140,7 @@ static int activate(AVFilterContext *ctx) > >> > > > ff_outlink_set_status(outlink, AVERROR_EOF, s->pts); > >> > > > return 0; > >> > > > } > >> > > > - if (s->stop_mode == 0) { > >> > > > + if (s->stop_mode == 0 || !s->cache_stop) { > >> > > > frame = ff_get_video_buffer(outlink, outlink->w, > >> > > outlink->h); > >> > > > if (!frame) > >> > > > return AVERROR(ENOMEM); > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > _______________________________________________ > >> > > > > ffmpeg-cvslog mailing list > >> > > > > ffmpeg-cvslog@ffmpeg.org > >> > > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog > >> > > > > > >> > > > > To unsubscribe, visit link above, or email > >> > > > > ffmpeg-cvslog-request@ffmpeg.org with subject "unsubscribe". > >> > > > > > >> > > > > >> > > > > >> > > > -- > >> > > > > >> > > > Thierry Foucu > >> > > > _______________________________________________ > >> > > > ffmpeg-devel mailing list > >> > > > ffmpeg-devel@ffmpeg.org > >> > > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > > > > >> > > > To unsubscribe, visit link above, or email > >> > > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > > > > >> > > _______________________________________________ > >> > > ffmpeg-devel mailing list > >> > > ffmpeg-devel@ffmpeg.org > >> > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > > > >> > > To unsubscribe, visit link above, or email > >> > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > > > >> > > >> > > >> > -- > >> > > >> > Thierry Foucu > >> > _______________________________________________ > >> > ffmpeg-devel mailing list > >> > ffmpeg-devel@ffmpeg.org > >> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > > >> > To unsubscribe, visit link above, or email > >> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > > >> _______________________________________________ > >> ffmpeg-devel mailing list > >> ffmpeg-devel@ffmpeg.org > >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >> > >> To unsubscribe, visit link above, or email > >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > >> > > > > > > -- > > > > Thierry Foucu > > > > > -- > > Thierry Foucu > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".