From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 6/6] avformat/rka: Fix division by 0 for bps < 8
Date: Sun, 9 Apr 2023 21:02:42 +0200
Message-ID: <CAPYw7P411DoPcfRJ8cnW0_YXLWhUDDygTZoCP4KO-mg83bWSgg@mail.gmail.com> (raw)
In-Reply-To: <20230409142627.19820-6-michael@niedermayer.cc>
NAK, bps < 8 is invalid
On Sun, Apr 9, 2023 at 4:27 PM Michael Niedermayer <michael@niedermayer.cc>
wrote:
> Fixes: division by zero
> Fixes:
> 57828/clusterfuzz-testcase-minimized-ffmpeg_dem_RKA_fuzzer-6571818338353152
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by
> <https://github.com/google/oss-fuzz/tree/master/projects/ffmpegSigned-off-by>:
> Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavformat/rka.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/rka.c b/libavformat/rka.c
> index 39e5b3bce12..c83a17c92cc 100644
> --- a/libavformat/rka.c
> +++ b/libavformat/rka.c
> @@ -100,7 +100,7 @@ static int rka_read_header(AVFormatContext *s)
> break;
> }
>
> - if ((r = av_add_index_entry(st, framepos, (i * 131072LL) /
> (channels * (bps >> 3)),
> + if ((r = av_add_index_entry(st, framepos, (i * 131072LL*8) /
> (channels * bps),
> size, 0, AVINDEX_KEYFRAME)) < 0)
> return r;
> framepos += size;
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-04-09 18:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 14:26 [FFmpeg-devel] [PATCH 1/6] avcodec/huffyuvdec: Fix undefined behavior with shift Michael Niedermayer
2023-04-09 14:26 ` [FFmpeg-devel] [PATCH 2/6] avcodec/hevc_ps: Check num_ref_loc_offsets Michael Niedermayer
2023-04-09 14:26 ` [FFmpeg-devel] [PATCH 3/6] avcodec/rka: Fix signed integer overflow in decode_filter() Michael Niedermayer
2023-04-09 14:26 ` [FFmpeg-devel] [PATCH 4/6] avcodec/escape124: Check that blocks are allocated before use Michael Niedermayer
2023-04-09 14:26 ` [FFmpeg-devel] [PATCH 5/6] Revert "avcodec/er: remove check for fields" Michael Niedermayer
2023-04-09 21:15 ` Michael Niedermayer
2023-04-14 0:37 ` Michael Niedermayer
2023-04-09 14:26 ` [FFmpeg-devel] [PATCH 6/6] avformat/rka: Fix division by 0 for bps < 8 Michael Niedermayer
2023-04-09 19:02 ` Paul B Mahol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPYw7P411DoPcfRJ8cnW0_YXLWhUDDygTZoCP4KO-mg83bWSgg@mail.gmail.com \
--to=onemda@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git