From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1B33345096 for ; Wed, 4 Jan 2023 17:30:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8082768BCE0; Wed, 4 Jan 2023 19:30:38 +0200 (EET) Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BE7EF68BBEB for ; Wed, 4 Jan 2023 19:30:32 +0200 (EET) Received: by mail-vs1-f51.google.com with SMTP id k4so31480063vsc.4 for ; Wed, 04 Jan 2023 09:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=tRTd8yqzBfgH0AC2f975ACQY4DrQ0QGgqOF0NC1glkY=; b=PNwdKqlc9S59Fdb9REXeGWveebGjF4bqgnMDF4pYcVr3zMGPmhMwOQbXrIZJ39bBbW d47QznoBT6b9rbBIt7OcJ+kptVTOZove2CNDR4Di9M8BqoK+Fe5+Rbkn0kO1Dyv89Zjb dpkzMMHaTGpiojifmwvD5Vv6gn+Gwbez7iAnm7B45rI0lVj5bcNa2LQF0uSdF5i61Mzr xsl5Y6pEIU4Q06CFrsz5TCHreMCgUJgMee1MxMDbaqd+dG+PJ88X8iPO/ouXnXFQj8az 0rtwbvmVHfOexcpVm3b6MSY6rag5mqbdagYBncdMpQNQtPdgzLDY6w+Ho7ciCcS7JfJg 3fvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tRTd8yqzBfgH0AC2f975ACQY4DrQ0QGgqOF0NC1glkY=; b=cnFUGS18wZRhns1tsBhWUlXbg3hdsDkTGBrNjJwg5VR3gAqUoFPDdl0G0Lm+sPdYvR SpOesHivFnuf7sEn5RTEbUAADvPrv5Fz+8/Rg5XBt3pHrM737QpwZR/lCw0h5eu5OpKN aQdrG/sB/i/b0Z7IBTdl05XVsYTtW7VE6AQlTae27WysVWmMq9O8N2hogNoZ/LJUUPvZ /6/2aYppvzFN0yIVzbr63Wyf0iwzGDHdJcWY9osIwQHIYrdLi8gIxYH4hCNn/hFc+UFZ BTirAHbtiDXkmGZg1VUrxQX+VLtMOlsin/Z+7bb5//A5XQwy2KX3UONcS8QdXUFWxS3e KZAQ== X-Gm-Message-State: AFqh2krOHdxUcGFbB8IOGZiVWcG3i2K+wL7+xaE5no0gGkDqEPNJEkCw 4lVrBIukjc0eGYG4Ctqo+8ERcLU7BieSdWrgT0v07JjU X-Google-Smtp-Source: AMrXdXtoFR8FGxmU8waCzaeCyXixLq4OnuoRxq1NnrlKm47j+1ewY6CGGuvdyGxNHRM6qc0+Va0a8D+pXcJTmqTZhgo= X-Received: by 2002:a67:ec94:0:b0:3b5:32d0:edcc with SMTP id h20-20020a67ec94000000b003b532d0edccmr5421961vsp.24.1672853431462; Wed, 04 Jan 2023 09:30:31 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Paul B Mahol Date: Wed, 4 Jan 2023 18:35:30 +0100 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] swresample fixes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, Jan 4, 2023 at 6:26 PM Andreas Rheinhardt < andreas.rheinhardt@outlook.com> wrote: > Paul B Mahol: > > diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c > > index 7923377c8c..2744388f75 100644 > > --- a/libavfilter/af_aresample.c > > +++ b/libavfilter/af_aresample.c > > @@ -209,8 +209,14 @@ FF_ENABLE_DEPRECATION_WARNINGS > > } else { > > outsamplesref->pts = AV_NOPTS_VALUE; > > } > > +again: > > ret = swr_convert_frame(aresample->swr, outsamplesref, > > (void *)insamplesref); > > + if (ret & (AVERROR_INPUT_CHANGED | AVERROR_OUTPUT_CHANGED)) { > > This is wrong: There are lots of errors besides AVERROR_INPUT_CHANGED, > AVERROR_OUTPUT_CHANGED and AVERROR_INPUT_CHANGED | > AVERROR_OUTPUT_CHANGED for which this condition is true. See also ticket > #9343. > So what you propose? > > > + swr_close(aresample->swr); > > + goto again; > > + } > > + > > if (ret < 0) { > > av_frame_free(&outsamplesref); > > av_frame_free(&insamplesref); > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".