Re: [FFmpeg-devel] [PATCH] swresample fixes

From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] swresample fixes
Date: Wed, 4 Jan 2023 18:35:30 +0100
Message-ID: <CAPYw7P4-5PPpy_1y_KBQd_Y4ZXq5uyCdqo76Y5h17E8BRemodA@mail.gmail.com> (raw)
In-Reply-To: <AS8P250MB07441205F39F70DE9E34BD858FF59@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>

On Wed, Jan 4, 2023 at 6:26 PM Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Paul B Mahol:
> > diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c
> > index 7923377c8c..2744388f75 100644
> > --- a/libavfilter/af_aresample.c
> > +++ b/libavfilter/af_aresample.c
> > @@ -209,8 +209,14 @@ FF_ENABLE_DEPRECATION_WARNINGS
> >      } else {
> >          outsamplesref->pts  = AV_NOPTS_VALUE;
> >      }
> > +again:
> >      ret = swr_convert_frame(aresample->swr, outsamplesref,
> >                              (void *)insamplesref);
> > +    if (ret & (AVERROR_INPUT_CHANGED | AVERROR_OUTPUT_CHANGED)) {
>
> This is wrong: There are lots of errors besides AVERROR_INPUT_CHANGED,
> AVERROR_OUTPUT_CHANGED and AVERROR_INPUT_CHANGED |
> AVERROR_OUTPUT_CHANGED for which this condition is true. See also ticket
> #9343.
>

So what you propose?

>
> > +        swr_close(aresample->swr);
> > +        goto again;
> > +    }
> > +
> >      if (ret < 0) {
> >          av_frame_free(&outsamplesref);
> >          av_frame_free(&insamplesref);
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".