From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6E0CE453C2 for ; Fri, 27 Jan 2023 17:31:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A410A68BE6E; Fri, 27 Jan 2023 19:31:17 +0200 (EET) Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F3BE568BE35 for ; Fri, 27 Jan 2023 19:31:10 +0200 (EET) Received: by mail-vk1-f171.google.com with SMTP id l20so2756273vkm.11 for ; Fri, 27 Jan 2023 09:31:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=285h4H1+cjI1GIWgUXpJKGS5+MsA9D8J5pSLVnzYj20=; b=bXUcwrww3nY4aUgd0sUofCGhIjRngSd+dXK1XGQ6GZ3oGsbrTuB8npP2E8ivpKRTBc TIL/Ss7+pfFdd64bDIQS1+OdU2vAppRJ08b1W+AqLcQh8Ki7KzYMVnBo5Y3aW7T2NndH 1yv7ocFP4gwButr/4WnI24W6Vl/er8cpOeoysygmCINMaanyBzp6VhhaO/xLo0KJLy3K +rxAfb8geabYcGuE+e/hhgjQf7RacOt/bcdnWqr3sqxOm5ihCM78SsMsorkdBPG3jgh6 keSiYVp8Kbf6DXblD4xSL4Y3i9BexjmtzXRJg5V4fobClH21vGiA+lJUtT2X/Y2KSaCD wyIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:references:in-reply-to:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=285h4H1+cjI1GIWgUXpJKGS5+MsA9D8J5pSLVnzYj20=; b=sdTZTJgMi01n7yrt15tkV/tHGpllZUcpUheGvzTevbKxIYkSkINrbMp1Q/dnZ13Y0p TsaSczlzcNNxUyBf2ymMEfvA7rNd7iD3W0adC5mX4Ige0UoFYD2jjDLAl9goYNR07trg Xk3kuy4oHUuOAuqvMNvSUAyI/uX8M63PqAzKHcuSCIjEdoHX6HFG2CCC8WTqG37tLkxC McO7A8xRmYhOfyXobyPTqoO9fPfBx42+PlrFWLbQxXgTfBL/sphQzFn8jNr+pMnMEJDt CzogCubgFQNX/m/jZcic8nnMl/5xXO3pkYuxPKmkSBbQHTu2Y+RVJD+95NFIa3EDNjqD 6g/Q== X-Gm-Message-State: AO0yUKV8qIppkG+RCoZvkPSxH76ESv5WxCDUlFwK2hTXvouWirVIhh6E rUNYpcBfhLmRRY+/aOkmVkeDYVMSZWu/XblXt7n7L2ww X-Google-Smtp-Source: AK7set/Fw6y5G46fJRO2lIynuROB7eZDaUHl3V4Yw62/IU4TozQnIzdLPQCMe/gyBS0vynJ24E0LGjmESEvDup1Uj4A= X-Received: by 2002:a1f:c646:0:b0:3e6:8a8:3387 with SMTP id w67-20020a1fc646000000b003e608a83387mr1295988vkf.39.1674840669531; Fri, 27 Jan 2023 09:31:09 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:612c:2428:b0:32a:5eaa:92e4 with HTTP; Fri, 27 Jan 2023 09:31:08 -0800 (PST) In-Reply-To: <47ee718c-bce0-cffa-9c6a-2889a6547017@tiscali.it> References: <8d713a21-f2f0-5c8d-fa93-0278965509e5@tiscali.it> <47ee718c-bce0-cffa-9c6a-2889a6547017@tiscali.it> From: Paul B Mahol Date: Fri, 27 Jan 2023 18:31:08 +0100 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] drawtext filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/27/23, Francesco Carusi wrote: > On 26/01/2023 17:37, Paul B Mahol wrote: >> On 1/26/23, Francesco Carusi wrote: >>> On 26/01/2023 14:21, Paul B Mahol wrote: >>>> On 1/26/23, Francesco Carusi wrote: >>>>> The drawtext reinit command is also used in the docs as an example for >>>>> the sendcmd filter, so I thought it was fine to use commands in that >>>>> way. In my opinion it is also a convenient way to modify multiple >>>>> options at the same time. >>>>> Should the command match the name of a filter option instead? >>>>> >>>> Please do not top post. >>>> >>>> It is much better to use already existing options for commands that is >>>> more intuitive to users. Also multiple options can be set at runtime, >>>> there is no such limitation. >>> ok, I'm going to remove the "change" command and add commands that match >>> the options that it included. >> Thanks, feel free to ask questions on #ffmpeg-devel irc channel. > I'm attaching the updated patch, I also updated the document at > https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md > Thanks Amazing, I like demos! Could improve code style of newly added/changed lines? For example opening { put on separate line. So code style is in sync with rest of codebase. The commands stuff does not need to use strcmp to detect if option value have been changed, you could avoid strcmp by just caching old value prior to calling function the picks new values, and after that just compare old with new and then if it differs call needed code. >> >>>>> On 26/01/2023 11:50, Paul B Mahol wrote: >>>>>> On 1/26/23, Francesco Carusi wrote: >>>>>>> Hi, I'm new to contributing to ffmpeg! >>>>>>> >>>>>>> I modified the drawtext filter to improve text rendering and add >>>>>>> some >>>>>>> features. You can find a high level description of the changes at >>>>>>> this >>>>>>> link: >>>>>>> >>>>>>> https://github.com/yethie/FFmpeg/blob/master/drawtext/CHANGES.md >>>>>>> >>>>>>> I'm also attaching the patch file. >>>>>>> I looked for the filter maintainer to discuss about the changes I >>>>>>> made >>>>>>> but it looks like there isn't any, am I correct? >>>>>>> >>>>>>> Please let me know if this is the right way to submit my >>>>>>> contribution. >>>>>> Why filter can not support normal commands for options? Like most/all >>>>>> other filters that have support for changing options values at >>>>>> runtime. >>>>>> >>>>>> The reinit and yours added change option(s) are very >>>>>> strange/inconvenient things to do. >>>>>> _______________________________________________ >>>>>> ffmpeg-devel mailing list >>>>>> ffmpeg-devel@ffmpeg.org >>>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>>> >>>>>> To unsubscribe, visit link above, or email >>>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>> _______________________________________________ >>>>> ffmpeg-devel mailing list >>>>> ffmpeg-devel@ffmpeg.org >>>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>>> >>>>> To unsubscribe, visit link above, or email >>>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>>>> >>>> _______________________________________________ >>>> ffmpeg-devel mailing list >>>> ffmpeg-devel@ffmpeg.org >>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>>> >>>> To unsubscribe, visit link above, or email >>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >>> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".