Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests

From: Paul B Mahol <onemda@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests
Date: Mon, 30 May 2022 11:06:33 +0200
Message-ID: <CAPYw7P4+_K9Noib21LHoB4CvWXr7x6dNHdO+8nU7AAfGSHxPHw@mail.gmail.com> (raw)
In-Reply-To: <DM8P223MB036578B4554F97022CC708FDBADD9@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>

On Mon, May 30, 2022 at 10:35 AM Soft Works <softworkz@hotmail.com> wrote:

>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> > Anton Khirnov
> > Sent: Monday, May 30, 2022 9:35 AM
> > To: FFmpeg development discussions and patches <ffmpeg-
> > devel@ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH v2] tests/fate/vcodec: Limit mem
> > alignment for vsynth..mpeg2-422 tests
> >
> > Quoting Soft Works (2022-05-28 15:17:54)
> > > Do you have a better idea?
> > >
> > > The one advantage of this method is that you don’t need to change
> > compilation parameters
> > > nor  any source code. It’s only a runtime flag being set only for
> > this specific family of tests.
> >
> > At the very least, I would expect the commit message to explain what
> > exactly the problem is, and why is it fixed in this seemingly ad-hoc
> > manner.
> >
> > "limit mem alignment to fix failing tests" explains nothing.
>
> BTW, that's not the actual commit message.
> What I have submitted is this:
>
> ------------------------
>
> tests/fate/vcodec: Limit mem alignment for vsynth..mpeg2-422 tests
>
> The tests:
>
> - vsynth2-mpeg2-422
> - vsynth1-mpeg2-422
> - vsynth_lena-mpeg2-422
>
> were failing on newer CPUs where av_cpu_max_align() returns
> values > 32. This patch sets cpuflags to disable avx512
> extensions for those tests only.
>
> Signed-off-by: softworkz <softworkz@hotmail.com>
>
> ------------------------
>
> What do you want me to add to it?
>
>
There appears a very large language barrier present here.

In that FATE thread I explicitly wrote that this or similar solutions are
considered the hack.

sw
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".