From: Christophe Gisquet <christophe.gisquet@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.
Date: Wed, 14 Aug 2024 08:29:37 +0200
Message-ID: <CAPYFPM057QBTMvz6TRMUU4Kc+xk_a5pSW+uy-5pNY=GeaB35nA@mail.gmail.com> (raw)
In-Reply-To: <CAPUDrwe-w+wrw3anGHPBh7a9-7Y2junJAzbXQcm-GmDykFh4Bg@mail.gmail.com>
Hi,
Le mar. 13 août 2024 à 23:39, Dale Curtis <dalecurtis@chromium.org> a écrit :
>
> On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes <h.leppkes@gmail.com> wrote:
>
> > Disabling random codec features seems like an anti-feature to me, in
> > the future it'll make every feature be questioned and compile-time
> > conditional, and make everything terrible.
> > If the context size is the major concern, maybe large structures
> > should be allocated when in use, rather than always?
> >
>
> I agree with that, so here's a version which allocates dynamically instead.
> It passes FATE, but I didn't try with valgrind/msan in case I missed a
> cleanup path.
(not an author)
Probably there is remaining work pending on external dependencies, but
H274FilmGrainDatabase sounds a bit adhoc. The 8KB of slice_tmp for one
could just be a local variable in init_slice(). The 676KB (!) of the
noise database are a bit more puzzling and could be the one that needs
allocating only when the noise is generated. It may simplify a bit
some of the conditions in this patch.
--
Christophe
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-08-14 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 19:31 Dale Curtis
2024-08-13 19:47 ` James Almer
2024-08-13 20:08 ` Dale Curtis
2024-08-13 20:10 ` Hendrik Leppkes
2024-08-13 21:38 ` Dale Curtis
2024-08-14 6:29 ` Christophe Gisquet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPYFPM057QBTMvz6TRMUU4Kc+xk_a5pSW+uy-5pNY=GeaB35nA@mail.gmail.com' \
--to=christophe.gisquet@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git