From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 970ED45DA8 for ; Mon, 10 Apr 2023 17:55:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B4F7268BD37; Mon, 10 Apr 2023 20:55:12 +0300 (EEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C1E7568A799 for ; Mon, 10 Apr 2023 20:55:06 +0300 (EEST) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-3ee6c339cceso199665e9.0 for ; Mon, 10 Apr 2023 10:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1681149305; x=1683741305; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=v/6qSnbtsniQOdH7HgH6qzQrNfG6WXZm+pYfrAVuxoY=; b=ALDHcZ6VXRL2EuhZqA+z+SER4yfxvazjwfEhu1Yb8w262cWlXGu+tTt2aHZa0XkR6a S78jTv4eQc9zhByF6bJ3n5NTJ8p8jDPElciPB2P+baELGC1cqwT2Twke4NaGR7ALseU2 BSfe9bUPr5KqdTOUhe2m9x+1E/U2/ZczIbhek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681149305; x=1683741305; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v/6qSnbtsniQOdH7HgH6qzQrNfG6WXZm+pYfrAVuxoY=; b=ImBY0kycws51P5JsN7A2Sn8xCa5Mqah39O0GukY5O6LpNsmm1QH5ihFcGcx9LzpVDs 7I+/5uSy6PyJN8JG6TSkH8Ue0RSoq+BeDnHBP5210MWM0k/fP/YJnFcTytWeBRbHGLWR Wi9RhuhcklYE875/Lx2wyMrRQbvmmg6mWh0OdrhLSHCJDrhgPdYD3y/GwMdh1peJThy2 HyWRvWL2ETLe7PCqnSlEKNER+H3Qc0Ait6oRB9EoSWQPtgzbcaK4HllJ6yyRFkjW1Hi/ EVtnMVNWBovVW9HedTuvm4Uuf1flpE1KZySkLbR6sIFzrTdwJeWKteGrofR6tUVWgdrW 4k9Q== X-Gm-Message-State: AAQBX9cP/dffHoLNJ4MDg93Biuu4bXROx5HK5F0NjVLVkWmZXynMuLUL PCh+Cq+9GnH/2rpFjGR+7mq0A5Kvu7U5Zxb4BBKK3I7TdAKvGAL2OhQ= X-Google-Smtp-Source: AKy350bSnvK/oE4Z4fKWTq63kgR5oscKYwBwG3JXqbdl0h3BUwl1nfucEt/NXIXE//p610H2wPOwKNC3VdcEykIMAO8= X-Received: by 2002:a05:600c:3c96:b0:3ee:113f:4fd9 with SMTP id bg22-20020a05600c3c9600b003ee113f4fd9mr9207wmb.1.1681149304936; Mon, 10 Apr 2023 10:55:04 -0700 (PDT) MIME-Version: 1.0 References: <2fbbb930-fafa-8fea-b7c4-fd2a15289958@gmail.com> <166437463764.22057.4742937177788601515@lain.khirnov.net> In-Reply-To: <166437463764.22057.4742937177788601515@lain.khirnov.net> From: Dale Curtis Date: Mon, 10 Apr 2023 10:54:52 -0700 Message-ID: To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="00000000000023074905f8ff1309" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavformat/flac_picture: Don't return AVERROR_INVALIDDATA for errors with flac picture mimetype X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --00000000000023074905f8ff1309 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Will left Google, but I've updated the patch to only skip errors when the type is unrecognized. On Wed, Sep 28, 2022 at 7:17=E2=80=AFAM Anton Khirnov w= rote: > IMO failing to recognize the MIME type is a lavf error rather than a > file error and so should not fail, much less with AVERROR_INVALIDDATA > (should be ENOSYS if anything). > --00000000000023074905f8ff1309 Content-Type: application/octet-stream; name="no-error-on-unrecognized.patch" Content-Disposition: attachment; filename="no-error-on-unrecognized.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lgb4voms0 RnJvbSBmZjE5OWJlYTI4NmZkZTc5ZjVkNDg1NDcxM2FiZDkxMTk5NWZjOTlkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYWxlIEN1cnRpcyA8ZGFsZWN1cnRpc0BjaHJvbWl1bS5vcmc+ CkRhdGU6IE1vbiwgMTAgQXByIDIwMjMgMTA6NTI6MDggLTA3MDAKU3ViamVjdDogW1BBVENIXSBE b24ndCB0aHJvdyBhbiBlcnJvciB3aGVuIGF0dGFjaGVkIHBpY3R1cmUgaXNuJ3QgcmVjb2duaXpl ZC4KClRoZSBNSU1FIHR5cGUgZmllbGQgaXMgcmVxdWlyZWQgcGVyIHRoZSBGTEFDIHN0YW5kYXJk LCBidXQgaXQncwpub3QgYW4gZXJyb3IganVzdCBiZWNhdXNlIGZmbXBlZyBkb2Vzbid0IHJlY29n bml6ZSBpdC4KClNpZ25lZC1vZmYtYnk6IERhbGUgQ3VydGlzIDxkYWxlY3VydGlzQGNocm9taXVt Lm9yZz4KLS0tCiBsaWJhdmZvcm1hdC9mbGFjX3BpY3R1cmUuYyB8IDIgLS0KIDEgZmlsZSBjaGFu Z2VkLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpYmF2Zm9ybWF0L2ZsYWNfcGljdHVy ZS5jIGIvbGliYXZmb3JtYXQvZmxhY19waWN0dXJlLmMKaW5kZXggYjMzZmVlNzViNC4uMjBkZjAx OTJkNCAxMDA2NDQKLS0tIGEvbGliYXZmb3JtYXQvZmxhY19waWN0dXJlLmMKKysrIGIvbGliYXZm b3JtYXQvZmxhY19waWN0dXJlLmMKQEAgLTkxLDggKzkxLDYgQEAgaW50IGZmX2ZsYWNfcGFyc2Vf cGljdHVyZShBVkZvcm1hdENvbnRleHQgKnMsIHVpbnQ4X3QgKipidWZwLCBpbnQgYnVmX3NpemUs CiAgICAgaWYgKGlkID09IEFWX0NPREVDX0lEX05PTkUpIHsKICAgICAgICAgYXZfbG9nKHMsIEFW X0xPR19FUlJPUiwgIlVua25vd24gYXR0YWNoZWQgcGljdHVyZSBtaW1ldHlwZTogJXMuXG4iLAog ICAgICAgICAgICAgICAgbWltZXR5cGUpOwotICAgICAgICBpZiAocy0+ZXJyb3JfcmVjb2duaXRp b24gJiBBVl9FRl9FWFBMT0RFKQotICAgICAgICAgICAgcmV0dXJuIEFWRVJST1JfSU5WQUxJRERB VEE7CiAgICAgICAgIHJldHVybiAwOwogICAgIH0KIAotLSAKMi40MC4wLjU3Ny5nYWMxZTQ0MzQy NC1nb29nCgo= --00000000000023074905f8ff1309 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --00000000000023074905f8ff1309--