Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Arnie Chang <arnie.chang-at-sifive.com@ffmpeg.org>
To: "Rémi Denis-Courmont" <remi@remlab.net>
Cc: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] lavc/h264chroma: RISC-V V add motion compensation for 4xH and 2xH chroma blocks
Date: Thu, 15 Jun 2023 22:58:37 +0800
Message-ID: <CAPUBFYFh_C9k429akSpXiwCmhc096wFA0qKf3Ct2zSp6HBLERA@mail.gmail.com> (raw)
In-Reply-To: <3559820.ilfcA4O0Wq@basile.remlab.net>

On Wed, Jun 14, 2023 at 11:57 PM Rémi Denis-Courmont <remi@remlab.net>
wrote:

> It looks like \width is only ever used as AVL. You could advantageously
> pass
> it as a run-time argument to an internal function, and spare the
> instruction
> cache, instead of instantiating otherwise identical code thrice.
>

Since these functions are frequently called, I prefer instantiating similar
code many times
rather than calling another internal function, as it may introduce
additional function call overhead.
Neon and MMX code also apply the same approach.


    slli t3, a2, (1 + \unroll)
>

Brilliant suggestion, I will fix it in the next patch.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-06-15 14:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  7:17 Arnie Chang
2023-06-10 14:55 ` Lynne
2023-06-10 16:43   ` Arnie Chang
2023-06-12 14:59 ` Rémi Denis-Courmont
2023-06-12 15:28   ` Arnie Chang
2023-06-12 15:29     ` Rémi Denis-Courmont
2023-06-14 15:57 ` Rémi Denis-Courmont
2023-06-15 14:58   ` Arnie Chang [this message]
2023-06-15 18:48     ` Rémi Denis-Courmont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPUBFYFh_C9k429akSpXiwCmhc096wFA0qKf3Ct2zSp6HBLERA@mail.gmail.com \
    --to=arnie.chang-at-sifive.com@ffmpeg.org \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=remi@remlab.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git