From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6BF3543E42 for ; Thu, 15 Sep 2022 12:00:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B550068BB9A; Thu, 15 Sep 2022 15:00:20 +0300 (EEST) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D15AB68BAD1 for ; Thu, 15 Sep 2022 15:00:13 +0300 (EEST) Received: by mail-ej1-f46.google.com with SMTP id lc7so41660735ejb.0 for ; Thu, 15 Sep 2022 05:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=AD6HNSt978BCdy0MHj1t2SMeASlW/b3RS++qMTbL5Go=; b=G451S6pxty2+qwqvL+nybi8s9AYskzQjsY68hzrUmsBAFr88jjF1r++EWnkdDCx0DI UOzBJC6iq+tqgYXm+Al0H8VW5uAYROPuEKTgbpEu2Xu930mgzNLt/DnJbOHAAS/+v8f7 NW0HJgq3XL7juowlqwi4nIFEkQY6kkNKmtBgsT+07QCrl2PBLcM4nZVS3XZowuZC2+Vn xiCuo+qQ3Z24TFt3rydEaTrXWlWaHyedUybj8lhuN/YZdMk8jUpXDcHck5FsEv0yBdCy wmflu8y/y/TsjU69oI8XaL6M4ztpaYJHNc9wWm49IErVzH6jb+qQaUQD4NW/9mPqXDhC SYSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=AD6HNSt978BCdy0MHj1t2SMeASlW/b3RS++qMTbL5Go=; b=oKvOHCuEt0ajxfgvx5/WGg3S2cLxhd7Kt5WyyrqE3/2zUEp4Unz6sV+zBdu1W9Eyci ZTaopa7J/hxvNmrVmYa4UNTwLfIIqx8gKF3sYKC8oVVmzd9xpBxkwkWPn7YA5+eLMdCD 4U6fLBTXn+KBfODoVy27npezWKYPkKo3bLBZCgtzMbgsXirp9hTbQw81IG8cTZM2aPUz 5rdspZTT45FdCODqQP3mIshkHvG/VjKEMiUlOXVq3NeRP+7/jJZCnPa0P7xyp6K53ugX GqkEcwKL3gdpy9MHXMnFd6DQZvlqknlYR/DXpl11yaaRM65MsAf42KLIomjLrhLJlQ7h gbAg== X-Gm-Message-State: ACgBeo0GjvSjtaonkx88dhrcKWZQHZrYCexWb+/4W6TppYfMKsKekD1/ 3hI3oJdopArESz0rexqUYu9SoEoiuJzxtmoN1YPbZMgB8ww= X-Google-Smtp-Source: AA6agR66hr7VcolUAQqQmi0OMyN/eCS6/UURD84jcD8kmfAhR3YRofn8jIL99NgVpC+cO/85orxcyojPaeMh5Gyx97s= X-Received: by 2002:a17:906:cc0e:b0:77c:d77:576d with SMTP id ml14-20020a170906cc0e00b0077c0d77576dmr16091607ejb.658.1663243212782; Thu, 15 Sep 2022 05:00:12 -0700 (PDT) MIME-Version: 1.0 From: Jaka Bac Date: Thu, 15 Sep 2022 14:00:01 +0200 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: [FFmpeg-devel] qmax limit 28 in mpegvideo_enc.c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hello, mpegvideo_enc.c contains this check in ff_mpv_encode_init: if (s->q_scale_type == 1) { if (avctx->qmax > 28) { av_log(avctx, AV_LOG_ERROR, "non linear quant only supports qmax <= 28 currently\n"); return AVERROR_PATCHWELCOME; } } This was added in: avcodec/mpeg12enc: extend QP range to 28 for non linear quantizers https://github.com/FFmpeg/FFmpeg/commit/bf2474c74f2c0b956c069f50483c7d104d856d8b After a while there was another commit: avcodec/mpeg12enc: Basic support for encoding non even QPs for -non_linear_quant 1 https://github.com/FFmpeg/FFmpeg/commit/58fe57d5a05ad8d15c320b2bd163debbc412bdd3 I may be completely wrong, but to me it looks like that the second commit lifts the "qmax <= 28 restriction". Or am I missing something? Thanks, Jaka _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".