From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 55ABD49FFD for ; Mon, 18 Mar 2024 06:03:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B23E768D05A; Mon, 18 Mar 2024 08:03:21 +0200 (EET) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CAC1868C5DA for ; Mon, 18 Mar 2024 08:03:14 +0200 (EET) Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-568c714a9c7so1216116a12.2 for ; Sun, 17 Mar 2024 23:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710741794; x=1711346594; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=AzAGNRRGjlXrFmJtZij92Os/7neHOni/KuXyiwAiVps=; b=HeMFUpk59WW6pf9Jiee89PM7rRr1MDmjg5dU4g7lbrDWEWwMd0eZyUBNdmMt7cW/Do JKNhu0IZv/ak/1ZZdSQyYkWR64kDeYdCFGVc0HBWRIqIUlRus/kUO4ow0OShJTlT/YiW NBRyOg874gFUEcv3r6Mskhq9FijXUsBUhQCqBhumr3kJ/YuMJHje+jH5sVM75eSP2tgs p8f4OQSfP9wiEgMK79zjBt+pz4f9qkFqApBFBkrKLqnIjpMqPub5LpniGMStZ7X/b7d+ XCMK5SBvt5WLOcHrD5qw9qm4yFiKY19jqjkEYz2HX0ycpQEoEEhPNqcytHpY5297Ubdd G6SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710741794; x=1711346594; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AzAGNRRGjlXrFmJtZij92Os/7neHOni/KuXyiwAiVps=; b=PcA1bfcfIFI4WkF8ZpYBehXs9Kc6Wpb8Z6PSb5G/yLe1p67aMrlv8wIPpQf1/pu4nJ 0VymNUtoGKLD42Q2+qnQabO/T76DSuornuHTlLUgSCxQyGqTVFh5+1GmbX+Igh8ljazm Wb0T+EPAN6tcA2CC8MjUiBq86efRP4nrARpkjImaBlReuGDbeKZm6jBchx++Re3fmuTL zPxSxB0GRfLx/8ROwudQ9rKuMMOgDXWuzP88gSOemKYF0G8ThNz3cUlseNmB5PmRF+mA xiCeiX2x2rboehkVM7dWEiBiiL9lY09HUPyBDWNGmRUYwy990DsEFseFUrYUxvOQST3o O5zQ== X-Gm-Message-State: AOJu0YzEElbKkvE4BbyzlUVb6rC42BRDXnL9LEjOVCQpZvvDNxg8hVFP gi2Dzf6S5s3v7WHXX7LHjkJdqtEmX7P4YEfE7KRg9aZdgGqyCOPJj5KtcTQdGdOIbka0RlmhVnR XvIrYg1CUZANKuRKny7mrC6SA+maNig+S X-Google-Smtp-Source: AGHT+IGJOeSyX/FE4rbalvw65viPE+1IgWyqGXJQWv20hYJmu1geMo6pMyzUhFPfVEE0I/M6L8n5qlY+7EoIHfGkajI= X-Received: by 2002:a17:906:7ccf:b0:a46:2649:16f9 with SMTP id h15-20020a1709067ccf00b00a46264916f9mr6155878ejp.2.1710741793640; Sun, 17 Mar 2024 23:03:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Airlie Date: Mon, 18 Mar 2024 16:03:02 +1000 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > > > - /* Workaround for a spec issue. > > - *Can be removed once no longer needed, and threading can be enabled. */ > > + /* TODO: investigate if this can be removed to make decoding completely > > + * independent. */ > > FFVulkanDecodeContext *dec; > > Can you explain what the id_alloc_mask thing is doing which needs this? (The 32 size in particular seems suspicious.) This is for DPB slot management, 32 is the wrong limit, I think I just picked uint32_t and bitshifting as a quick option. We should limit this to maxDpbSlots I suspect, probably still use a uint32_t bitmask to track it. Dave. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".