From: Dave Airlie <airlied@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API
Date: Mon, 18 Mar 2024 16:03:02 +1000
Message-ID: <CAPM=9tzMFxtBJ36Xmbnvi-Ej788G4dWu9fs9sWyX7pCWi8h-7g@mail.gmail.com> (raw)
In-Reply-To: <a46e0bbc-2835-41d1-a476-de0f165412df@jkqxz.net>
>
> > - /* Workaround for a spec issue.
> > - *Can be removed once no longer needed, and threading can be enabled. */
> > + /* TODO: investigate if this can be removed to make decoding completely
> > + * independent. */
> > FFVulkanDecodeContext *dec;
>
> Can you explain what the id_alloc_mask thing is doing which needs this? (The 32 size in particular seems suspicious.)
This is for DPB slot management, 32 is the wrong limit, I think I just
picked uint32_t and bitshifting as a quick option. We should limit
this to maxDpbSlots I suspect, probably still use a uint32_t bitmask
to track it.
Dave.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-18 6:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-13 16:36 [FFmpeg-devel] [PATCH v3 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias and order_hints Lynne
[not found] ` <Nssf4Ma--7-9@lynne.ee-Nssf8W7----9>
2024-03-13 16:38 ` [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API Lynne
2024-03-17 15:36 ` Mark Thompson
2024-03-17 17:30 ` Lynne
2024-03-18 5:33 ` Lynne
2024-03-19 23:33 ` Mark Thompson
2024-03-25 7:57 ` Lynne
2024-03-18 6:03 ` Dave Airlie [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-02-10 22:38 [FFmpeg-devel] [PATCH v3 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias and order_hints Lynne
[not found] ` <NqK9xfm--3-9@lynne.ee-NqKA0jr--J-9>
2024-02-10 22:39 ` [FFmpeg-devel] [PATCH v3 2/2] lavc/vulkan_av1: port to the new stable API Lynne
2024-02-11 11:58 ` Mark Thompson
2024-02-11 15:13 ` Lynne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPM=9tzMFxtBJ36Xmbnvi-Ej788G4dWu9fs9sWyX7pCWi8h-7g@mail.gmail.com' \
--to=airlied@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git