From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1CD864B7FC for ; Tue, 13 Aug 2024 16:58:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8517A68DA77; Tue, 13 Aug 2024 19:58:45 +0300 (EEST) Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 30D2068DA36 for ; Tue, 13 Aug 2024 19:58:38 +0300 (EEST) Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3dab336717fso3672501b6e.0 for ; Tue, 13 Aug 2024 09:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723568316; x=1724173116; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=I3cFEl6jK06bCTjLM+TrGQugnK/dxGANV4epOwBZn/s=; b=EmyY+tE9ZF/bwiQi3d2K8XrhmbxkdecF4M10NUSGgTjKT1RFTkhnBSztuUYfjQkycu zPjMPib9xWxCO50ph+iMQ9z5nbE00QOsHDJvKHxAB4n+MGVEX9V09+bMxY+T+LvnbX6j V0cOaA0mX1a0Tn0i+JS2b+Cedrqe8js/FcE4+85ukhP/4LprKPCaqh8Xsw9GlsoNya28 xPIlqiB7giDA7g8p9KBfzy0MuCy5FYD3ICJJgJhqBzzz7IbT0BndDnNCiI8dcUeJwnEm AA+4mZzdbQIawwADdxRGee/U9GnuT4qetCiXvpfY9aw9FXFgQCdvvNURC4sfwmdxGY3H e9hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568316; x=1724173116; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I3cFEl6jK06bCTjLM+TrGQugnK/dxGANV4epOwBZn/s=; b=BPgo2KpVchsV0S0phh1PfgFSN64e8MNaR5o4Bsv+YufmIPw27xj8LvZJccGh0kJAWM 4Wk+FfOMWywpAdr2NyUL3hWQHrjDh/OX9bjGRn4nYH+urJTu7C+//v8HUrqCZoZjkwU4 ShDLiJ5rOdP0EcNyEa5CrhYmLhxnAtwIzUEGyPImH6rvuJogttUoGGacfx1k9l059oGJ W1xne67b0JmuhriiF4Xr1Tx0U6mQq+gBx2NfoOJNOrjoMgpIhuZBGMrxWnr/+ZgIH6iV Qn5HtCXvfCltRIjInn+NZQxyQDUd1Bv2myq/aWtYa6w1GAGEeC2j8aAWMWy7ftuebur4 UvuA== X-Gm-Message-State: AOJu0Yx7xdhfsrpZwmLSpBE6dtwRe3+9V6vPfBRT9WiPCjV0f6CL/Udz 8fkvEynzsG2Whya+BOyEboufBe8elv6R6Vf8qG3QzTddpk+yvqiJ3wNkhWLJYsnw22UIUA68lgM R45noOKvr7Rj1/3akwrO4QVxrhFnLkA== X-Google-Smtp-Source: AGHT+IEI9VC2Cs7t1zV+cS+BWokxCQ5CBaIAUPGQmUvTsEKzZlmY+FwMTCLlkNrq3MV0SO0DpWkBl9IzRzxzabWH+Kk= X-Received: by 2002:a05:6808:1922:b0:3db:251b:f459 with SMTP id 5614622812f47-3dd298fa036mr54070b6e.12.1723568316351; Tue, 13 Aug 2024 09:58:36 -0700 (PDT) MIME-Version: 1.0 References: <172249913303.21344.17598597604771690214@lain.khirnov.net> <20240801213625.90394-1-joshua.allmann@gmail.com> In-Reply-To: From: Josh Allmann Date: Tue, 13 Aug 2024 09:57:59 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 7 Aug 2024 at 09:13, Josh Allmann wrote: > > On Thu, 1 Aug 2024 at 14:37, Josh Allmann wrote: > > > > Encoders may emit a buffering period SEI without a corresponding > > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. > > > > During Annex B conversion, this may result in the SPS/PPS being > > inserted *after* the buffering period SEI but before the IDR NAL. > > > > Since the buffering period SEI references the SPS, the SPS/PPS > > needs to come first. > > --- > > libavcodec/bsf/h264_mp4toannexb.c | 15 +++++++++++++++ > > tests/ref/fate/h264-bsf-mp4toannexb | 2 +- > > tests/ref/fate/h264_mp4toannexb_ticket2991 | 18 +++++++++--------- > > tests/ref/fate/segment-mp4-to-ts | 12 ++++++------ > > 4 files changed, 31 insertions(+), 16 deletions(-) > > > > Ping for (re-)review on this patch which addresses comments from [1] > > Explanation for the FATE changes here [2] - it turns out that several > of the FATE samples exhibit the same behavior that this patch fixes, > so it is a net improvement > > [1] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-August/331958.html > [2] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-July/330912.html > Gentle ping for re-review. Josh _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".