Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI

[Josh Allmann <joshua.allmann@gmail.com>]

On Wed, 7 Aug 2024 at 09:13, Josh Allmann <joshua.allmann@gmail.com> wrote:
>
> On Thu, 1 Aug 2024 at 14:37, Josh Allmann <joshua.allmann@gmail.com> wrote:
> >
> > Encoders may emit a buffering period SEI without a corresponding
> > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc.
> >
> > During Annex B conversion, this may result in the SPS/PPS being
> > inserted *after* the buffering period SEI but before the IDR NAL.
> >
> > Since the buffering period SEI references the SPS, the SPS/PPS
> > needs to come first.
> > ---
> >  libavcodec/bsf/h264_mp4toannexb.c          | 15 +++++++++++++++
> >  tests/ref/fate/h264-bsf-mp4toannexb        |  2 +-
> >  tests/ref/fate/h264_mp4toannexb_ticket2991 | 18 +++++++++---------
> >  tests/ref/fate/segment-mp4-to-ts           | 12 ++++++------
> >  4 files changed, 31 insertions(+), 16 deletions(-)
> >
>
> Ping for (re-)review on this patch which addresses comments from [1]
>
> Explanation for the FATE changes here [2] - it turns out that several
> of the FATE samples exhibit the same behavior that this patch fixes,
> so it is a net improvement
>
> [1] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-August/331958.html
> [2] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-July/330912.html
>

Gentle ping for re-review.

Josh
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".