From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 004524875C for ; Mon, 15 Jul 2024 17:55:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D9F6C68D922; Mon, 15 Jul 2024 20:55:03 +0300 (EEST) Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 44ED168D7FF for ; Mon, 15 Jul 2024 20:54:57 +0300 (EEST) Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3d96365dc34so3842636b6e.2 for ; Mon, 15 Jul 2024 10:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721066095; x=1721670895; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=Gh44Bko92juB0SKWn0V6f+sE5tEJ+K5Oiuw0KQYhsWc=; b=jYCMEC1VBMBafE/XiUueLSOMt4/51o5NCzXxVnl64NI609qyF3PWkqNvWdBlznUwqo ogIljpsCRuPlMkrI0r+z6n7XwgXnpLReCSciLsBZLtBTqYLeAPWbGbALWsqhUyg85QSs D1ZexkGUPiWb16ZapQs74OljJ/Xv88rVg/VrTrCuDtQkNpNhR7BJX6H9/oYg9OQRAjce 7wgmzBaGPbap8/bQgM7zvUNLDaTpaKk+/LZEVjS1d3uLhAsdvo0GkopU2KFsC3vvcR8n YeSAocgXcq70enNgoBLZgKks46ZijOqLlg63hy13OyBHtv56Z2+SIJUPO6VzpMUv2uHP Q86A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721066095; x=1721670895; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gh44Bko92juB0SKWn0V6f+sE5tEJ+K5Oiuw0KQYhsWc=; b=F84qcmtC6p4qSyxSveCWthgLX3I0o8+nKW962k+VSun7pKBgx4byMwqwb2le21Y6R3 rmB9ehmm4I80GxJnSgiVxzYOTnmwjFqwGzmoN6Age3Z1Yq+/uIbHsbGqXnxsBwgU416v J6HD9ND40NsyVRtLwwr1m6ol2c3WGCZjN0A5Y9qqFPBkqE3cfbtVC0LDoKNJSSUuyoWH FQfWu+R/nBKlWd85WokzeC0iNqg/t6txgnR8JL1gfpNcu1Q/j3bqXJn/w1DFrFYEarzG rI30bNsqQy7g6Gc+gfZ2z/mDrflFh0dooy5xG9waKOE9ZlGMaAagR0IfbZmgrV9lL05u dzyg== X-Gm-Message-State: AOJu0YzjFnuFjYb5b252ZVwbS4ZF6ywEPy+1BXaFbWNLCr9DhxOHKSxB xC4K1Op5ADStK9LYZstDYdpH91RQsOaKObQjaqvHgZEKK474bvEv6nzVqnl+q6rLwzGJC2Swb+W H/1wa5EN3dWR1+ykwF7tKhYEpI2fXJL81 X-Google-Smtp-Source: AGHT+IGjb9xeXeBvVuRfTLwUM7YnBtrtN1Qxl8swAzUPx35TqiYDqgHIO0LkSsEFH5LbShlZ8tyO0NaWnLRRIiuNFt4= X-Received: by 2002:a05:6871:296:b0:25e:f4e:da53 with SMTP id 586e51a60fabf-25eaebc7f8fmr16979890fac.37.1721066095371; Mon, 15 Jul 2024 10:54:55 -0700 (PDT) MIME-Version: 1.0 References: <20240709190547.99246-1-joshua.allmann@gmail.com> In-Reply-To: From: Josh Allmann Date: Mon, 15 Jul 2024 10:54:19 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 15 Jul 2024 at 10:48, Josh Allmann wrote: > > On Tue, 9 Jul 2024 at 12:06, Josh Allmann wrote: > > > > Encoders may emit a buffering period SEI without a corresponding > > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. > > > > During Annex B conversion, this may result in the SPS/PPS being > > inserted *after* the buffering period SEI but before the IDR NAL. > > > > Since the buffering period SEI references the SPS, the SPS/PPS > > needs to come first. > > --- > > > > Notes: > > v2: Updated FATE test refs > > > > libavcodec/bsf/h264_mp4toannexb.c | 13 +++++++++++++ > > tests/ref/fate/h264-bsf-mp4toannexb | 2 +- > > tests/ref/fate/h264_mp4toannexb_ticket2991 | 18 +++++++++--------- > > tests/ref/fate/segment-mp4-to-ts | 12 ++++++------ > > 4 files changed, 29 insertions(+), 16 deletions(-) > > > > Ping for review. Looking at the FATE output, this patch fixes a number > of things - see [1] for details > > [1] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-July/330964.html Pasted the wrong link - please see this for a review of the FATE test changes https://ffmpeg.org//pipermail/ffmpeg-devel/2024-July/330912.html _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".