From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0A3E148C9D for ; Mon, 22 Jul 2024 23:01:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 09CF168A304; Tue, 23 Jul 2024 02:01:48 +0300 (EEST) Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4E70C68D34E for ; Tue, 23 Jul 2024 02:01:41 +0300 (EEST) Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-260e6298635so2500621fac.1 for ; Mon, 22 Jul 2024 16:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721689299; x=1722294099; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=FQVn+ooMnFixnjgzmM2ca1sIvhqLNj1Ic8QI+qzuU4o=; b=jesUibsl6KRmY/JkC4+2QfQAF/q9I09GyGpUXL8ZfL9DAYOa/j1D1zUmmXTaEpr38w qbB6Tzpu0s1NOGHRR1WhuYsIe0P77AvA++/JGjuCLQGlTHF6k93dkRbAxautf7dVgZCu 0iigfvn/sQd2mA14oP7J0GqG1j3YCqx3T29yPpClrZsi5QnVOKCU4M0Gzt69f5A0Mi9U Gl8xYh8abhxlOKmFfvaX5KOx1Mx5sokpAa+8/2U+4jN5WmFDrWe4jpM00m7Vek95EX1m qpXt8RaWwCuXpuqmUc5vHrM+n3d3YcFAbGZkDtzDsfDLFONivr+GQJVjwV6DHlEpIEH8 XcyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721689299; x=1722294099; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FQVn+ooMnFixnjgzmM2ca1sIvhqLNj1Ic8QI+qzuU4o=; b=Gif5b2fa9SOBvGpGodxpUA5P8X9Lki1p+V7EtRMTMBtYCQSW/ejYcd/PFTvZbewmTT iWDyszoeqY0QyNMCdHZfo/1oFTwhJs1t0HYq4zQcUPkte/pczKgZZqQS+PP3QPIudndg 7D4QMsQ1SYbud/DctNiMV8ESUJLxXPKMErl4FbWKf5ON2N0FWGsjmg+T4e/GbjKMh1ZI X2HRlNjA8IErl+vljCQeIKvBQukUuvb4RYHsECQ7G6yE+wu7kGZ4CjHTEpATg9kqX8dU UMK4LbLCxKynoWkZBcKSlw54nu3af+3iKRRqhVXNFcedrAGy/EufCZlrXk8AWGdgCoYd f1vg== X-Gm-Message-State: AOJu0YwWPO87Pyfo/RoxwEOLHYOhYkezE7HTt/bsOdVp5aIy0lcgDgnZ fX6exSdIy889b50oItQ3rd4XCU+eq7ug9PUo25qmKmD14u+rXbUjylx1EjrikP4SWuRN0reet2W mlUKl1BjZJuP2CBMow+s5Fvqb8LslhI+T X-Google-Smtp-Source: AGHT+IEDoz4p32URShFmPRCioKe3rsg6dSIaysLOmRC4rfpJXzjmpuFm4sBYNpZVlHhozFpDiMMFDlJpSsMlwWg4dJ8= X-Received: by 2002:a05:6870:ec88:b0:260:2813:2840 with SMTP id 586e51a60fabf-2646ea56bd6mr152554fac.9.1721689299272; Mon, 22 Jul 2024 16:01:39 -0700 (PDT) MIME-Version: 1.0 References: <20240709190547.99246-1-joshua.allmann@gmail.com> In-Reply-To: <20240709190547.99246-1-joshua.allmann@gmail.com> From: Josh Allmann Date: Mon, 22 Jul 2024 16:01:03 -0700 Message-ID: To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 9 Jul 2024 at 12:06, Josh Allmann wrote: > > Encoders may emit a buffering period SEI without a corresponding > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. > > During Annex B conversion, this may result in the SPS/PPS being > inserted *after* the buffering period SEI but before the IDR NAL. > > Since the buffering period SEI references the SPS, the SPS/PPS > needs to come first. > --- > > Notes: > v2: Updated FATE test refs > > libavcodec/bsf/h264_mp4toannexb.c | 13 +++++++++++++ > tests/ref/fate/h264-bsf-mp4toannexb | 2 +- > tests/ref/fate/h264_mp4toannexb_ticket2991 | 18 +++++++++--------- > tests/ref/fate/segment-mp4-to-ts | 12 ++++++------ > 4 files changed, 29 insertions(+), 16 deletions(-) > Ping again for review. Looking at the FATE output, this patch fixes a number of things - see [1] for details [1] https://ffmpeg.org//pipermail/ffmpeg-devel/2024-July/330912.html _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".