Re: [FFmpeg-devel] [PATCH 2/5] fate/ffmpeg: Explicitly set pix fmt for sub2video tests

[Sean McGovern <gseanmcg@gmail.com>]

Hi,


On Thu, Mar 28, 2024, 23:24 Andreas Rheinhardt <
andreas.rheinhardt@outlook.com> wrote:

> Otherwise the test would use bgra on little endian and argb
> on big endian.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>  tests/fate/ffmpeg.mak | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> index 3c549b265e..fda3a29239 100644
> --- a/tests/fate/ffmpeg.mak
> +++ b/tests/fate/ffmpeg.mak
> @@ -64,7 +64,7 @@ fate-sub2video_basic: CMD = framecrc
> -auto_conversion_filters \
>    -i $(TARGET_SAMPLES)/sub/vobsub.idx \
>    -fps_mode passthrough -copyts \
>    -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
> -  -c:v rawvideo -threads 1
> +  -c:v rawvideo -pix_fmt bgra -threads 1
>
>  # Time-limited run with a sample that doesn't require seeking and
>  # contains samples within the initial period.
> @@ -74,7 +74,7 @@ fate-sub2video_time_limited: CMD = framecrc
> -auto_conversion_filters \
>    -fps_mode passthrough -copyts \
>    -t 15 \
>    -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
> -  -c:v rawvideo -threads 1
> +  -c:v rawvideo -threads 1 -pix_fmt bgra
>
>  FATE_FFMPEG-$(call ENCDEC, PCM_S16LE, PCM_S16LE) +=
> fate-unknown_layout-pcm
>  fate-unknown_layout-pcm: $(AREF)
> --
> 2.40.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>

I already submitted this change a few weeks ago (March 6th to be precise)
and it has been left unreviewed.

-- Sean McGovern

>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".