From: Sean McGovern <gseanmcg@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/4] avfilter/buffersink: cuddle () closer around =
Date: Thu, 2 Nov 2023 20:04:58 -0400
Message-ID: <CAPBf_OnfET3yWKYSHOH2bomUx1u=3YbqtD09cO22QWeU3fBtqg@mail.gmail.com> (raw)
In-Reply-To: <20231102235016.3935-2-michael@niedermayer.cc>
On Thu, Nov 2, 2023, 19:50 Michael Niedermayer <michael@niedermayer.cc>
wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> libavfilter/buffersink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/buffersink.c b/libavfilter/buffersink.c
> index 9426ded7ee3..ca2af1bc077 100644
> --- a/libavfilter/buffersink.c
> +++ b/libavfilter/buffersink.c
> @@ -293,7 +293,7 @@ static int asink_query_formats(AVFilterContext *ctx)
> cleanup_redundant_layouts(ctx);
> for (i = 0; i < NB_ITEMS(buf->channel_layouts); i++)
> if ((ret = av_channel_layout_from_mask(&layout,
> buf->channel_layouts[i])) < 0 ||
> - (ret = ff_add_channel_layout(&layouts, &layout) < 0))
> + (ret = ff_add_channel_layout(&layouts, &layout)) < 0)
> return ret;
> for (i = 0; i < NB_ITEMS(buf->channel_counts); i++) {
> layout = FF_COUNT2LAYOUT(buf->channel_counts[i]);
> --
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
This and 1/2 seem a bit frivolous, but providing they don't violate the
project style guide, LGTM.
-- Sean McGovern
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-11-03 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 23:50 [FFmpeg-devel] [PATCH 1/4] avfilter/framesync: " Michael Niedermayer
2023-11-02 23:50 ` [FFmpeg-devel] [PATCH 2/4] avfilter/buffersink: " Michael Niedermayer
2023-11-03 0:04 ` Sean McGovern [this message]
2023-11-03 20:53 ` Nicolas George
2023-11-02 23:50 ` [FFmpeg-devel] [PATCH 3/4] avcodec/flicvideo: consider width in copy loops Michael Niedermayer
2023-11-03 0:08 ` Sean McGovern
2023-11-03 20:49 ` Michael Niedermayer
2023-11-02 23:50 ` [FFmpeg-devel] [PATCH 4/4] avformat/lafdec: Check for 0 parameters Michael Niedermayer
2023-11-03 0:09 ` Sean McGovern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPBf_OnfET3yWKYSHOH2bomUx1u=3YbqtD09cO22QWeU3fBtqg@mail.gmail.com' \
--to=gseanmcg@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git