From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 314C24CCB3 for <ffmpegdev@gitmailbox.com>; Sun, 13 Apr 2025 15:34:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CACC7687CA9; Sun, 13 Apr 2025 18:34:53 +0300 (EEST) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0F792687BEA for <ffmpeg-devel@ffmpeg.org>; Sun, 13 Apr 2025 18:34:48 +0300 (EEST) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ac34257295dso683998566b.2 for <ffmpeg-devel@ffmpeg.org>; Sun, 13 Apr 2025 08:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744558487; x=1745163287; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=LYpGlWz/Udw0V2Lrvzq2nuPm7wVKW63Kpl4+h5DmDvw=; b=Z3BsXRqnLlwNS6X7GApPVq++c4Ljeev9YLC29AEsm+iezCn2aeNDQCobHH4G2zbAWt vz7zfZASu2iWI/rYidwY8Y+gyCJfXO2RtoU14U5SbdpD78J4bQhUhpaYqgLKHirDwqbU RGNYwuoDZp4sH13iHsfFtnPpgbyjo0HBQkMDZakWEWWF77pzo6y23f98kU25VzvdfNl2 cZd2qBy+iLhX0zzxms2CkluKE5MsUNQjNzT15k2hRBIOQ0aLnWgaK4CiqL/95XJfr6cG 31lmUqlZ7K5c5g2sHeWYipEhtNXaVHOCtQzaahrVQZ1IsBxzj0dKbUUb3/g/mkCxFHoy oGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744558487; x=1745163287; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LYpGlWz/Udw0V2Lrvzq2nuPm7wVKW63Kpl4+h5DmDvw=; b=SdWDiGPGCz80AeuDtdkr2zg65XFaHwsWH30UXebji8g3qBBjZVDJAOQ4kzYh799vb9 QzIAx6AoghDPZ1PhlXQbzdIvk+tqldeTDwliMsSetKzKLqEgWPan9qVJOQ3hybTEhKCa SM8bVdsYIlNsvBCeVmpGEGZeJZjkKJw7E9x+UvEWLE26edbuEFTXBOuyMnz8OdsWgUkf SMP3Y6s8s4vcldFWmOVbrsvFnNdwwqgS/GwISPPaSOS4GPC2LwbCtYdrFYD5HEVdIew9 Q9qmah09gcNkQP1tfPwIH3xN288PD6gYhCP+EJEMV58B2aV1Hafbhu7dt0bWmf78bc31 eEEA== X-Gm-Message-State: AOJu0YxmNqcC+k5JWwSHQ3DCia2CwBaR4c1X8S1T2Hmob2j23hIaV1iR FUiZeKf1PwL8cdsf7/KMUiqBybnWhu5x6awgpKwxPD/SGO22JlGccTn0EC7EenHPuBPbkLeM4cy A54CghMMcAWXl4jZgmHlegJSoc24srg== X-Gm-Gg: ASbGncuZ+8nc2vuj7hvCUHDoHTyjMJTS7EDU6kBnkxzT9yanr/ILgFa4sKlvMZj+quW lAsa//ktJecCv8p2ncKsABIAKFsvl+6kkzszP0XpJHzak8vUgNrk8pkk9R3gHrx6d1nNFJemJGv S+/H8Rw5fuqHoGViQ2JmMzOg== X-Google-Smtp-Source: AGHT+IFwp9Ma1sY3MnhovA2RWBAilKss603sa8ZTphAhJJ5SmLMC2rqxuyrDoS9nhcXzBhQZh30PGqvM0vxCx4kY+gw= X-Received: by 2002:a17:907:720d:b0:ac7:d10c:1f39 with SMTP id a640c23a62f3a-acad3496121mr878984766b.20.1744558486959; Sun, 13 Apr 2025 08:34:46 -0700 (PDT) MIME-Version: 1.0 References: <20250411131205.718305-1-gseanmcg@gmail.com> <20250411135222.720908-1-gseanmcg@gmail.com> In-Reply-To: <20250411135222.720908-1-gseanmcg@gmail.com> From: Sean McGovern <gseanmcg@gmail.com> Date: Sun, 13 Apr 2025 11:34:37 -0400 X-Gm-Features: ATxdqUFTW8VqWVVTpSKtfM9m-mdF5L9p3s5ZY1fOrbb_yF4v3ibMTrkThpNV_KM Message-ID: <CAPBf_OmuuvTztOSa00q3yM5CeSFh1G5jL+MYPAUsOHn_+QcfXQ@mail.gmail.com> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH v2] libpostproc: deprecate the AMD 3DNow! define X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/CAPBf_OmuuvTztOSa00q3yM5CeSFh1G5jL+MYPAUsOHn_+QcfXQ@mail.gmail.com/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> Hi, On Fri, Apr 11, 2025, 09:52 Sean McGovern <gseanmcg@gmail.com> wrote: > It was left unreferenced in 1f0948272a0fcd0e4947f629b600983f3338c02f. > --- > libpostproc/postprocess.h | 2 ++ > libpostproc/version.h | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/libpostproc/postprocess.h b/libpostproc/postprocess.h > index 5decb7e8a9..7010c2b51b 100644 > --- a/libpostproc/postprocess.h > +++ b/libpostproc/postprocess.h > @@ -87,7 +87,9 @@ void pp_free_context(pp_context *ppContext); > > #define PP_CPU_CAPS_MMX 0x80000000 > #define PP_CPU_CAPS_MMX2 0x20000000 > +#if PP_AMD_3DNOW > #define PP_CPU_CAPS_3DNOW 0x40000000 > +#endif > #define PP_CPU_CAPS_ALTIVEC 0x10000000 > #define PP_CPU_CAPS_AUTO 0x00080000 > > diff --git a/libpostproc/version.h b/libpostproc/version.h > index bcbdd210c4..5a272630bf 100644 > --- a/libpostproc/version.h > +++ b/libpostproc/version.h > @@ -43,4 +43,6 @@ > > #define LIBPOSTPROC_IDENT "postproc" > AV_STRINGIFY(LIBPOSTPROC_VERSION) > > +#define PP_AMD_3DNOW (LIBPOSTPROC_VERSION_MAJOR < 60) > + > #endif /* POSTPROC_VERSION_H */ > -- > 2.39.5 > Did I do this correctly this time? Also it seems a bit much to wait a year or more for this to be actually removed. Can it instead be keyed to the next minor bump, or is this against some guarantee we give our downstreams? -- Sean McGovern > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".