From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 32B1F4728C for ; Fri, 3 Nov 2023 00:10:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8288568CCE7; Fri, 3 Nov 2023 02:10:13 +0200 (EET) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8C27D68CCDD for ; Fri, 3 Nov 2023 02:10:06 +0200 (EET) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-53de8fc1ad8so2567875a12.0 for ; Thu, 02 Nov 2023 17:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698970206; x=1699575006; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=d7YQSXrRjoxrLHhn256MKQXSnY16aYFzibBnXqZJhiI=; b=WxjRFkOFA8aXOi7LBoY75uhsaGfG7DWHKvets9FLbEJWkekmniMDnkkBkSQQmX4BmR hHpJiZLVUatN/ako8AxPl+OPlz7lACZPo5/s2L2+21a6bAZ+9DZtyy5z4pAfPz7BBr/J ISrQ5gGTRLd0/zuWzq3nZBjMlCHj1Jv/NXEgz8Ok4ZiwWMbtsNYfXSpt8j98cPYuXsIt LkwoFwvpiO3dCBPc3Q3mxWaMswLmP0nABck102pbgCMt1FfJudWWxijZQFGZkhKj6n9+ kqdRvMMYxYj9KRyYhN/21ps+QZWyYwVlNVNojkRoxmYX4vq+yTyO9yVkMRhgkMYnmj5B t9SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698970206; x=1699575006; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d7YQSXrRjoxrLHhn256MKQXSnY16aYFzibBnXqZJhiI=; b=t+rx3ieq/9tHhhJlpzgfnZE1iqp23xryAx6wLC4LufTwAIwfuAm2DPzlIEa+dXSzsP bOaF9L8WRVjztfdU5Gkk0wbPCJTmCEGPsC3yRvesHxl53JpDh3YStXKHL3SvoY20MAm1 B7PnGoTrKkTHkVYVqw6AkO/G6t3KVaUXCQEsYk8Y+HpoaRsBBmLxa6yoNRWdRiJFPMh5 OSZqNunK7CGgZHdY7lANavtggBTphcS4AVK2Vq3BjNpq8Vb3fWhRUE8f3+aKFoiZprtI SrqNHnKkL3JQoOlrkZGKkKc5fd2ZGlpGvc5ta/uDOXPmNbJvDaJ2qyocEON0B1dniMHg mxrg== X-Gm-Message-State: AOJu0YxtwHFmm/F3FF7A7sfwf30wU1JquKqj1bX4GxkAPWdk39kVFlNr Khu16LMM1FWo8LpPXtXpLoSgl70SbUKrmWcKe7RnS1BV X-Google-Smtp-Source: AGHT+IEhW0xFyEzLZjfoCLX1K3wrq2+zgposG/y0sjnJDc69MAcIsT74pTvGqgYz/gDtxHdARRMUY2Aa6hZq1vvjuRk= X-Received: by 2002:a05:6402:350:b0:53e:1825:be81 with SMTP id r16-20020a056402035000b0053e1825be81mr15050381edw.21.1698970205694; Thu, 02 Nov 2023 17:10:05 -0700 (PDT) MIME-Version: 1.0 References: <20231102235016.3935-1-michael@niedermayer.cc> <20231102235016.3935-4-michael@niedermayer.cc> In-Reply-To: <20231102235016.3935-4-michael@niedermayer.cc> From: Sean McGovern Date: Thu, 2 Nov 2023 20:09:56 -0400 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH 4/4] avformat/lafdec: Check for 0 parameters X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, Nov 2, 2023, 19:50 Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 63661/clusterfuzz-testcase-minimized-ffmpeg_dem_LAF_fuzzer-6615365234589696 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by > : > Michael Niedermayer > --- > libavformat/lafdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/lafdec.c b/libavformat/lafdec.c > index 59a59dcfe9c..b867f106aee 100644 > --- a/libavformat/lafdec.c > +++ b/libavformat/lafdec.c > @@ -139,7 +139,9 @@ static int laf_read_header(AVFormatContext *ctx) > s->index = 0; > s->stored_index = 0; > s->bpp = bpp; > - if ((int64_t)bpp * st_count * (int64_t)sample_rate >= INT32_MAX) > + if ((int64_t)bpp * st_count * (int64_t)sample_rate >= INT32_MAX || > + (int64_t)bpp * st_count * (int64_t)sample_rate == 0 > + ) > return AVERROR_INVALIDDATA; > s->data = av_calloc(st_count * sample_rate, bpp); > if (!s->data) > -- > 2.17.1 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > This looks OK to me. -- Sean McGovern > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".