From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8CEB049D63 for ; Tue, 9 Apr 2024 16:35:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 294B568D027; Tue, 9 Apr 2024 19:35:13 +0300 (EEST) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B358368BECE for ; Tue, 9 Apr 2024 19:35:06 +0300 (EEST) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-516dc51bb72so4052848e87.1 for ; Tue, 09 Apr 2024 09:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712680505; x=1713285305; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=HqIjmav4b199C2CR7slng+r6wZcS9Z3tdTJS87ffppI=; b=cT58G+L3Gc78Novzfm9l8v08Fn56+dSrtCNoX7C5YeGOPmxn3cDaiKQ0AtqY4DegbA IUIbP7VEPI+M0XZ+wTpsFqUtS+/mdz0zTxtrebWPqXsM7tAT0a6IUFs6r2f/AMy2UNZ/ wfWqyayZUtIyPpWfkJmidUwmIdXDBvOU604H9O1C1Z3vjdOCpwi9r/EeGFl1RSWNI5pc QCLWheEmR48aKpDARJbSf1o3Ad7ITct6LTO1jVB2uTq3sfIR31jU8gMCFovB5Az5tA2D eEf0vk+WcH+n/KyCNlOPQtOInb3lwhqNiCAuQj2IM3AuEtoHEpkNsl12vRxHbsl1ZVeX h9RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712680505; x=1713285305; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HqIjmav4b199C2CR7slng+r6wZcS9Z3tdTJS87ffppI=; b=R/BhurXQtQ8jGav2ysepaTgAd50z9ciumQ3aWKpRI446hL2QmHoGodAaU9N7o6Xcvm TelkJTypBgz1UAU8My9L6MwbBw6NdatFEL3oyeXAQ0t2+O8H9KFUYnOywOC+agpvQMcV OE2aAuZibBFULsLw7zg2OYYovxaynjI+4pZut1Qi8xxIioIS18K7MzA7wkxTvwtvCF2D WfHtCSDeyWZBdpZan9h6nuKk3ElhUBTjfvxc/1jAb3h/8qikeFr8RsFd6IhMrirGOsB7 59uAzqtJqK3mS2+lxPwx9Coivibt4hEcnfSPUIbjVi4wGGDkMRmPPQH5Oi4Z0u2Baufy IGYw== X-Gm-Message-State: AOJu0Ywu86dLTnAKVM9mvpzb1o1HntbRz7neFPaRacft/A9mMc5cC5tJ UHmeFtnQ+L/1J6TmGNW8EwF13uviW5pUB/rIFGDFxMj+fvPgmQh6R7oVq0/2XW1a0FL7kxC4TGZ 00J7SU6s63/+Slrl4HVvI6XSEum18kSMx X-Google-Smtp-Source: AGHT+IEEGe4DTF4w2aC3lDk+UCPfEfKrB0p5VRH7CaKk87o8Ljwr5G79qHS7uEgCSovp2TdjqBqQDRGVzl6/mNh53WI= X-Received: by 2002:a19:f009:0:b0:516:d63b:a1b5 with SMTP id p9-20020a19f009000000b00516d63ba1b5mr8135682lfc.8.1712680505265; Tue, 09 Apr 2024 09:35:05 -0700 (PDT) MIME-Version: 1.0 References: <20240409130509.1461-1-jamrial@gmail.com> In-Reply-To: <20240409130509.1461-1-jamrial@gmail.com> From: Sean McGovern Date: Tue, 9 Apr 2024 12:34:55 -0400 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvt1: check return value of sned/receive functions X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi James, On Tue, Apr 9, 2024, 09:05 James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/libsvtav1.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 105c3369c0..6ff893cf10 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -486,6 +486,7 @@ static int eb_send_frame(AVCodecContext *avctx, const > AVFrame *frame) > { > SvtContext *svt_enc = avctx->priv_data; > EbBufferHeaderType *headerPtr = svt_enc->in_buf; > + EbErrorType svt_ret; > int ret; > > if (!frame) { > @@ -524,7 +525,9 @@ static int eb_send_frame(AVCodecContext *avctx, const > AVFrame *frame) > if (avctx->gop_size == 1) > headerPtr->pic_type = EB_AV1_KEY_PICTURE; > > - svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr); > + svt_ret = svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr); > + if (svt_ret != EB_ErrorNone) > + return svt_print_error(avctx, svt_ret, "Error sending a frame to > encoder"); > > return 0; > } > @@ -579,6 +582,8 @@ static int eb_receive_packet(AVCodecContext *avctx, > AVPacket *pkt) > svt_ret = svt_av1_enc_get_packet(svt_enc->svt_handle, &headerPtr, > svt_enc->eos_flag); > if (svt_ret == EB_NoErrorEmptyQueue) > return AVERROR(EAGAIN); > + else if (svt_ret != EB_ErrorNone) > + return svt_print_error(avctx, svt_ret, "Error getting an output > packet from encoder"); > > #if SVT_AV1_CHECK_VERSION(2, 0, 0) > if (headerPtr->flags & EB_BUFFERFLAG_EOS) { > -- > 2.44.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > Commit title is mis-spelled: sned -> send. Other than that, looks OK. -- Sean McGovern > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".