From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0620A483CB for ; Tue, 2 Jan 2024 00:22:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CF04A68C9DE; Tue, 2 Jan 2024 02:22:01 +0200 (EET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D920568C8C4 for ; Tue, 2 Jan 2024 02:21:54 +0200 (EET) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50e67e37661so9485857e87.0 for ; Mon, 01 Jan 2024 16:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704154914; x=1704759714; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=p2OqEQCTl0iSWAdl6B6hZtozHnrArWW4eRDmXK6Y89Q=; b=XI92DTQkShPkwWQqWSs+VV+ZRBKWcc/Ck1B92SVoXCrn4mxO/FJqnBMbYDS9LE8wYE zoeqJkq31SfeDQTvutHDpiVAIMb3vlvL9h64Fgw8dgImkISzqsKXYFqqoGsDE/dvpGol d3edIdelv+0YrjoheJnCYxSfzsrzKbudasn7spTGQVzhHkur9+/cl6PF4BnU/onWBk+f mTC7So3J6Jxl39OPizREehIb2dyrdi/zWs/mnRSzXySbnKmSD82/KIOvCcFU9RNXkzNm rQWCOYd5yxnLfadYJWgFD4VAhv+cZP8gGlyRPvDvm3FaAaiyl1cj25u+QMky5emEOOXT N0fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704154914; x=1704759714; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p2OqEQCTl0iSWAdl6B6hZtozHnrArWW4eRDmXK6Y89Q=; b=mi5CvZmKzeJQLA4v+BqnDwbSMGb32+qi99tx42nHRWtSjKs1tAcjpZ8srcDOlYyOEd pYW05NUBXfehmDv8vHNHO53dIdspLRZyl6hSQQI/qZ/e9QtBwNhez3wtFeJx5iOujmOS ihZDjvY9DYMUtxfwHWlxOiL7sd1MSzE2itxKQqJzVb+VkQvQQLR+34tNKFfM9SVCh5A9 14m6PVEDzgtXFq8f3BZ5DzoSU0mocaEQAxMfoDLbCd8qgTjnA/nRprDnkpjUwyw81qo1 eUuwXfTeRB0JHOP5Jf+Nn6o0CID58CMVrMgVT15jmbnIhV6LU9q04UUCkp3rOaADNll0 +zNw== X-Gm-Message-State: AOJu0YyGPK3FqZT0UcCoJIErV9PfqxMB3SBBIRObCs0bbP+lzqzKIT04 KqWQfmUqdEKOFMGaewyHq7dqNyHNw8YPOk0Zv104x2ZYPDM= X-Google-Smtp-Source: AGHT+IFQXj5sBFEM8Wy4UWZkyi+Knr8xuoqOG8u49G8lxDzJAaMnDA9g1xm1Yy6GwFuY+Rkzgqp5/puElyREFNj9pJg= X-Received: by 2002:ac2:4f84:0:b0:50e:3ed6:1c28 with SMTP id z4-20020ac24f84000000b0050e3ed61c28mr6645655lfs.130.1704154913673; Mon, 01 Jan 2024 16:21:53 -0800 (PST) MIME-Version: 1.0 References: <20231015032724.3590-1-gseanmcg@gmail.com> <20231019114343.GG3543730@pb2> In-Reply-To: <20231019114343.GG3543730@pb2> From: Sean McGovern Date: Mon, 1 Jan 2024 19:21:43 -0500 Message-ID: To: FFmpeg development discussions and patches X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavutil/ppc/cpu.c: check that AT_HWCAP2 is defined X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, On Thu, Oct 19, 2023, 07:44 Michael Niedermayer wrote: > On Wed, Oct 18, 2023 at 01:18:54PM -0400, Sean McGovern wrote: > > On Sat, Oct 14, 2023, 23:27 Sean McGovern wrote: > > > > > It was not introduced until glibc 2.18. > > > --- > > > This should fix the ppc32 FATE node. > > > --- > > > libavutil/ppc/cpu.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c > > > index 96b491c716..bc8bb5f47c 100644 > > > --- a/libavutil/ppc/cpu.c > > > +++ b/libavutil/ppc/cpu.c > > > @@ -95,12 +95,15 @@ int ff_get_cpu_flags_ppc(void) > > > #endif > > > if (ret & AV_CPU_FLAG_VSX) > > > av_assert0(ret & AV_CPU_FLAG_ALTIVEC); > > > - } else if (buf[i] == AT_HWCAP2) { > > > + } > > > +#ifdef AT_HWCAP2 /* not introduced until glibc 2.18 */ > > > + else if (buf[i] == AT_HWCAP2) { > > > #ifdef PPC_FEATURE2_ARCH_2_07 > > > if (buf[i + 1] & PPC_FEATURE2_ARCH_2_07) > > > ret |= AV_CPU_FLAG_POWER8; > > > #endif > > > } > > > +#endif /* AT_HWCAP2 */ > > > } > > > } > > > > > > -- > > > 2.39.2 > > > > > > > Ping review. > > will apply with my next push to master > > > > > > Alternatively, can the ppc32 FATE nodes be upgraded to a distribution > > release with glibc 2.18 or higher? > > > Can I assist with that somehow? > > If you want, you can run a fate client to replace or augment the old one. > for this sent the public ssh key the cleint will use to fate-admin (email > addr > should be in the docs) > > thx > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Just a quick update: I have not forgot about this. I'm still in the middle of converting my workstation to running Linux natively instead of as a VM. Stay tuned! -- Sean McGovern _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".