Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Sean McGovern <gseanmcg@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Marton Balint <cus@passwd.hu>
Subject: Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems
Date: Thu, 22 Feb 2024 13:55:26 -0500
Message-ID: <CAPBf_OkbGc77aaUz3Dfzw9cQUcpqG2Kwynm24TF2qjjY-B5Uag@mail.gmail.com> (raw)
In-Reply-To: <20240221233429.24146-1-cus@passwd.hu>

Hi Marton,

On Wed, Feb 21, 2024 at 6:34 PM Marton Balint <cus@passwd.hu> wrote:
>
> Jpeg2000 decoder is decoding in native endian, so let's use the same workaround
> as in fate-mxf-probe-applehdr10.
>
> Fixes ticket #10868.
>
> Signed-off-by: Marton Balint <cus@passwd.hu>
> ---
>  tests/fate/mxf.mak           | 2 +-
>  tests/ref/fate/mxf-probe-j2k | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/fate/mxf.mak b/tests/fate/mxf.mak
> index 8430b01d51..3e0e70e28b 100644
> --- a/tests/fate/mxf.mak
> +++ b/tests/fate/mxf.mak
> @@ -29,7 +29,7 @@ fate-mxf-probe-dnxhd: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
>
>  FATE_MXF_PROBE-$(call DEMDEC, MXF, JPEG2000) += fate-mxf-probe-j2k
>  fate-mxf-probe-j2k: SRC = $(TARGET_SAMPLES)/imf/countdown/countdown-small.mxf
> -fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)"
> +fate-mxf-probe-j2k: CMD = run $(PROBE_FORMAT_STREAMS_COMMAND) -i "$(SRC)" | sed -e "s/rgb48../rgb48/"
>
>  FATE_MXF_PROBE-$(call DEMDEC, MXF, DVVIDEO PCM_S16LE) += fate-mxf-probe-dv25
>  fate-mxf-probe-dv25: SRC = $(TARGET_SAMPLES)/mxf/Avid-00005.mxf
> diff --git a/tests/ref/fate/mxf-probe-j2k b/tests/ref/fate/mxf-probe-j2k
> index 149b3ea0b6..517fbb99a3 100644
> --- a/tests/ref/fate/mxf-probe-j2k
> +++ b/tests/ref/fate/mxf-probe-j2k
> @@ -14,7 +14,7 @@ film_grain=0
>  has_b_frames=0
>  sample_aspect_ratio=1:1
>  display_aspect_ratio=16:9
> -pix_fmt=rgb48le
> +pix_fmt=rgb48
>  level=-99
>  color_range=unknown
>  color_space=unknown
> --
> 2.35.3
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Confirming this fixes #10868 for me.

Thanks,
Sean McGovern
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-02-22 18:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 23:34 Marton Balint
2024-02-22 18:55 ` Sean McGovern [this message]
2024-02-22 23:53 ` Tomas Härdin
2024-02-24 21:19   ` Marton Balint

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPBf_OkbGc77aaUz3Dfzw9cQUcpqG2Kwynm24TF2qjjY-B5Uag@mail.gmail.com \
    --to=gseanmcg@gmail.com \
    --cc=cus@passwd.hu \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git