Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Sean McGovern <gseanmcg@gmail.com>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le
Date: Thu, 6 Jun 2024 03:43:05 -0400
Message-ID: <CAPBf_OkRd-tJHpHw+9tgRe6J_Du3G0naXRtE5Ps+krZQ7vFAKA@mail.gmail.com> (raw)

Hi,

Attached inline is a _non-working_ implementation of flac_wasted32 for
VSX developed on a POWER9 in little-endian mode but probably just as
usable on POWER{8,10}.

I'm not sure why probably one of the simplest DSP functions in lavc
does not work for me, I imagine this is probably something endian
related even though IBM's documentation for vec_sl()[1] does not
suggest any.

Here's my code:

#define VSX_STRIDE 16

void ff_flac_wasted32_vsx(int32_t *decoded, int wasted, int len)
{
   register vec_s32 vec1;
   register vec_u32 vec2 = { wasted, wasted, wasted, wasted };
   register vec_s32 shifted;

   for (int i = 0; i < len; i += VSX_STRIDE) {
       vec1 = vec_vsx_ld(i, decoded);
       shifted = vec_sl(vec1, vec2);
       vec_vsx_st(shifted, i, decoded);
   }
}

Anyone with experience with AltiVec or VSX see something obvious I am missing?

-- Sean McGovern

[1] https://www.ibm.com/docs/en/xl-c-and-cpp-linux/16.1.1?topic=functions-vec-sl
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2024-06-06  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  7:43 Sean McGovern [this message]
2024-06-06  9:53 ` Rémi Denis-Courmont
2024-06-06 16:51   ` Sean McGovern
2024-06-26 22:01     ` Sean McGovern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPBf_OkRd-tJHpHw+9tgRe6J_Du3G0naXRtE5Ps+krZQ7vFAKA@mail.gmail.com \
    --to=gseanmcg@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git