From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7447D47CF7 for ; Wed, 18 Oct 2023 17:19:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B7D5868CA95; Wed, 18 Oct 2023 20:19:11 +0300 (EEST) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0C36968C884 for ; Wed, 18 Oct 2023 20:19:05 +0300 (EEST) Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-9c41e95efcbso555777666b.3 for ; Wed, 18 Oct 2023 10:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697649544; x=1698254344; darn=ffmpeg.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=DbXyFpGw1ET2XYA1NB+r4pjo3x05uhnINncAaxdlrhA=; b=Ci8Z/7OH9/IIKnewPfqAz15i92h72wWFQWVcyDMqVkk+QQTnR6KVm+BUxpjXCzCjWq Srl5LhWpupAGov8yHN4BgCV2BASMxC2DacpzsjF5Jp3szeqJqv0cJZ2K5Ur+m5ZxzC7O 11v7s/i3URxwgtVUoWMwrYllLLSpesY3ApOzP7gfGXpC8rPCOIHBUolAkX5P2jZWFOkU pX6AxpQXuLb/5UpXJTiz5uHECVi75rVFZHUNtsQsaUyiDPeVwL9ezhqnH3XeDPoHIdJF 25nxGBZGmlSqlDZQWBZHrrEOnQVpfWgyKEFCUSJiYkH/S/Juv3+WdnZIOknozGMaqDU5 Pr0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697649544; x=1698254344; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DbXyFpGw1ET2XYA1NB+r4pjo3x05uhnINncAaxdlrhA=; b=GVeKHC1e+uuyrnLDNraumWEkQ3g/S76sEzXDq1rMCBDMluuF6JPfYfWSsRUmBwhUnE rYwarG4SKodh7j99wjT/yky4b4ORYdAeh1xIKJERKftFE3BI2DBEcdDzGEeSgSQYukMi F/fh9gVIKbU/ThwF1MHR91k4DohRcqwIjLjn5A9OGeikakWovd5XSuvROIEdJ6/Gnmu0 e4ZBq03bilGU0bXZBIx/DCQVwLU3lhGFoF3xIz8rfr7lARkzz/KEfyj0QOWve5+OgzYI MigZo9DO3jH8jLPuGWUeK654vqTXZcSslr8Yc/3CCaXZCW1IkjJdNMzqKJyhjJYiHJ4w /niA== X-Gm-Message-State: AOJu0YyVWSv7UBq+k1GzWiDfY5o6BwtrfYjSJ3lso2y6cyIuAZ4QTSgK 5rhMwr73wj6vj6bOABlfR3G80YXDyGoNuh66ZG/T71k2 X-Google-Smtp-Source: AGHT+IHceITPOK86+TkSzujKdrYCDj2eCMJHOfueL4SL2QmQmRS3qD6X7eJugOaVeojOCx41sd4dAqVKmEb+dT8xD+Y= X-Received: by 2002:a17:907:26c1:b0:9ae:4eb9:e09b with SMTP id bp1-20020a17090726c100b009ae4eb9e09bmr4478423ejc.27.1697649543858; Wed, 18 Oct 2023 10:19:03 -0700 (PDT) MIME-Version: 1.0 References: <20231015032724.3590-1-gseanmcg@gmail.com> In-Reply-To: <20231015032724.3590-1-gseanmcg@gmail.com> From: Sean McGovern Date: Wed, 18 Oct 2023 13:18:54 -0400 Message-ID: To: ffmpeg-devel@ffmpeg.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [PATCH] libavutil/ppc/cpu.c: check that AT_HWCAP2 is defined X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, Oct 14, 2023, 23:27 Sean McGovern wrote: > It was not introduced until glibc 2.18. > --- > This should fix the ppc32 FATE node. > --- > libavutil/ppc/cpu.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c > index 96b491c716..bc8bb5f47c 100644 > --- a/libavutil/ppc/cpu.c > +++ b/libavutil/ppc/cpu.c > @@ -95,12 +95,15 @@ int ff_get_cpu_flags_ppc(void) > #endif > if (ret & AV_CPU_FLAG_VSX) > av_assert0(ret & AV_CPU_FLAG_ALTIVEC); > - } else if (buf[i] == AT_HWCAP2) { > + } > +#ifdef AT_HWCAP2 /* not introduced until glibc 2.18 */ > + else if (buf[i] == AT_HWCAP2) { > #ifdef PPC_FEATURE2_ARCH_2_07 > if (buf[i + 1] & PPC_FEATURE2_ARCH_2_07) > ret |= AV_CPU_FLAG_POWER8; > #endif > } > +#endif /* AT_HWCAP2 */ > } > } > > -- > 2.39.2 > Ping review. Alternatively, can the ppc32 FATE nodes be upgraded to a distribution release with glibc 2.18 or higher? Can I assist with that somehow? Thanks, Sean McGovern _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".