Re: [FFmpeg-devel] [PATCH] libpostproc: remove big-endian AltiVec acceleration

[Sean McGovern <gseanmcg@gmail.com>]

Hi,

On Wed, Apr 9, 2025 at 2:55 PM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> Hi Sean
>
> On Sun, Apr 06, 2025 at 12:42:30PM -0400, Sean McGovern wrote:
> > While POWER & PowerPC systems have technically
> > supported little-endian from inception,
> > it did not come into proper usage until the
> > introducion of the POWER8 in 2013.
> >
> > The AltiVec acceleration present here has not
> > had meaningful change since before then.
> >
> > refs: Trac/11120
> > ---
> >  libpostproc/postprocess.c                  |   13 -
> >  libpostproc/postprocess.h                  |    1 -
> >  libpostproc/postprocess_altivec_template.c | 1211 --------------------
> >  libpostproc/postprocess_template.c         |   31 -
> >  4 files changed, 1256 deletions(-)
> >  delete mode 100644 libpostproc/postprocess_altivec_template.c
>
> What exactly are you fixing here / what is the problem?
> You say the code hasnt been changed and you link to a ticket
> where people cant decide if they talk about big or little endian
> and that links to seemingly unrelated tickets
>
> Please clearly explain what the issue is and why this is
> the correct fix
>

We already discovered a few months back that we have no real
maintainers for these ppc pieces, so as noted in the ticket I am
working on removing them.
Is this what you want in the patch notes?

> Also you are changing public API without version bump
>

Oops, yeah OK I can do that.
Is a minor bump enough or should this be a major?

> [...]
> > index 5decb7e8a9..a88fd5a5cb 100644
> > --- a/libpostproc/postprocess.h
> > +++ b/libpostproc/postprocess.h
> > @@ -88,7 +88,6 @@ void pp_free_context(pp_context *ppContext);
> >  #define PP_CPU_CAPS_MMX   0x80000000
> >  #define PP_CPU_CAPS_MMX2  0x20000000
> >  #define PP_CPU_CAPS_3DNOW 0x40000000
> > -#define PP_CPU_CAPS_ALTIVEC 0x10000000
> >  #define PP_CPU_CAPS_AUTO  0x00080000
> >
> >  #define PP_FORMAT         0x00000008
>
> thx
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Frequently ignored answer#1 FFmpeg bugs should be sent to our bugtracker. User
> questions about the command line tools should be sent to the ffmpeg-user ML.
> And questions about how to use libav* should be sent to the libav-user ML.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

-- Sean McGovern
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".