From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AD19D49AB4 for ; Tue, 27 Feb 2024 18:59:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AA02468CD39; Tue, 27 Feb 2024 20:59:51 +0200 (EET) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0ABB668CC1F for ; Tue, 27 Feb 2024 20:59:45 +0200 (EET) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-512bd533be0so5629563e87.0 for ; Tue, 27 Feb 2024 10:59:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709060384; x=1709665184; darn=ffmpeg.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=53dwW3MmcZNY88z0raNIrwsujCWuflZcZBbrz7DRb8I=; b=dQpSFW92UU3wiB2/gxuCl7jIeDCH0SaJdp1pqzT3qIULqazB/ZV0OwxRxVfpGVkz+h BvA8as0TlXbqCJBJpb9z4HBNWorcES2REEJ1BKNv7gYRtdmJD5B6m/Ln6H4u6jGxqoxv If0dsWLwuK25lVAMZvNkuaMsGvw3T52DjpUZBDTnRQJREYVkx84MXpqJVdwyD0WJoz7l Kw4qkrHj0DkcBfvfr8E75KfPanS9V+URhIO7nQUgA0ShXBAXuGAHQVwkRKTCfWf0xifT UQz+PGLfqt/Vh/6VGbYBC6k94cv+wyQkAAfZpKWYJNBnSVDwVy5z/RDZV5FSIMagxLYD ZIYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709060384; x=1709665184; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=53dwW3MmcZNY88z0raNIrwsujCWuflZcZBbrz7DRb8I=; b=FpNY1qo9fDbAz+OXOfSVAL5tBeVeRmuONheoFQAYWbraZdAjGwDfz8re0EjLs687ne 0+im88PtgSBpSqs4bw6HJu+pquDbXLEFJhT7WHn3wL2WesSXNbs9V/StKmWVWvPkTcIQ vJMbA0hrdPbPoS+sJnJ0fFrKMYNPAC623eCrnQquLsu3m2bw1rgeNnTruO7YYWNavzIn sO4g94BoNs+veeOPz3Y0QMoBzn64+Ef7a3n1dbZsL6INAhufo80fvkGyvGdhOwWdA4Bt dTg//qow9bUKRotqsnOmTs+OI3RwOpXByVmgZ0cDIegR8fwfeB0WzNzz3bKKaVo+zynw XUHA== X-Gm-Message-State: AOJu0YxBMkfbSLw52hUpFus719iyQASFQCL4xU5vWlqvr+AjaQ6r2GYV 9VtUyBxkg6zrqJbwMv6xS3m2kVs/WiVJT2gvI53ZeM8AjUsqvlzEgXDpQTLGXh857XcJ1Z6YpED hphzK1/oTkNTR9nxJneeOWgy0kAysZmwJ X-Google-Smtp-Source: AGHT+IEdk/wpZZeIZnYiX8Y558EEQYIOF1Pv/xZUQc/MlJI5MkNhjAT/mHQm8m/szHybWzOGjTxynbIf3gDeq9u8lus= X-Received: by 2002:ac2:4d16:0:b0:513:13eb:ed40 with SMTP id r22-20020ac24d16000000b0051313ebed40mr1083828lfi.60.1709060383680; Tue, 27 Feb 2024 10:59:43 -0800 (PST) MIME-Version: 1.0 References: <20240225184429.2962707-1-gseanmcg@gmail.com> <20240225184429.2962707-2-gseanmcg@gmail.com> In-Reply-To: From: Sean McGovern Date: Tue, 27 Feb 2024 13:59:32 -0500 Message-ID: To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/1] aacenc_pred: prevent UB in ff_aac_adjust_common_pred() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: SGkgQW5kcmVhcywKCkZpcnN0IG9mZiBhbGwsIHRoYW5rcyBmb3IgaGF2aW5nIGEgbG9vayEgOikK Ck9uIFR1ZSwgRmViIDI3LCAyMDI0IGF0IDE6MzfigK9QTSBBbmRyZWFzIFJoZWluaGFyZHQKPGFu ZHJlYXMucmhlaW5oYXJkdEBvdXRsb29rLmNvbT4gd3JvdGU6Cj4KPiBTZWFuIE1jR292ZXJuOgo+ ID4gLS0tCj4gPiAgbGliYXZjb2RlYy9hYWNlbmNfcHJlZC5jIHwgNCArKystCj4gPiAgMSBmaWxl IGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4KPiA+IGRpZmYgLS1n aXQgYS9saWJhdmNvZGVjL2FhY2VuY19wcmVkLmMgYi9saWJhdmNvZGVjL2FhY2VuY19wcmVkLmMK PiA+IGluZGV4IGY4N2ZjZDVhMDAuLmQzZWZhZGU4NWUgMTAwNjQ0Cj4gPiAtLS0gYS9saWJhdmNv ZGVjL2FhY2VuY19wcmVkLmMKPiA+ICsrKyBiL2xpYmF2Y29kZWMvYWFjZW5jX3ByZWQuYwo+ID4g QEAgLTE2Miw5ICsxNjIsMTEgQEAgdm9pZCBmZl9hYWNfYWRqdXN0X2NvbW1vbl9wcmVkKEFBQ0Vu Y0NvbnRleHQgKnMsIENoYW5uZWxFbGVtZW50ICpjcGUpCj4gPiAgICAgICAgICBzY2UxLT5pY3Mu d2luZG93X3NlcXVlbmNlWzBdID09IEVJR0hUX1NIT1JUX1NFUVVFTkNFKQo+ID4gICAgICAgICAg cmV0dXJuOwo+ID4KPiA+ICsgICAgY29uc3QgaW50IG51bV9zd2IgPSBGRk1JTihzY2UwLT5pY3Mu bnVtX3N3Yiwgc2l6ZW9mKHNjZTAtPmljcy5wcmVkaWN0aW9uX3VzZWQpKTsKPiA+ICsKPiA+ICAg ICAgZm9yICh3ID0gMDsgdyA8IHNjZTAtPmljcy5udW1fd2luZG93czsgdyArPSBzY2UwLT5pY3Mu Z3JvdXBfbGVuW3ddKSB7Cj4gPiAgICAgICAgICBzdGFydCA9IDA7Cj4gPiAtICAgICAgICBmb3Ig KGcgPSAwOyBnIDwgc2NlMC0+aWNzLm51bV9zd2I7IGcrKykgewo+ID4gKyAgICAgICAgZm9yIChn ID0gMDsgZyA8IG51bV9zd2I7IGcrKykgewo+ID4gICAgICAgICAgICAgIGludCBzZmIgPSB3KjE2 K2c7Cj4gPiAgICAgICAgICAgICAgaW50IHN1bSA9IHNjZTAtPmljcy5wcmVkaWN0aW9uX3VzZWRb c2ZiXSArIHNjZTEtPmljcy5wcmVkaWN0aW9uX3VzZWRbc2ZiXTsKPiA+ICAgICAgICAgICAgICBm bG9hdCBlbmVyMCA9IDAuMGYsIGVuZXIxID0gMC4wZiwgZW5lcjAxID0gMC4wZjsKPgo+IEFzIHlv dSBjYW4gc2VlLCB0aGUgYWN0dWFsIGluZGV4IHVzZWQgZm9yIGFjY2Vzc2VzIGlzIHcqMTYgKyBn IGFuZCBub3QKPiBvbmx5IGcuIFNvIEkgd2FzIHN1cnByaXNlZCB0aGF0IHlvdXIgZml4IGZpeGVk IHRoZSB0ZXN0IChhcyB5b3UgY2xhaW0pLgo+IERpZ2dpbmcgaW50byB0aGUgY29kZSwgbnVtX3dp bmRvd3MgY2FuIGJlIGVpdGhlciAxIG9yIGVpZ2h0IGFuZCBpdCBpcwo+IG9ubHkgZWlnaHQgaWYg d2luZG93X3NlcXVlbmNlWzBdIGlzIEVJR0hUX1NIT1JUX1NFUVVFTkNFIChzZWUgbGluZXMKPiA0 NzctNDg4IGluIGFhY3BzeS5jIGFzIHdlbGwgYXMgbGluZXMgODc3LTg5NyBpbiBhYWNlbmMuYyku IEluIGNhc2UKPiB3aW5kb3dfc2VxdWVuY2VbMF0gaXMgRUlHSFRfU0hPUlRfU0VRVUVOQ0UsIHdl IGRvIG5vdCBldmVuIGVudGVyIHRoaXMKPiBsb29wIGluIGZmX2FhY19hZGp1c3RfY29tbW9uX3By ZWQoKS4gVGhpcyBtZWFucyB0aGF0IHRoZSBvdXRlciBsb29wCj4gYWJvdmUgaXMgYWN0dWFsbHkg bm90IGEgbG9vcCBhdCBhbGwgYW5kIHlvdXIgZml4IHdvdWxkIGluZGVlZCBmaXggdGhlCj4gdW5k ZWZpbmVkIGJlaGF2aW91ci4KPiBCdXQgdGhpcyBhbHNvIHNob3dzIHRoYXQgdGhpcyB3aG9sZSBj b2RlIGlzIGEgbWVzcy4gU29tZW9uZSB3aG8gYWN0dWFsbHkKPiBrbm93cyBpdCBzaG91bGQgdGFr ZSBhIGxvb2suIE9yIG1heWJlIHRoZSBncmltIHJlYXBlci4KPiBBbnl3YXksIHlvdXIgZml4IHdv dWxkIGxlYWQgdG8gYSB3ZGVjbGFyYXRpb24tYWZ0ZXItc3RhdGVtZW50IHdhcm5pbmcuCj4KCk9v b2YsIE9LIHRoYW5rcy4gSSB3YXMgd29uZGVyaW5nIGFib3V0IHRoYXQgd2hlbiBJIGxvb2tlZCBv biBQYXRjaHdvcmsuCgpUaGFua3MsCi0tIFNlYW4gTWNHb3Zlcm4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZmZtcGVnLWRldmVsIG1haWxpbmcgbGlzdApm Zm1wZWctZGV2ZWxAZmZtcGVnLm9yZwpodHRwczovL2ZmbXBlZy5vcmcvbWFpbG1hbi9saXN0aW5m by9mZm1wZWctZGV2ZWwKClRvIHVuc3Vic2NyaWJlLCB2aXNpdCBsaW5rIGFib3ZlLCBvciBlbWFp bApmZm1wZWctZGV2ZWwtcmVxdWVzdEBmZm1wZWcub3JnIHdpdGggc3ViamVjdCAidW5zdWJzY3Jp YmUiLgo=