* [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets
@ 2024-03-06 23:48 Sean McGovern
2024-03-08 15:11 ` Sean McGovern
0 siblings, 1 reply; 3+ messages in thread
From: Sean McGovern @ 2024-03-06 23:48 UTC (permalink / raw)
To: ffmpeg-devel
The reference file uses BGRA pixel format, so request it here.
---
tests/fate/ffmpeg.mak | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
index 669c878c7f..77e93693b9 100644
--- a/tests/fate/ffmpeg.mak
+++ b/tests/fate/ffmpeg.mak
@@ -62,6 +62,7 @@ fate-sub2video: CMD = framecrc -auto_conversion_filters \
FATE_SAMPLES_FFMPEG-$(call FRAMECRC, VOBSUB, DVDSUB, SCALE_FILTER) += fate-sub2video_basic
fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \
-i $(TARGET_SAMPLES)/sub/vobsub.idx \
+ -pix_fmt bgra \
-fps_mode passthrough -copyts \
-filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
-c:v rawvideo -threads 1
@@ -71,6 +72,7 @@ fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \
FATE_SAMPLES_FFMPEG-$(call FRAMECRC, SUP, PGSSUB, SCALE_FILTER RAWVIDEO_ENCODER) += fate-sub2video_time_limited
fate-sub2video_time_limited: CMD = framecrc -auto_conversion_filters \
-i $(TARGET_SAMPLES)/sub/pgs_sub.sup \
+ -pix_fmt bgra \
-fps_mode passthrough -copyts \
-t 15 \
-filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
--
2.39.2
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets
2024-03-06 23:48 [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets Sean McGovern
@ 2024-03-08 15:11 ` Sean McGovern
2024-03-25 22:07 ` Sean McGovern
0 siblings, 1 reply; 3+ messages in thread
From: Sean McGovern @ 2024-03-08 15:11 UTC (permalink / raw)
To: FFmpeg development discussions and patches
On Wed, Mar 6, 2024, 18:48 Sean McGovern <gseanmcg@gmail.com> wrote:
> The reference file uses BGRA pixel format, so request it here.
> ---
> tests/fate/ffmpeg.mak | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
> index 669c878c7f..77e93693b9 100644
> --- a/tests/fate/ffmpeg.mak
> +++ b/tests/fate/ffmpeg.mak
> @@ -62,6 +62,7 @@ fate-sub2video: CMD = framecrc -auto_conversion_filters \
> FATE_SAMPLES_FFMPEG-$(call FRAMECRC, VOBSUB, DVDSUB, SCALE_FILTER) +=
> fate-sub2video_basic
> fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \
> -i $(TARGET_SAMPLES)/sub/vobsub.idx \
> + -pix_fmt bgra \
> -fps_mode passthrough -copyts \
> -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
> -c:v rawvideo -threads 1
> @@ -71,6 +72,7 @@ fate-sub2video_basic: CMD = framecrc
> -auto_conversion_filters \
> FATE_SAMPLES_FFMPEG-$(call FRAMECRC, SUP, PGSSUB, SCALE_FILTER
> RAWVIDEO_ENCODER) += fate-sub2video_time_limited
> fate-sub2video_time_limited: CMD = framecrc -auto_conversion_filters \
> -i $(TARGET_SAMPLES)/sub/pgs_sub.sup \
> + -pix_fmt bgra \
> -fps_mode passthrough -copyts \
> -t 15 \
> -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
> --
> 2.39.2
>
Ping review, if someone has some cycle.
-- Sean McGovern
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets
2024-03-08 15:11 ` Sean McGovern
@ 2024-03-25 22:07 ` Sean McGovern
0 siblings, 0 replies; 3+ messages in thread
From: Sean McGovern @ 2024-03-25 22:07 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Hi,
On Fri, Mar 8, 2024, 10:11 Sean McGovern <gseanmcg@gmail.com> wrote:
> On Wed, Mar 6, 2024, 18:48 Sean McGovern <gseanmcg@gmail.com> wrote:
>
>> The reference file uses BGRA pixel format, so request it here.
>> ---
>> tests/fate/ffmpeg.mak | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak
>> index 669c878c7f..77e93693b9 100644
>> --- a/tests/fate/ffmpeg.mak
>> +++ b/tests/fate/ffmpeg.mak
>> @@ -62,6 +62,7 @@ fate-sub2video: CMD = framecrc -auto_conversion_filters
>> \
>> FATE_SAMPLES_FFMPEG-$(call FRAMECRC, VOBSUB, DVDSUB, SCALE_FILTER) +=
>> fate-sub2video_basic
>> fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \
>> -i $(TARGET_SAMPLES)/sub/vobsub.idx \
>> + -pix_fmt bgra \
>> -fps_mode passthrough -copyts \
>> -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
>> -c:v rawvideo -threads 1
>> @@ -71,6 +72,7 @@ fate-sub2video_basic: CMD = framecrc
>> -auto_conversion_filters \
>> FATE_SAMPLES_FFMPEG-$(call FRAMECRC, SUP, PGSSUB, SCALE_FILTER
>> RAWVIDEO_ENCODER) += fate-sub2video_time_limited
>> fate-sub2video_time_limited: CMD = framecrc -auto_conversion_filters \
>> -i $(TARGET_SAMPLES)/sub/pgs_sub.sup \
>> + -pix_fmt bgra \
>> -fps_mode passthrough -copyts \
>> -t 15 \
>> -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \
>> --
>> 2.39.2
>
>
Ping review again, I was rather hoping this could make it into 7.0.
-- Sean McGovern
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-25 22:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-06 23:48 [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets Sean McGovern
2024-03-08 15:11 ` Sean McGovern
2024-03-25 22:07 ` Sean McGovern
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git